Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31251 ) Change subject: mb/google/{hatch,sarien}: Configure GPIOs using cnl_configure_pads ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/31251/1/src/mainboard/google/sarien/ramstage... File src/mainboard/google/sarien/ramstage.c: https://review.coreboot.org/#/c/31251/1/src/mainboard/google/sarien/ramstage... PS1, Line 31: /* Workaround FSP issue by reprogramming GPIOs after FSP-S */ : static void mainboard_init(struct device *dev) : { : const struct pad_config *gpio_table; : size_t num_gpios; : : gpio_table = variant_gpio_table(&num_gpios); : gpio_configure_pads(gpio_table, num_gpios); : } Should be able to kill this now. -- To view, visit https://review.coreboot.org/c/coreboot/+/31251 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9973c6c49154f1225f0ac34a3240a0d19f911f18 Gerrit-Change-Number: 31251 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Comment-Date: Tue, 05 Feb 2019 22:12:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment