Attention is currently required from: Paul Menzel, Stefan Reinauer. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54385 ) Change subject: Documentation: Add proposal to allow enabling serial console with a flag ...................................................................... Patch Set 3: (1 comment) File Documentation/technotes/2021-05-selectable-serial-console.md: https://review.coreboot.org/c/coreboot/+/54385/comment/b48f7400_c124055b PS1, Line 112: and change the default to whatever is found there.

I updated the proposal to use a cbfs file (created with cbfstool add-int). SGTM in general, but you removed the part about forgoing the bootblock now? That part is still important -- remember that non-x86 platforms can't access flash until a lot of other initialization in the bootblock has happened. (Also -- this is just something to keep in mind for the implementation -- you'll need some safeguards to avoid recursion when the CBFS code tries to print things.)

-- To view, visit https://review.coreboot.org/c/coreboot/+/54385 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1b0efc55880095f9d5d6d6e448f2c8677d57ff5 Gerrit-Change-Number: 54385 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Comment-Date: Thu, 03 Jun 2021 21:55:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi@google.com> Comment-In-Reply-To: Julius Werner <jwerner@chromium.org> Gerrit-MessageType: comment