Hello John Zhao, I'd like you to do a code review. Please visit https://review.coreboot.org/20833 to review the following change. Change subject: fsp driver: Call cbmem_init_top ...................................................................... fsp driver: Call cbmem_init_top Initialize cbmem_top Change-Id: I82ffe35980ee3896bf58867830e128fe6767ab53 Signed-off-by: zhaojohn <john.zhao@intel.com> --- M src/drivers/intel/fsp2_0/memory_init.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/20833/1 diff --git a/src/drivers/intel/fsp2_0/memory_init.c b/src/drivers/intel/fsp2_0/memory_init.c index e982576..859b045 100644 --- a/src/drivers/intel/fsp2_0/memory_init.c +++ b/src/drivers/intel/fsp2_0/memory_init.c @@ -125,6 +125,8 @@ if (fsp_find_reserved_memory(&fsp_mem)) die("Failed to find FSP_RESERVED_MEMORY_RESOURCE_HOB!\n"); + cbmem_init_top(); + /* initialize cbmem by adding FSP reserved memory first thing */ if (!s3wake) { cbmem_initialize_empty_id_size(CBMEM_ID_FSP_RESERVED_MEMORY, -- To view, visit https://review.coreboot.org/20833 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I82ffe35980ee3896bf58867830e128fe6767ab53 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 1 Gerrit-Owner: John Zhao <john.zhao@intel.corp-partner.google.com> Gerrit-Reviewer: John Zhao <john.zhao@intel.com>