build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27369 ) Change subject: soc/intel/basecode: Add support for updating ucode loaded via FIT ...................................................................... Patch Set 57: (5 comments) https://review.coreboot.org/c/coreboot/+/27369/57/src/soc/intel/common/basec... File src/soc/intel/common/basecode/fw_update/ucode_update.c: https://review.coreboot.org/c/coreboot/+/27369/57/src/soc/intel/common/basec... PS57, Line 255: BOOT_STATE_INIT_ENTRY(BS_PRE_DEVICE, BS_ON_ENTRY, ucode_fw_sync, NULL); adding a line without newline at end of file https://review.coreboot.org/c/coreboot/+/27369/57/src/soc/intel/common/basec... File src/soc/intel/common/basecode/include/intelbasecode/ucode_update.h: https://review.coreboot.org/c/coreboot/+/27369/57/src/soc/intel/common/basec... PS57, Line 7: * This is a weak implementation to reboot after ucode update is finished. trailing whitespace https://review.coreboot.org/c/coreboot/+/27369/57/src/soc/intel/common/basec... PS57, Line 14: * enabled. This returns non-zero if recovery mode enabled and can be overridden by trailing whitespace https://review.coreboot.org/c/coreboot/+/27369/57/src/soc/intel/common/basec... PS57, Line 20: * This checks if the currently running microcode matches with the one in staging area and trailing whitespace https://review.coreboot.org/c/coreboot/+/27369/57/src/soc/intel/common/basec... PS57, Line 21: * the current slot. If they do not match update the staging area with the right version and trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/27369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab6ba36a2eb587f331fe522c778e2c430c8eb655 Gerrit-Change-Number: 27369 Gerrit-PatchSet: 57 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi@intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu@intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu@intel.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla@intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s@intel.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma@intel.com> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: Dhaval Sharma <dhaval.v.sharma@intel.corp-partner.google.com> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-CC: rushikesh s kadam <rushikesh.s.kadam@intel.com> Gerrit-Comment-Date: Sun, 01 Nov 2020 11:56:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment