Change in coreboot[master]: cpu/intel: Remove broken URLs
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44235 ) Change subject: cpu/intel: Remove broken URLs ...................................................................... cpu/intel: Remove broken URLs These links no longer work. Drop them. They still exist in git history. Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Signed-off-by: Angel Pons <th3fanbus@gmail.com> --- M src/cpu/intel/model_65x/model_65x_init.c M src/cpu/intel/model_67x/model_67x_init.c M src/cpu/intel/model_68x/model_68x_init.c M src/cpu/intel/model_6bx/model_6bx_init.c M src/cpu/intel/model_6xx/model_6xx_init.c 5 files changed, 0 insertions(+), 62 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/44235/1 diff --git a/src/cpu/intel/model_65x/model_65x_init.c b/src/cpu/intel/model_65x/model_65x_init.c index cf1394a..8989eec 100644 --- a/src/cpu/intel/model_65x/model_65x_init.c +++ b/src/cpu/intel/model_65x/model_65x_init.c @@ -28,16 +28,6 @@ .init = model_65x_init, }; -/* - * Intel Pentium II Processor Specification Update - * http://download.intel.com/design/PentiumII/specupdt/24333749.pdf - * - * Mobile Intel Pentium II Processor Specification Update - * http://download.intel.com/design/intarch/specupdt/24388757.pdf - * - * Intel Pentium II Xeon Processor Specification Update - * http://download.intel.com/support/processors/pentiumii/xeon/24377632.pdf - */ static const struct cpu_device_id cpu_table[] = { { X86_VENDOR_INTEL, 0x0650 }, /* PII/Celeron, dA0/mdA0/A0 */ { X86_VENDOR_INTEL, 0x0651 }, /* PII/Celeron, dA1/A1 */ diff --git a/src/cpu/intel/model_67x/model_67x_init.c b/src/cpu/intel/model_67x/model_67x_init.c index 427d658..6cfa96c 100644 --- a/src/cpu/intel/model_67x/model_67x_init.c +++ b/src/cpu/intel/model_67x/model_67x_init.c @@ -31,13 +31,6 @@ .init = model_67x_init, }; -/* - * Intel Pentium III Processor Identification and Package Information - * http://www.intel.com/design/pentiumiii/qit/update.pdf - * - * Intel Pentium III Processor Specification Update - * http://download.intel.com/design/intarch/specupdt/24445358.pdf - */ static const struct cpu_device_id cpu_table[] = { { X86_VENDOR_INTEL, 0x0671 }, { X86_VENDOR_INTEL, 0x0672 }, /* PIII, kB0 */ diff --git a/src/cpu/intel/model_68x/model_68x_init.c b/src/cpu/intel/model_68x/model_68x_init.c index 3402c60..22ce332 100644 --- a/src/cpu/intel/model_68x/model_68x_init.c +++ b/src/cpu/intel/model_68x/model_68x_init.c @@ -35,19 +35,6 @@ .init = model_68x_init, }; -/* - * Intel Celeron Processor Identification Information - * http://www.intel.com/design/celeron/qit/update.pdf - * - * Intel Pentium III Processor Identification and Package Information - * http://www.intel.com/design/pentiumiii/qit/update.pdf - * - * Intel Pentium III Processor Specification Update - * http://download.intel.com/design/intarch/specupdt/24445358.pdf - * - * Mobile Intel Pentium III/III-M Processor Specification Update - * http://download.intel.com/design/intarch/specupdt/24530663.pdf - */ static const struct cpu_device_id cpu_table[] = { { X86_VENDOR_INTEL, 0x0680 }, { X86_VENDOR_INTEL, 0x0681 }, /* PIII, cA2/cA2c/A2/BA2/PA2/MA2 */ diff --git a/src/cpu/intel/model_6bx/model_6bx_init.c b/src/cpu/intel/model_6bx/model_6bx_init.c index 2e7069c..3d633bf 100644 --- a/src/cpu/intel/model_6bx/model_6bx_init.c +++ b/src/cpu/intel/model_6bx/model_6bx_init.c @@ -35,13 +35,6 @@ .init = model_6bx_init, }; -/* - * Pentium III Processor Identification and Package Information. - * http://www.intel.com/design/pentiumiii/qit/update.pdf - * - * Intel Pentium III Processor Specification Update - * http://download.intel.com/design/intarch/specupdt/24445358.pdf - */ static const struct cpu_device_id cpu_table[] = { { X86_VENDOR_INTEL, 0x06b1 }, /* Pentium III/Celeron, tA1/A1/FPA1 */ { X86_VENDOR_INTEL, 0x06b4 }, /* Pentium III, tB1/FPB1 */ diff --git a/src/cpu/intel/model_6xx/model_6xx_init.c b/src/cpu/intel/model_6xx/model_6xx_init.c index 2e93507b..a6944d3 100644 --- a/src/cpu/intel/model_6xx/model_6xx_init.c +++ b/src/cpu/intel/model_6xx/model_6xx_init.c @@ -25,31 +25,6 @@ .init = model_6xx_init, }; -/* - * Intel Pentium Pro Processor Specification Update - * http://download.intel.com/design/archives/processors/pro/docs/24268935.pdf - * - * Intel Pentium II Processor Specification Update - * http://download.intel.com/design/PentiumII/specupdt/24333749.pdf - * - * Mobile Intel Pentium II Processor Specification Update - * http://download.intel.com/design/intarch/specupdt/24388757.pdf - * - * Intel Celeron Processor Identification Information - * http://www.intel.com/design/celeron/qit/update.pdf - * - * Intel Pentium II Xeon Processor Specification Update - * http://download.intel.com/support/processors/pentiumii/xeon/24377632.pdf - * - * Intel Pentium III Processor Identification and Package Information - * http://www.intel.com/design/pentiumiii/qit/update.pdf - * - * Intel Pentium III Processor Specification Update - * http://download.intel.com/design/intarch/specupdt/24445358.pdf - * - * Mobile Intel Pentium III/III-M Processor Specification Update - * http://download.intel.com/design/intarch/specupdt/24530663.pdf - */ static const struct cpu_device_id cpu_table[] = { { X86_VENDOR_INTEL, 0x0611 }, /* Pentium Pro, B0 */ { X86_VENDOR_INTEL, 0x0612 }, /* Pentium Pro, C0 */ -- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-MessageType: newchange
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44235 ) Change subject: cpu/intel: Remove broken URLs ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/44235/1/src/cpu/intel/model_67x/mod... File src/cpu/intel/model_67x/model_67x_init.c: https://review.coreboot.org/c/coreboot/+/44235/1/src/cpu/intel/model_67x/mod... PS1, Line 39: * http://download.intel.com/design/intarch/specupdt/24445358.pdf Please leave the document number in there. -- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 05 Aug 2020 20:56:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44235 ) Change subject: cpu/intel: Remove broken URLs ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/44235/1/src/cpu/intel/model_67x/mod... File src/cpu/intel/model_67x/model_67x_init.c: https://review.coreboot.org/c/coreboot/+/44235/1/src/cpu/intel/model_67x/mod... PS1, Line 39: * http://download.intel.com/design/intarch/specupdt/24445358.pdf
Please leave the document number in there. I don't think it would be good for anything. Old document numbers aren't helpful when looking for the actual document, looking for the title name is probably easier. Moreover, newer CPUs don't have any comments at all. And as stated in the commit message, this is still available in git history.
-- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 05 Aug 2020 21:07:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44235 ) Change subject: cpu/intel: Remove broken URLs ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/44235/1/src/cpu/intel/model_67x/mod... File src/cpu/intel/model_67x/model_67x_init.c: https://review.coreboot.org/c/coreboot/+/44235/1/src/cpu/intel/model_67x/mod... PS1, Line 39: * http://download.intel.com/design/intarch/specupdt/24445358.pdf
I don't think it would be good for anything. […] I once mailed Intel about broken links and they were responsive in making documents available again so there might be some use in keeping it? The document titles could indeed be useful.
-- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 06 Aug 2020 07:03:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Hello Keith Hui, build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/44235 to look at the new patch set (#2). Change subject: cpu/intel: Remove broken URLs ...................................................................... cpu/intel: Remove broken URLs These links no longer work. Drop them. They still exist in git history. Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Signed-off-by: Angel Pons <th3fanbus@gmail.com> --- M src/cpu/intel/model_65x/model_65x_init.c M src/cpu/intel/model_67x/model_67x_init.c M src/cpu/intel/model_68x/model_68x_init.c M src/cpu/intel/model_6bx/model_6bx_init.c M src/cpu/intel/model_6xx/model_6xx_init.c 5 files changed, 0 insertions(+), 62 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/44235/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44235 ) Change subject: cpu/intel: Remove broken URLs ...................................................................... Abandoned I've no patience for this -- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: abandon
Angel Pons has restored this change. ( https://review.coreboot.org/c/coreboot/+/44235 ) Change subject: cpu/intel: Remove broken URLs ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: restore
Hello Keith Hui, build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/44235 to look at the new patch set (#3). Change subject: cpu/intel/model_6xx: Drop duplicated URLs ...................................................................... cpu/intel/model_6xx: Drop duplicated URLs People want to keep them for some reason, but one copy is enough. Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Signed-off-by: Angel Pons <th3fanbus@gmail.com> --- M src/cpu/intel/model_6xx/model_6xx_init.c 1 file changed, 0 insertions(+), 33 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/44235/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Hello Keith Hui, build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/44235 to look at the new patch set (#4). Change subject: cpu/intel/model_6xx: Drop duplicated URLs ...................................................................... cpu/intel/model_6xx: Drop duplicated URLs People want to keep them for some reason, but one copy is enough. Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Signed-off-by: Angel Pons <th3fanbus@gmail.com> --- M src/cpu/intel/model_6xx/model_6xx_init.c 1 file changed, 0 insertions(+), 33 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/44235/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44235 ) Change subject: cpu/intel/model_6xx: Drop duplicated URLs ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/coreboot/+/44235/1/src/cpu/intel/model_67x/mod... File src/cpu/intel/model_67x/model_67x_init.c: https://review.coreboot.org/c/coreboot/+/44235/1/src/cpu/intel/model_67x/mod... PS1, Line 39: * http://download.intel.com/design/intarch/specupdt/24445358.pdf
I once mailed Intel about broken links and they were responsive in making documents available again […] Fiiiiiiiine, I'll leave the broken links here...
I've shuffled the commits around a bit: I removed (with git rebase) this change, propagated all links while unifying files, and now this commit deduplicates them. Of course, I've mentioned that duplicated links are handled later (here). -- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 06 Aug 2020 11:49:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz> Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44235 ) Change subject: cpu/intel/model_6xx: Drop duplicated URLs ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Comment-Date: Thu, 06 Aug 2020 12:36:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44235 ) Change subject: cpu/intel/model_6xx: Drop duplicated URLs ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Comment-Date: Thu, 06 Aug 2020 15:44:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
HAOUAS Elyes has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/44235 ) Change subject: cpu/intel/model_6xx: Drop duplicated URLs ...................................................................... Removed Code-Review+2 by HAOUAS Elyes <ehaouas@noos.fr> -- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-MessageType: deleteVote
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44235 ) Change subject: cpu/intel/model_6xx: Drop duplicated URLs ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 06 Aug 2020 15:49:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44235 ) Change subject: cpu/intel/model_6xx: Drop duplicated URLs ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 06 Aug 2020 15:56:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44235 ) Change subject: cpu/intel/model_6xx: Drop duplicated URLs ...................................................................... Patch Set 6: Code-Review-2 No. This change doesn't make any damn sense without the predecessor changes. So, why are there so many +2's here? -- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 6 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Sun, 09 Aug 2020 13:11:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44235 ) Change subject: cpu/intel/model_6xx: Drop duplicated URLs ...................................................................... Abandoned Sorry, I ran out of patience and energy to care about these changes any longer. -- To view, visit https://review.coreboot.org/c/coreboot/+/44235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1083dbde1c9199a56f711b0230a1bfe6d3174be9 Gerrit-Change-Number: 44235 Gerrit-PatchSet: 6 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: abandon
participants (4)
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
HAOUAS Elyes (Code Review)
-
Paul Menzel (Code Review)