Change in ...coreboot[master]: mb/lenovo/x131e: devicetree updates
James has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31066 Change subject: mb/lenovo/x131e: devicetree updates ...................................................................... mb/lenovo/x131e: devicetree updates Enable the mSATA slot and WWAN detection (functionality untested). Change-Id: I4cfefb06556c9d69bc8e4a4f9d112246885c253a Signed-off-by: James Ye <jye836@gmail.com> --- M src/mainboard/lenovo/x131e/devicetree.cb 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/31066/1 diff --git a/src/mainboard/lenovo/x131e/devicetree.cb b/src/mainboard/lenovo/x131e/devicetree.cb index 4adc94b..3d0148f 100644 --- a/src/mainboard/lenovo/x131e/devicetree.cb +++ b/src/mainboard/lenovo/x131e/devicetree.cb @@ -51,8 +51,8 @@ register "gpi6_routing" = "2" register "gpi13_routing" = "2" - # Enable SATA ports - register "sata_port_map" = "0x1" + # Enable SATA ports 0 (2.5 inch) and 1 (mSATA) + register "sata_port_map" = "0x3" # Set max SATA speed to 6.0 Gb/s register "sata_interface_speed_support" = "0x3" @@ -131,6 +131,12 @@ register "eventd_enable" = "0xff" register "evente_enable" = "0xff" register "eventf_enable" = "0xff" + + register "has_bdc_detection" = "0" + + register "has_wwan_detection" = "1" + register "wwan_gpio_num" = "68" + register "wwan_gpio_lvl" = "0" end end device pci 1f.2 on end # SATA Controller 1 -- To view, visit https://review.coreboot.org/c/coreboot/+/31066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfefb06556c9d69bc8e4a4f9d112246885c253a Gerrit-Change-Number: 31066 Gerrit-PatchSet: 1 Gerrit-Owner: James <jye836@gmail.com> Gerrit-MessageType: newchange
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31066 ) Change subject: mb/lenovo/x131e: devicetree updates ...................................................................... Patch Set 1: (2 comments) Two commits would be nice, so they can be easily reverted in case of errors. https://review.coreboot.org/#/c/31066/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/31066/1//COMMIT_MSG@7 PS1, Line 7: mb/lenovo/x131e: devicetree updates Please make this a statement by using a verb (in imperative mood):
Update devicetree
Otherwise it’s not clear, what is done with the updates: added, removed, …? https://review.coreboot.org/#/c/31066/1//COMMIT_MSG@10 PS1, Line 10: Please elaborate, how you tested this.
Non-working mSATA slot, is working now.
-- To view, visit https://review.coreboot.org/c/coreboot/+/31066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfefb06556c9d69bc8e4a4f9d112246885c253a Gerrit-Change-Number: 31066 Gerrit-PatchSet: 1 Gerrit-Owner: James Ye <jye836@gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: James Ye <jye836@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 24 Jan 2019 11:16:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
James Ye has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31066 ) Change subject: mb/lenovo/x131e: devicetree updates ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/31066/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/31066/1//COMMIT_MSG@10 PS1, Line 10:
Please elaborate, how you tested this. […] Unfortunately I can't test that mSATA works. This change brings x131e in line with google/stout, which AFAIK uses the mSATA slot.
I have tested that the slot being enabled but unpopulated doesn't cause issues. If this isn't good enough, then I'll revert the mSATA change. I also can't test that WWAN detection completely works, but it does correctly detect the non-presence of a card. This change is according to the schematic, so I'm more confident it works. -- To view, visit https://review.coreboot.org/c/coreboot/+/31066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfefb06556c9d69bc8e4a4f9d112246885c253a Gerrit-Change-Number: 31066 Gerrit-PatchSet: 1 Gerrit-Owner: James Ye <jye836@gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: James Ye <jye836@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 24 Jan 2019 11:29:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment
Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/31066 to look at the new patch set (#2). Change subject: mb/lenovo/x131e: enable WWAN detection ...................................................................... mb/lenovo/x131e: enable WWAN detection Per schematic. Functionality untested. Change-Id: I4cfefb06556c9d69bc8e4a4f9d112246885c253a Signed-off-by: James Ye <jye836@gmail.com> --- M src/mainboard/lenovo/x131e/devicetree.cb 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/31066/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/31066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfefb06556c9d69bc8e4a4f9d112246885c253a Gerrit-Change-Number: 31066 Gerrit-PatchSet: 2 Gerrit-Owner: James <jye836@gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: James <jye836@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31066 ) Change subject: mb/lenovo/x131e: enable WWAN detection ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/31066/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/31066/1//COMMIT_MSG@10 PS1, Line 10:
Unfortunately I can't test that mSATA works. […] Nice, but it’d be great if you added that.
https://review.coreboot.org/#/c/31066/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/31066/2//COMMIT_MSG@9 PS2, Line 9: Per schematic. Functionality untested. … but non-presence is detected fine. -- To view, visit https://review.coreboot.org/c/coreboot/+/31066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfefb06556c9d69bc8e4a4f9d112246885c253a Gerrit-Change-Number: 31066 Gerrit-PatchSet: 2 Gerrit-Owner: James <jye836@gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: James <jye836@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 12 Feb 2019 11:42:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: James <jye836@gmail.com> Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment
Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/31066 to look at the new patch set (#3). Change subject: mb/lenovo/x131e: enable WWAN detection ...................................................................... mb/lenovo/x131e: enable WWAN detection Per schematic. Non-presence is detected correctly, but presence is untested. Change-Id: I4cfefb06556c9d69bc8e4a4f9d112246885c253a Signed-off-by: James Ye <jye836@gmail.com> --- M src/mainboard/lenovo/x131e/devicetree.cb 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/31066/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/31066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfefb06556c9d69bc8e4a4f9d112246885c253a Gerrit-Change-Number: 31066 Gerrit-PatchSet: 3 Gerrit-Owner: James <jye836@gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: James <jye836@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
James has removed Paul Menzel from this change. ( https://review.coreboot.org/c/coreboot/+/31066 ) Change subject: mb/lenovo/x131e: enable WWAN detection ...................................................................... Removed reviewer Paul Menzel. -- To view, visit https://review.coreboot.org/c/coreboot/+/31066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfefb06556c9d69bc8e4a4f9d112246885c253a Gerrit-Change-Number: 31066 Gerrit-PatchSet: 3 Gerrit-Owner: James <jye836@gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: James <jye836@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: deleteReviewer
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31066?usp=email ) Change subject: mb/lenovo/x131e: enable WWAN detection ...................................................................... Abandoned This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author. -- To view, visit https://review.coreboot.org/c/coreboot/+/31066?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfefb06556c9d69bc8e4a4f9d112246885c253a Gerrit-Change-Number: 31066 Gerrit-PatchSet: 3 Gerrit-Owner: James <jye836@gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: James <jye836@gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-MessageType: abandon
participants (4)
-
James (Code Review) -
James Ye (Code Review)
-
Martin L Roth (Code Review)
-
Paul Menzel (Code Review)