Change in ...coreboot[master]: mb/apple: Add MacBook Pro 8,1 support
Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33151 Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 (A1278). Works: - Graphics initialization (libgfxinit) - GRUB payload - Linux (it boots) Mostly untested for now. This board has SOIC-8 chip, 25Q064A in my case. WARNING: do not just use a clip to flash the chip as usual. There is a capacitor and a resistor right near the VCC pin. They prevent the clip from being properly attached. You can very easily break them. Either cut off some plasic from the clip so that it doesn't touch them, or don't use clip at all. Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c A src/mainboard/apple/macbookpro8_1/romstage.c 16 files changed, 816 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/1 diff --git a/src/mainboard/apple/macbookpro8_1/Kconfig b/src/mainboard/apple/macbookpro8_1/Kconfig new file mode 100644 index 0000000..c838bea --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/Kconfig @@ -0,0 +1,43 @@ +if BOARD_APPLE_MACBOOKPRO8_1 + +config BOARD_SPECIFIC_OPTIONS + def_bool y + select BOARD_ROMSIZE_KB_8192 + select EC_ACPI + select HAVE_ACPI_RESUME + select HAVE_ACPI_TABLES + select INTEL_INT15 + select NORTHBRIDGE_INTEL_SANDYBRIDGE + select SERIRQ_CONTINUOUS_MODE + select SOUTHBRIDGE_INTEL_BD82X6X + select SYSTEM_TYPE_LAPTOP + select USE_NATIVE_RAMINIT + select MAINBOARD_HAS_LIBGFXINIT + select GFX_GMA_INTERNAL_IS_LVDS + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE + +config MAINBOARD_DIR + string + default apple/macbookpro8_1 + +config MAINBOARD_PART_NUMBER + string + default "MacBookPro8,1" + +config VGA_BIOS_FILE + string + default "pci8086,0126.rom" + +config VGA_BIOS_ID + string + default "8086,0126" + +config DRAM_RESET_GATE_GPIO + int + default 28 + +config MAX_CPUS + int + default 8 +endif diff --git a/src/mainboard/apple/macbookpro8_1/Kconfig.name b/src/mainboard/apple/macbookpro8_1/Kconfig.name new file mode 100644 index 0000000..06a7de5 --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/Kconfig.name @@ -0,0 +1,2 @@ +config BOARD_APPLE_MACBOOKPRO8_1 + bool "MacBookPro8,1" diff --git a/src/mainboard/apple/macbookpro8_1/Makefile.inc b/src/mainboard/apple/macbookpro8_1/Makefile.inc new file mode 100644 index 0000000..ebe01ae --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/Makefile.inc @@ -0,0 +1,2 @@ +romstage-y += gpio.c +ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads diff --git a/src/mainboard/apple/macbookpro8_1/acpi/ec.asl b/src/mainboard/apple/macbookpro8_1/acpi/ec.asl new file mode 100644 index 0000000..cd74865 --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/acpi/ec.asl @@ -0,0 +1,18 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (c) 2019 Evgeny Zinoviev <me@ch1p.io> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <ec/apple/acpi/ec.asl> +#include <ec/apple/acpi/ac_60.asl> +#include <ec/apple/acpi/lid_60.asl> diff --git a/src/mainboard/apple/macbookpro8_1/acpi/platform.asl b/src/mainboard/apple/macbookpro8_1/acpi/platform.asl new file mode 100644 index 0000000..3603581 --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/acpi/platform.asl @@ -0,0 +1,21 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +Method(_WAK,1) +{ + Return(Package(){0,0}) +} + +Method(_PTS,1) +{ +} diff --git a/src/mainboard/apple/macbookpro8_1/acpi/superio.asl b/src/mainboard/apple/macbookpro8_1/acpi/superio.asl new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/acpi/superio.asl diff --git a/src/mainboard/apple/macbookpro8_1/acpi_tables.c b/src/mainboard/apple/macbookpro8_1/acpi_tables.c new file mode 100644 index 0000000..6b731cc --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/acpi_tables.c @@ -0,0 +1,36 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Vladimir Serbinenko + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <southbridge/intel/bd82x6x/nvs.h> + +/* FIXME: check this function. */ +void acpi_create_gnvs(global_nvs_t *gnvs) +{ + /* Disable USB ports in S3 by default */ + gnvs->s3u0 = 0; + gnvs->s3u1 = 0; + + /* Disable USB ports in S5 by default */ + gnvs->s5u0 = 0; + gnvs->s5u1 = 0; + + // the lid is open by default. + gnvs->lids = 1; + + gnvs->tcrt = 100; + gnvs->tpsv = 90; +} diff --git a/src/mainboard/apple/macbookpro8_1/board_info.txt b/src/mainboard/apple/macbookpro8_1/board_info.txt new file mode 100644 index 0000000..8e0e321 --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/board_info.txt @@ -0,0 +1,6 @@ +Category: laptop +ROM protocol: SPI +Flashrom support: n +ROM package: SOIC-8 +ROM socketed: n +Release year: 2011 diff --git a/src/mainboard/apple/macbookpro8_1/cmos.default b/src/mainboard/apple/macbookpro8_1/cmos.default new file mode 100644 index 0000000..53e85a3 --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/cmos.default @@ -0,0 +1 @@ +debug_level=Debug diff --git a/src/mainboard/apple/macbookpro8_1/cmos.layout b/src/mainboard/apple/macbookpro8_1/cmos.layout new file mode 100644 index 0000000..aa9f563 --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/cmos.layout @@ -0,0 +1,114 @@ +## +## This file is part of the coreboot project. +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +# ----------------------------------------------------------------- +entries + +# ----------------------------------------------------------------- +# Status Register A +# ----------------------------------------------------------------- +# Status Register B +# ----------------------------------------------------------------- +# Status Register C +#96 4 r 0 status_c_rsvd +#100 1 r 0 uf_flag +#101 1 r 0 af_flag +#102 1 r 0 pf_flag +#103 1 r 0 irqf_flag +# ----------------------------------------------------------------- +# Status Register D +#104 7 r 0 status_d_rsvd +#111 1 r 0 valid_cmos_ram +# ----------------------------------------------------------------- +# Diagnostic Status Register +#112 8 r 0 diag_rsvd1 + +# ----------------------------------------------------------------- +0 120 r 0 reserved_memory +#120 264 r 0 unused + +# ----------------------------------------------------------------- +# RTC_BOOT_BYTE (coreboot hardcoded) +384 1 e 4 boot_option +388 4 h 0 reboot_counter +#390 2 r 0 unused? + +# ----------------------------------------------------------------- +# coreboot config options: console +#392 3 r 0 unused +395 4 e 6 debug_level +#399 1 r 0 unused + +#400 8 r 0 reserved for century byte + +# coreboot config options: southbridge +408 1 e 1 nmi +409 2 e 7 power_on_after_fail + +# coreboot config options: EC +#411 1 e 8 first_battery +#412 1 e 1 bluetooth +#413 1 e 1 wwan +#414 1 e 1 touchpad +#415 1 e 1 wlan +#416 1 e 1 trackpoint +#417 1 e 1 fn_ctrl_swap +#418 1 e 1 sticky_fn +#419 2 e 13 usb_always_on +#421 1 e 9 sata_mode +#422 2 e 10 backlight + +# coreboot config options: cpu +#424 8 r 0 unused + +# coreboot config options: northbridge +#432 5 e 11 gfx_uma_size +#437 3 r 0 unused +#440 8 h 0 volume + +# SandyBridge MRC Scrambler Seed values +896 32 r 0 mrc_scrambler_seed +928 32 r 0 mrc_scrambler_seed_s3 +960 16 r 0 mrc_scrambler_seed_chk + +# coreboot config options: check sums +984 16 h 0 check_sum + +# ----------------------------------------------------------------- + +enumerations + +#ID value text +1 0 Disable +1 1 Enable +2 0 Enable +2 1 Disable +4 0 Fallback +4 1 Normal +6 0 Emergency +6 1 Alert +6 2 Critical +6 3 Error +6 4 Warning +6 5 Notice +6 6 Info +6 7 Debug +6 8 Spew +7 0 Disable +7 1 Enable +7 2 Keep + +# ----------------------------------------------------------------- +checksums + +checksum 392 447 984 diff --git a/src/mainboard/apple/macbookpro8_1/devicetree.cb b/src/mainboard/apple/macbookpro8_1/devicetree.cb new file mode 100644 index 0000000..db21a62 --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/devicetree.cb @@ -0,0 +1,113 @@ +chip northbridge/intel/sandybridge # FIXME: check gfx.ndid and gfx.did + register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }" + register "gfx.link_frequency_270_mhz" = "1" + register "gfx.ndid" = "3" + register "gfx.use_spread_spectrum_clock" = "1" + register "gpu_cpu_backlight" = "0x00001312" + register "gpu_dp_b_hotplug" = "4" + register "gpu_dp_c_hotplug" = "4" + register "gpu_dp_d_hotplug" = "4" + register "gpu_panel_port_select" = "0" + register "gpu_panel_power_backlight_off_delay" = "2000" + register "gpu_panel_power_backlight_on_delay" = "2000" + register "gpu_panel_power_cycle_delay" = "5" + register "gpu_panel_power_down_delay" = "500" + register "gpu_panel_power_up_delay" = "600" + register "gpu_pch_backlight" = "0x13121312" + + device cpu_cluster 0x0 on + chip cpu/intel/model_206ax + register "c1_acpower" = "1" + register "c1_battery" = "1" + register "c2_acpower" = "3" + register "c2_battery" = "3" + register "c3_acpower" = "5" + register "c3_battery" = "5" + device lapic 0x0 on + end + device lapic 0xacac off + end + end + end + + register "pci_mmio_size" = "2048" + + device domain 0x0 on + chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH + register "c2_latency" = "0x0065" + register "docking_supported" = "0" + register "gen1_dec" = "0x000c0681" + register "gen2_dec" = "0x000c1641" + register "gen3_dec" = "0x001c0301" + register "gen4_dec" = "0x00fc0701" + register "gpi7_routing" = "2" + register "p_cnt_throttling_supported" = "1" + register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" + register "pcie_port_coalesce" = "1" + register "sata_interface_speed_support" = "0x3" + register "sata_port_map" = "0x3" + register "spi_lvscc" = "0x0" + register "spi_uvscc" = "0x2005" + device pci 16.0 on # Management Engine Interface 1 + subsystemid 0x8086 0x7270 + end + device pci 16.1 off end # Management Engine Interface 2 + device pci 16.2 off end # Management Engine IDE-R + device pci 16.3 off end # Management Engine KT + device pci 19.0 off end # Intel Gigabit Ethernet + device pci 1a.0 on # USB2 EHCI #2 Unsupported PCI device 8086:1c2c + subsystemid 0x8086 0x7270 + end + device pci 1b.0 on # High Definition Audio Audio controller + subsystemid 0x8086 0x7270 + end + device pci 1c.0 on # PCIe Port #1 + subsystemid 0x8086 0x7270 + end + device pci 1c.1 on # PCIe Port #2 + subsystemid 0x8086 0x7270 + end + device pci 1c.2 on # PCIe Port #3 + subsystemid 0x8086 0x7270 + end + device pci 1c.3 off end # PCIe Port #4 + device pci 1c.4 off end # PCIe Port #5 + device pci 1c.5 off end # PCIe Port #6 + device pci 1c.6 off end # PCIe Port #7 + device pci 1c.7 off end # PCIe Port #8 + device pci 1d.0 on # USB2 EHCI #1 Unsupported PCI device 8086:1c27 + subsystemid 0x8086 0x7270 + end + device pci 1e.0 off end # PCI bridge + device pci 1f.0 on # LPC bridge PCI-LPC bridge + subsystemid 0x8086 0x7270 + end + device pci 1f.2 on # SATA Controller 1 + subsystemid 0x8086 0x7270 + end + device pci 1f.3 on # SMBus + subsystemid 0x8086 0x7270 + end + device pci 1f.5 off end # SATA Controller 2 + device pci 1f.6 off end # Thermal + end + device pci 00.0 on # Host bridge Host bridge + subsystemid 0x106b 0x00db + end + device pci 01.0 off # PCIe Bridge for discrete graphics + subsystemid 0x106b 0x00db + end + device pci 02.0 on # Internal graphics VGA controller + subsystemid 0x106b 0x00db + end + device pci 01.1 on + subsystemid 0x106b 0x00db + end + device pci 1a.7 on + subsystemid 0x8086 0x7270 + end + device pci 1d.7 on + subsystemid 0x8086 0x7270 + end + end +end diff --git a/src/mainboard/apple/macbookpro8_1/dsdt.asl b/src/mainboard/apple/macbookpro8_1/dsdt.asl new file mode 100644 index 0000000..455ac17 --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/dsdt.asl @@ -0,0 +1,42 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB +#define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB +#define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 + +#include <arch/acpi.h> +DefinitionBlock( + "dsdt.aml", + "DSDT", + 0x02, // DSDT revision: ACPI 2.0 and up + OEM_ID, + ACPI_TABLE_CREATOR, + 0x20141018 // OEM revision +) +{ + /* Some generic macros */ + #include "acpi/platform.asl" + #include <cpu/intel/common/acpi/cpu.asl> + #include <southbridge/intel/bd82x6x/acpi/platform.asl> + /* global NVS and variables. */ + #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> + #include <southbridge/intel/bd82x6x/acpi/sleepstates.asl> + + Device (\_SB.PCI0) + { + #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> + #include <southbridge/intel/bd82x6x/acpi/pch.asl> + } +} diff --git a/src/mainboard/apple/macbookpro8_1/gpio.c b/src/mainboard/apple/macbookpro8_1/gpio.c new file mode 100644 index 0000000..d3555ef --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/gpio.c @@ -0,0 +1,231 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Vladimir Serbinenko + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <southbridge/intel/common/gpio.h> + +static const struct pch_gpio_set1 pch_gpio_set1_mode = { + .gpio0 = GPIO_MODE_GPIO, + .gpio1 = GPIO_MODE_GPIO, + .gpio2 = GPIO_MODE_GPIO, + .gpio3 = GPIO_MODE_GPIO, + .gpio4 = GPIO_MODE_GPIO, + .gpio5 = GPIO_MODE_GPIO, + .gpio6 = GPIO_MODE_GPIO, + .gpio7 = GPIO_MODE_GPIO, + .gpio8 = GPIO_MODE_GPIO, + .gpio9 = GPIO_MODE_GPIO, + .gpio10 = GPIO_MODE_GPIO, + .gpio11 = GPIO_MODE_GPIO, + .gpio12 = GPIO_MODE_GPIO, + .gpio13 = GPIO_MODE_GPIO, + .gpio14 = GPIO_MODE_GPIO, + .gpio15 = GPIO_MODE_GPIO, + .gpio16 = GPIO_MODE_GPIO, + .gpio17 = GPIO_MODE_GPIO, + .gpio18 = GPIO_MODE_NATIVE, + .gpio19 = GPIO_MODE_GPIO, + .gpio20 = GPIO_MODE_NATIVE, + .gpio21 = GPIO_MODE_GPIO, + .gpio22 = GPIO_MODE_GPIO, + .gpio23 = GPIO_MODE_GPIO, + .gpio24 = GPIO_MODE_GPIO, + .gpio25 = GPIO_MODE_NATIVE, + .gpio26 = GPIO_MODE_NATIVE, + .gpio27 = GPIO_MODE_GPIO, + .gpio28 = GPIO_MODE_GPIO, + .gpio29 = GPIO_MODE_GPIO, + .gpio30 = GPIO_MODE_NATIVE, + .gpio31 = GPIO_MODE_NATIVE, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_direction = { + .gpio0 = GPIO_DIR_INPUT, + .gpio1 = GPIO_DIR_INPUT, + .gpio2 = GPIO_DIR_INPUT, + .gpio3 = GPIO_DIR_INPUT, + .gpio4 = GPIO_DIR_INPUT, + .gpio5 = GPIO_DIR_INPUT, + .gpio6 = GPIO_DIR_INPUT, + .gpio7 = GPIO_DIR_INPUT, + .gpio8 = GPIO_DIR_INPUT, + .gpio9 = GPIO_DIR_INPUT, + .gpio10 = GPIO_DIR_INPUT, + .gpio11 = GPIO_DIR_INPUT, + .gpio12 = GPIO_DIR_INPUT, + .gpio13 = GPIO_DIR_INPUT, + .gpio14 = GPIO_DIR_INPUT, + .gpio15 = GPIO_DIR_INPUT, + .gpio16 = GPIO_DIR_OUTPUT, + .gpio17 = GPIO_DIR_INPUT, + .gpio19 = GPIO_DIR_INPUT, + .gpio21 = GPIO_DIR_OUTPUT, + .gpio22 = GPIO_DIR_OUTPUT, + .gpio23 = GPIO_DIR_OUTPUT, + .gpio24 = GPIO_DIR_INPUT, + .gpio27 = GPIO_DIR_INPUT, + .gpio28 = GPIO_DIR_INPUT, + .gpio29 = GPIO_DIR_INPUT, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_level = { + .gpio16 = GPIO_LEVEL_LOW, + .gpio21 = GPIO_LEVEL_LOW, + .gpio22 = GPIO_LEVEL_LOW, + .gpio23 = GPIO_LEVEL_HIGH, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_reset = { + .gpio24 = GPIO_RESET_RSMRST, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_invert = { + .gpio1 = GPIO_INVERT, + .gpio4 = GPIO_INVERT, + .gpio5 = GPIO_INVERT, + .gpio7 = GPIO_INVERT, + .gpio9 = GPIO_INVERT, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_blink = { +}; + +static const struct pch_gpio_set2 pch_gpio_set2_mode = { + .gpio32 = GPIO_MODE_NATIVE, + .gpio33 = GPIO_MODE_GPIO, + .gpio34 = GPIO_MODE_GPIO, + .gpio35 = GPIO_MODE_GPIO, + .gpio36 = GPIO_MODE_GPIO, + .gpio37 = GPIO_MODE_GPIO, + .gpio38 = GPIO_MODE_GPIO, + .gpio39 = GPIO_MODE_GPIO, + .gpio40 = GPIO_MODE_GPIO, + .gpio41 = GPIO_MODE_GPIO, + .gpio42 = GPIO_MODE_GPIO, + .gpio43 = GPIO_MODE_GPIO, + .gpio44 = GPIO_MODE_GPIO, + .gpio45 = GPIO_MODE_GPIO, + .gpio46 = GPIO_MODE_GPIO, + .gpio47 = GPIO_MODE_NATIVE, + .gpio48 = GPIO_MODE_GPIO, + .gpio49 = GPIO_MODE_GPIO, + .gpio50 = GPIO_MODE_GPIO, + .gpio51 = GPIO_MODE_NATIVE, + .gpio52 = GPIO_MODE_GPIO, + .gpio53 = GPIO_MODE_NATIVE, + .gpio54 = GPIO_MODE_NATIVE, + .gpio55 = GPIO_MODE_NATIVE, + .gpio56 = GPIO_MODE_NATIVE, + .gpio57 = GPIO_MODE_GPIO, + .gpio58 = GPIO_MODE_NATIVE, + .gpio59 = GPIO_MODE_GPIO, + .gpio60 = GPIO_MODE_NATIVE, + .gpio61 = GPIO_MODE_NATIVE, + .gpio62 = GPIO_MODE_NATIVE, + .gpio63 = GPIO_MODE_NATIVE, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_direction = { + .gpio33 = GPIO_DIR_OUTPUT, + .gpio34 = GPIO_DIR_OUTPUT, + .gpio35 = GPIO_DIR_INPUT, + .gpio36 = GPIO_DIR_INPUT, + .gpio37 = GPIO_DIR_OUTPUT, + .gpio38 = GPIO_DIR_OUTPUT, + .gpio39 = GPIO_DIR_OUTPUT, + .gpio40 = GPIO_DIR_INPUT, + .gpio41 = GPIO_DIR_INPUT, + .gpio42 = GPIO_DIR_INPUT, + .gpio43 = GPIO_DIR_INPUT, + .gpio44 = GPIO_DIR_INPUT, + .gpio45 = GPIO_DIR_OUTPUT, + .gpio46 = GPIO_DIR_INPUT, + .gpio48 = GPIO_DIR_OUTPUT, + .gpio49 = GPIO_DIR_OUTPUT, + .gpio50 = GPIO_DIR_INPUT, + .gpio52 = GPIO_DIR_INPUT, + .gpio57 = GPIO_DIR_INPUT, + .gpio59 = GPIO_DIR_INPUT, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_level = { + .gpio33 = GPIO_LEVEL_LOW, + .gpio34 = GPIO_LEVEL_HIGH, + .gpio37 = GPIO_LEVEL_LOW, + .gpio38 = GPIO_LEVEL_LOW, + .gpio39 = GPIO_LEVEL_LOW, + .gpio45 = GPIO_LEVEL_LOW, + .gpio48 = GPIO_LEVEL_HIGH, + .gpio49 = GPIO_LEVEL_LOW, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_reset = { +}; + +static const struct pch_gpio_set3 pch_gpio_set3_mode = { + .gpio64 = GPIO_MODE_GPIO, + .gpio65 = GPIO_MODE_GPIO, + .gpio66 = GPIO_MODE_GPIO, + .gpio67 = GPIO_MODE_GPIO, + .gpio68 = GPIO_MODE_GPIO, + .gpio69 = GPIO_MODE_GPIO, + .gpio70 = GPIO_MODE_GPIO, + .gpio71 = GPIO_MODE_GPIO, + .gpio72 = GPIO_MODE_NATIVE, + .gpio73 = GPIO_MODE_NATIVE, + .gpio74 = GPIO_MODE_NATIVE, + .gpio75 = GPIO_MODE_NATIVE, +}; + +static const struct pch_gpio_set3 pch_gpio_set3_direction = { + .gpio64 = GPIO_DIR_INPUT, + .gpio65 = GPIO_DIR_INPUT, + .gpio66 = GPIO_DIR_INPUT, + .gpio67 = GPIO_DIR_INPUT, + .gpio68 = GPIO_DIR_INPUT, + .gpio69 = GPIO_DIR_INPUT, + .gpio70 = GPIO_DIR_INPUT, + .gpio71 = GPIO_DIR_INPUT, +}; + +static const struct pch_gpio_set3 pch_gpio_set3_level = { +}; + +static const struct pch_gpio_set3 pch_gpio_set3_reset = { +}; + +const struct pch_gpio_map mainboard_gpio_map = { + .set1 = { + .mode = &pch_gpio_set1_mode, + .direction = &pch_gpio_set1_direction, + .level = &pch_gpio_set1_level, + .blink = &pch_gpio_set1_blink, + .invert = &pch_gpio_set1_invert, + .reset = &pch_gpio_set1_reset, + }, + .set2 = { + .mode = &pch_gpio_set2_mode, + .direction = &pch_gpio_set2_direction, + .level = &pch_gpio_set2_level, + .reset = &pch_gpio_set2_reset, + }, + .set3 = { + .mode = &pch_gpio_set3_mode, + .direction = &pch_gpio_set3_direction, + .level = &pch_gpio_set3_level, + .reset = &pch_gpio_set3_reset, + }, +}; diff --git a/src/mainboard/apple/macbookpro8_1/hda_verb.c b/src/mainboard/apple/macbookpro8_1/hda_verb.c new file mode 100644 index 0000000..d6cb85e --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/hda_verb.c @@ -0,0 +1,76 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Vladimir Serbinenko + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <device/azalia_device.h> + +const u32 cim_verb_data[] = { + 0x10134206, /* Codec Vendor / Device ID: Cirrus */ + 0x106b1c00, /* Subsystem ID */ + + 0x0000000b, /* Number of 4 dword sets */ + /* NID 0x01: Subsystem ID. */ + AZALIA_SUBVENDOR(0x0, 0x106b1c00), + + /* NID 0x09. */ + AZALIA_PIN_CFG(0x0, 0x09, 0x012b4030), + + /* NID 0x0a. */ + AZALIA_PIN_CFG(0x0, 0x0a, 0x90100121), + + /* NID 0x0b. */ + AZALIA_PIN_CFG(0x0, 0x0b, 0x90100120), + + /* NID 0x0c. */ + AZALIA_PIN_CFG(0x0, 0x0c, 0x400000f0), + + /* NID 0x0d. */ + AZALIA_PIN_CFG(0x0, 0x0d, 0x90a00110), + + /* NID 0x0e. */ + AZALIA_PIN_CFG(0x0, 0x0e, 0x400000f0), + + /* NID 0x0f. */ + AZALIA_PIN_CFG(0x0, 0x0f, 0x400000f0), + + /* NID 0x10. */ + AZALIA_PIN_CFG(0x0, 0x10, 0x004be040), + + /* NID 0x12. */ + AZALIA_PIN_CFG(0x0, 0x12, 0x400000f0), + + /* NID 0x15. */ + AZALIA_PIN_CFG(0x0, 0x15, 0x400000f0), + 0x80862805, /* Codec Vendor / Device ID: Intel */ + 0x80860101, /* Subsystem ID */ + + 0x00000004, /* Number of 4 dword sets */ + /* NID 0x01: Subsystem ID. */ + AZALIA_SUBVENDOR(0x3, 0x80860101), + + /* NID 0x05. */ + AZALIA_PIN_CFG(0x3, 0x05, 0x18560010), + + /* NID 0x06. */ + AZALIA_PIN_CFG(0x3, 0x06, 0x18560010), + + /* NID 0x07. */ + AZALIA_PIN_CFG(0x3, 0x07, 0x18560010), +}; + +const u32 pc_beep_verbs[0] = {}; + +AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/apple/macbookpro8_1/mainboard.c b/src/mainboard/apple/macbookpro8_1/mainboard.c new file mode 100644 index 0000000..fe63303 --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/mainboard.c @@ -0,0 +1,39 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Evgeny Zinoviev <me@ch1p.io> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <device/device.h> +#include <drivers/intel/gma/int15.h> +#include <southbridge/intel/bd82x6x/pch.h> +#include <ec/acpi/ec.h> +#include <console/console.h> + +static void mainboard_init(struct device *dev) +{ + RCBA32(0x38c8) = 0x00002005; + RCBA32(0x38c4) = 0x00800000; +} + +static void mainboard_enable(struct device *dev) +{ + dev->ops->init = mainboard_init; + + install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, + GMA_INT15_PANEL_FIT_DEFAULT, + GMA_INT15_BOOT_DISPLAY_DEFAULT, 0); +} + +struct chip_operations mainboard_ops = { + .enable_dev = mainboard_enable, +}; diff --git a/src/mainboard/apple/macbookpro8_1/romstage.c b/src/mainboard/apple/macbookpro8_1/romstage.c new file mode 100644 index 0000000..4dffacb --- /dev/null +++ b/src/mainboard/apple/macbookpro8_1/romstage.c @@ -0,0 +1,72 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Vladimir Serbinenko + * Copyright (C) 2019 Evgeny Zinoviev <me@ch1p.io> + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <stdint.h> +#include <string.h> +#include <arch/byteorder.h> +#include <device/pci_ops.h> +#include <device/pnp_ops.h> +#include <console/console.h> +#include <northbridge/intel/sandybridge/sandybridge.h> +#include <northbridge/intel/sandybridge/raminit_native.h> +#include <southbridge/intel/bd82x6x/pch.h> + +void pch_enable_lpc(void) +{ + pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x3f0f); + pci_write_config32(PCI_DEV(0, 0x1f, 0), 0x84, 0x000c0681); + pci_write_config32(PCI_DEV(0, 0x1f, 0), 0x88, 0x000c1641); + pci_write_config32(PCI_DEV(0, 0x1f, 0), 0x8c, 0x001c0301); + pci_write_config32(PCI_DEV(0, 0x1f, 0), 0x90, 0x00fc0701); + pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0070); +} + +void mainboard_rcba_config(void) +{ +} + +const struct southbridge_usb_port mainboard_usb_ports[] = { + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, + { 1, 0, -1 }, +}; + +void mainboard_early_init(int s3resume) +{ +} + +void mainboard_config_superio(void) +{ +} + +void mainboard_get_spd(spd_raw_data *spd, bool id_only) +{ + read_spd(&spd[0], 0x50, id_only); + read_spd(&spd[1], 0x51, id_only); +} -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.com> Gerrit-MessageType: newchange
Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#2). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 (A1278). Works: - Graphics initialization (libgfxinit) - GRUB payload - Linux (it boots) Mostly untested for now. This board has SOIC-8 chip, 25Q064A in my case. WARNING: do not just use a clip to flash the chip as usual. There is a capacitor and a resistor right near the VCC pin. They prevent the clip from being properly attached. You can very easily break them. Either cut off some plasic from the clip so that it doesn't touch them, or don't use clip at all. Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c A src/mainboard/apple/macbookpro8_1/romstage.c 17 files changed, 850 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 2 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 5: It works quite well. I'll write the documentation soon. -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 5 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 25 Oct 2019 23:06:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#6). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire This board has SOIC-8 chip, 25Q064A in my case. WARNING: do not just use a clip to flash the chip as usual. There is a resistor right near the VCC pin. It prevents the clip from being properly attached. You can very easily break it. Either cut off some plasic from the clip so that it doesn't touch them, or don't use clip at all. Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c A src/mainboard/apple/macbookpro8_1/romstage.c 17 files changed, 849 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 6 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#7). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire This board has SOIC-8 chip, 25Q064A in my case. WARNING: do not just use a clip to flash the chip as usual. There is a resistor right near the VCC pin. It prevents the clip from being properly attached. You can very easily break it. Either cut off some plasic from the clip so that it wouldn't touch it, or don't use clip at all. Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c A src/mainboard/apple/macbookpro8_1/romstage.c 17 files changed, 849 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 7 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 7: Most of the comments from CB:32673 also apply to this machine. I haven't checked, but maybe they can be made variants of the same board? -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 7 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 01 Nov 2019 11:25:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 8: (33 comments) https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/Makefile.inc: PS8: You would want this to build with current master: bootblock-y += early_init.c bootblock-y += gpio.c romstage-y += early_init.c romstage-y += gpio.c ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 31: // Make this comment a C-style comment, so that it is consistent with the other comments https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/cmos.layout: https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 55: 408 1 e 1 nmi Doesn't have a default https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 56: 409 2 e 7 power_on_after_fail Doesn't have a default https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 58: # coreboot config options: EC : #411 1 e 8 first_battery : #412 1 e 1 bluetooth : #413 1 e 1 wwan : #414 1 e 1 touchpad : #415 1 e 1 wlan : #416 1 e 1 trackpoint : #417 1 e 1 fn_ctrl_swap : #418 1 e 1 sticky_fn : #419 2 e 13 usb_always_on : #421 1 e 9 sata_mode : #422 2 e 10 backlight : : # coreboot config options: cpu : #424 8 r 0 unused : : # coreboot config options: northbridge : #432 5 e 11 gfx_uma_size : #437 3 r 0 unused : #440 8 h 0 volume This is all commented-out https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 94: 2 0 Enable : 2 1 Disable Unused https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 1: FIXME: check gfx.ndid and gfx.did You might as well drop them https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 27: end Please "pick up" these `end` (put them on the previous line) https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 35: device domain 0x0 on Right after this line, add: subsystemid 0x8086 0x7270 inherit Then drop the redundant subsystemid entries. https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 38: register "docking_supported" = "0" Can drop this https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 44: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" Can drop this https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 57: Unsupported PCI device 8086:1c2c I think you can drop this https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 60: Audio controller You can drop this redundant part https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 77: Unsupported PCI device 8086:1c27 I think you can drop this https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 81: PCI-LPC bridge This can be dropped too https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 93: Host bridge Redundant https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 93: device pci 00.0 on # Host bridge Host bridge : subsystemid 0x106b 0x00db : end : device pci 01.0 off # PCIe Bridge for discrete graphics : subsystemid 0x106b 0x00db : end : device pci 02.0 on # Internal graphics VGA controller : subsystemid 0x106b 0x00db : end This should go right after this line: subsystemid 0x8086 0x7270 inherit https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 102: device pci 01.1 on What's this? https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 105: device pci 1a.7 on What's this? https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 108: device pci 1d.7 on What's this? https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 28: /* Some generic macros */ Please drop this comment https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 21: Cirrus Cirrus... CS4206? https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 24: 0x0000000b Replace with `12`. Also, align the comments with tabs https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 25: /* NID 0x01: Subsystem ID. */ You can drop these comments https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 26: 0x0 Refers to codec number 0, so it should be decimal https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 29: 0x0 Same for all of these https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 57: 0x80862805, /* Codec Vendor / Device ID: Intel */ You might want to add some spacing between the two codecs https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 60: 0x00000004 Same as above https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 62: 0x3 Same as above https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 65: 0x3 Same as above https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 24: RCBA32(0x38c8) = 0x00002005; What does this do? https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/romstage.c: PS8: This was renamed to early_init.c https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 30: { I would use the already-existing macros to do this -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 8 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 29 Dec 2019 22:48:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#9). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro8_1.md A Documentation/mainboard/apple/mbp81_chip.jpg A Documentation/mainboard/apple/mbp81_clip.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/early_init.c A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c 21 files changed, 821 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 9 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 9: (2 comments) https://review.coreboot.org/c/coreboot/+/33151/9/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/33151/9/src/mainboard/apple/macbook... PS9, Line 26: AZALIA_SUBVENDOR(0, 0x106b1c00), please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/33151/9/src/mainboard/apple/macbook... PS9, Line 38: 0x80862805, /* Codec Vendor / Device ID: Intel */ please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 9 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 31 Jan 2020 21:34:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#10). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro8_1.md A Documentation/mainboard/apple/mbp81_chip.jpg A Documentation/mainboard/apple/mbp81_clip.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/early_init.c A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c 21 files changed, 821 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 10 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 10: (2 comments) https://review.coreboot.org/c/coreboot/+/33151/10/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/33151/10/src/mainboard/apple/macboo... PS10, Line 26: AZALIA_SUBVENDOR(0, 0x106b1c00), please, no spaces at the start of a line https://review.coreboot.org/c/coreboot/+/33151/10/src/mainboard/apple/macboo... PS10, Line 38: 0x80862805, /* Codec Vendor / Device ID: Intel */ please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 10 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 31 Jan 2020 21:36:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#11). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro8_1.md A Documentation/mainboard/apple/mbp81_chip.jpg A Documentation/mainboard/apple/mbp81_clip.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/early_init.c A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c 21 files changed, 821 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 11 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 11: (31 comments) https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/Makefile.inc: PS8:
You would want this to build with current master: […] Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/cmos.layout: https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 55: 408 1 e 1 nmi
Doesn't have a default Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 56: 409 2 e 7 power_on_after_fail
Doesn't have a default Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 58: # coreboot config options: EC : #411 1 e 8 first_battery : #412 1 e 1 bluetooth : #413 1 e 1 wwan : #414 1 e 1 touchpad : #415 1 e 1 wlan : #416 1 e 1 trackpoint : #417 1 e 1 fn_ctrl_swap : #418 1 e 1 sticky_fn : #419 2 e 13 usb_always_on : #421 1 e 9 sata_mode : #422 2 e 10 backlight : : # coreboot config options: cpu : #424 8 r 0 unused : : # coreboot config options: northbridge : #432 5 e 11 gfx_uma_size : #437 3 r 0 unused : #440 8 h 0 volume
This is all commented-out Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 94: 2 0 Enable : 2 1 Disable
Unused Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 1: FIXME: check gfx.ndid and gfx.did
You might as well drop them Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 27: end
Please "pick up" these `end` (put them on the previous line) Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 35: device domain 0x0 on
Right after this line, add: […] Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 38: register "docking_supported" = "0"
Can drop this Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 44: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }"
Can drop this Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 57: Unsupported PCI device 8086:1c2c
I think you can drop this Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 60: Audio controller
You can drop this redundant part Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 77: Unsupported PCI device 8086:1c27
I think you can drop this Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 81: PCI-LPC bridge
This can be dropped too Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 93: Host bridge
Redundant Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 93: device pci 00.0 on # Host bridge Host bridge : subsystemid 0x106b 0x00db : end : device pci 01.0 off # PCIe Bridge for discrete graphics : subsystemid 0x106b 0x00db : end : device pci 02.0 on # Internal graphics VGA controller : subsystemid 0x106b 0x00db : end
This should go right after this line: […] Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 102: device pci 01.1 on
What's this? Was added by autoport. Usually discrete graphics. Removed.
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 105: device pci 1a.7 on
What's this? No idea. I don't see any issues after removing.
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 108: device pci 1d.7 on
What's this? Same.
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 28: /* Some generic macros */
Please drop this comment Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 21: Cirrus
Cirrus... […] Yes.
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 24: 0x0000000b
Replace with `12`. […] But 0b is 11.
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 25: /* NID 0x01: Subsystem ID. */
You can drop these comments Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 26: 0x0
Refers to codec number 0, so it should be decimal Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 29: 0x0
Same for all of these Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 57: 0x80862805, /* Codec Vendor / Device ID: Intel */
You might want to add some spacing between the two codecs Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 60: 0x00000004
Same as above Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 62: 0x3
Same as above Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 65: 0x3
Same as above Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/romstage.c: PS8:
This was renamed to early_init. […] Done
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 30: {
I would use the already-existing macros to do this I guess it can be removed now.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 11 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 31 Jan 2020 21:37:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 11: (17 comments) https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... File Documentation/mainboard/apple/macbookpro8_1.md: https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... PS11, Line 32: 00000000:00000fff fd Does this get formatted as a block of code? https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... PS11, Line 57: - Thunderbolt : - FireWire Do the respective controllers enumerate properly on PCIe? https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... File Documentation/mainboard/apple/mbp81_chip.jpg: PS11: You can make this image a bit smaller, there's no need to see so much fan https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/Kconfig: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 1: BOARD_APPLE_MACBOOKPRO8_1 nit: This would read better if you separate the numbers: BOARD_APPLE_MACBOOKPRO_8_1 https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 22: macbookpro8_1 Same here https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 28: config VGA_BIOS_FILE : string : default "pci8086,0126.rom" : : config VGA_BIOS_ID : string : default "8086,0126" Did you test the VBIOS? https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 23: /* Disable USB ports in S3 by default */ : gnvs->s3u0 = 0; : gnvs->s3u1 = 0; : : /* Disable USB ports in S5 by default */ : gnvs->s5u0 = 0; : gnvs->s5u1 = 0; These can be dropped, as they are zero already. https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 16: 0x0 These can be simply zero https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 31: 0x0 This one as well https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 37: subsystemid 0x106b 0x00db If it's off, does it need a subsystemid? https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 60: Audio Audio Is it stereo audio? I would shorten this as "HD Audio Controller" https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 12: : : #define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB : #define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB : #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 Are you using these? https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/early_init.c: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 18: Are you using all these headers? https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 30: Hub USB port, you mean? In any case, it should be routed to an OC# pin. https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 30: Analog Really? https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 24: RCBA32(0x38c8) = 0x00002005; : RCBA32(0x38c4) = 0x00800000; Aren't these doing the same as the VSCC settings in the devicetree? https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 32: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, : GMA_INT15_PANEL_FIT_DEFAULT, : GMA_INT15_BOOT_DISPLAY_DEFAULT, 0); Does this work? -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 11 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 31 Jan 2020 22:20:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 11: (5 comments) https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... File Documentation/mainboard/apple/macbookpro8_1.md: https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... PS11, Line 32: 00000000:00000fff fd
Does this get formatted as a block of code? Yes.
https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... PS11, Line 57: - Thunderbolt : - FireWire
Do the respective controllers enumerate properly on PCIe? Yes.
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/Kconfig: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 1: BOARD_APPLE_MACBOOKPRO8_1
nit: This would read better if you separate the numbers: […] Then we need to change macbookair4_2 and other ports as well. Changing it in only one board doesn't feel right.
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/early_init.c: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 30: Hub
USB port, you mean? […] This is what schematics says. And I don't see it routed to any OC# pin, or I'm stupid.
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 30: Analog
Really? This is just a copy pasta that is used across the boards. Let's remove it from many boards in separate commit.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 11 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 31 Jan 2020 22:30:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#12). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro8_1.md A Documentation/mainboard/apple/mbp81_chip.jpg A Documentation/mainboard/apple/mbp81_clip.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/early_init.c A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c 21 files changed, 789 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 12 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 12: (8 comments) https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 23: /* Disable USB ports in S3 by default */ : gnvs->s3u0 = 0; : gnvs->s3u1 = 0; : : /* Disable USB ports in S5 by default */ : gnvs->s5u0 = 0; : gnvs->s5u1 = 0;
These can be dropped, as they are zero already. Done
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 16: 0x0
These can be simply zero Done
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 31: 0x0
This one as well Done
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 37: subsystemid 0x106b 0x00db
If it's off, does it need a subsystemid? Done
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 60: Audio Audio
Is it stereo audio? I would shorten this as "HD Audio Controller" Of course it's stereo!
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 12: : : #define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB : #define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB : #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Are you using these? Done
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/early_init.c: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 18:
Are you using all these headers? Done
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 24: RCBA32(0x38c8) = 0x00002005; : RCBA32(0x38c4) = 0x00800000;
Aren't these doing the same as the VSCC settings in the devicetree? You're right.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 12 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 31 Jan 2020 22:57:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 12: (1 comment) https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... File Documentation/mainboard/apple/mbp81_chip.jpg: PS11:
You can make this image a bit smaller, there's no need to see so much fan Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 12 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 31 Jan 2020 22:58:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#13). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro8_1.md A Documentation/mainboard/apple/mbp81_chip.jpg A Documentation/mainboard/apple/mbp81_clip.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/early_init.c A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c 21 files changed, 788 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 13 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 13: (18 comments) https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... File Documentation/mainboard/apple/macbookpro8_1.md: https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... PS11, Line 32: 00000000:00000fff fd
Yes. Ack
https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... PS11, Line 57: - Thunderbolt : - FireWire
Yes. Ack, good enough
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 102: device pci 01.1 on
Was added by autoport. Usually discrete graphics. Removed. Ah, it's the result of bifurcating the PEG port. if PEG is unused, then it can be removed
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 105: device pci 1a.7 on
No idea. I don't see any issues after removing. Doesn't it show up in lspci? It looks like some USB controller device, but it's weird that it appears here...
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 60: Audio Audio
Of course it's stereo! :^)
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 31: 0x0 0 https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/early_init.c: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 30: Hub
This is what schematics says. And I don't see it routed to any OC# pin, or I'm stupid. <rant> OF COURSE, ONLY APPLE would use DISCRETE USB HUBS instead of the USB ports on the PCH! </rant>
This means that the FAULT1# and FAULT2# signals coming out of U4600 (TPS2561DR) only go to these SMSC hubs (USB2514, USB2514B or USX2513B), which would handle the condition. So yes, no PCH OC# pin is actually used as such. https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 30: Analog
This is just a copy pasta that is used across the boards. […] You only need to keep Internal and the DP/HDMI groups, as per schematics.
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/gpio.c: https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 30: gpio9 This is OC5#, but it's used as a GPIO (SDCONN_STATE_CHANGE) https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 31: gpio10 This is OC6#, but it's used as a GPIO (PCH_GPIO10_OC6_L) https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 35: gpio14 This is OC7#, but it's used as a GPIO (PCH_GPIO14_OC7_L) https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 74: GPIO_DIR_INPUT This should be an output in order to activate the SATA redriver U4510 (PS8521A) https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 115: gpio40 This is OC1#, but it's used as a GPIO (USB_HUB_SOFT_RESET_L) https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 116: gpio41 This is OC2#, but it's used as a GPIO (SDCONN_STATE_RST_L) https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 117: gpio42 This is OC3#, but it's used as a GPIO (ENET_PWR_EN) https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 118: gpio43 This is OC4#, but it's used as a GPIO (PCH_GPIO43_OC4_L) https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 134: gpio59 This is OC0#, but it's used as a GPIO (AP_PWR_EN) https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 161: GPIO_DIR_INPUT Schematics suggest that this should be an output, but there's a pull-up resistor already, so it doesn't really matter much. -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 13 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 01 Feb 2020 13:15:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 13: (1 comment) https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 36: device pci 01.0 off end # PCIe Bridge for discrete graphics PCIe is muxed, need to add 01.1 as well (used for Thunderbolt) -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 13 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 01 Feb 2020 13:16:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 13: (1 comment) https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/gpio.c: https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 30: gpio9
This is OC5#, but it's used as a GPIO (SDCONN_STATE_CHANGE) are you suggesting to change all this, or what?
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 13 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 01 Feb 2020 13:27:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 13: (1 comment) https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 36: device pci 01.0 off end # PCIe Bridge for discrete graphics
PCIe is muxed, need to add 01. […] Nothing changed in lspci after adding, is it supposed to?
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 13 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 01 Feb 2020 13:45:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 13: (3 comments) https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/Kconfig: https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 1: BOARD_APPLE_MACBOOKPRO8_1
Then we need to change macbookair4_2 and other ports as well. […] Ack
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 22: macbookpro8_1
Same here Ack
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/gpio.c: https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 30: gpio9
are you suggesting to change all this, or what? No, I was keeping track of what the OC# pins were.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 13 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 01 Feb 2020 14:23:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 13: (1 comment) https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 36: device pci 01.0 off end # PCIe Bridge for discrete graphics
Nothing changed in lspci after adding, is it supposed to? Well, you would want to set the correct subsystemid. Also, adding the device with a comment allows others to understand the devicetree. Note that, as PCI spec says that function 0 should always be enabled, you may need to enable 01.0 in order to see 01.1
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 13 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 01 Feb 2020 14:31:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#14). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro8_1.md A Documentation/mainboard/apple/mbp81_chip.jpg A Documentation/mainboard/apple/mbp81_clip.jpg M Documentation/mainboard/index.md D src/ec/apple/acpi/ac.asl D src/ec/apple/acpi/battery.asl D src/ec/apple/acpi/ec.asl D src/ec/apple/acpi/lid.asl A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/early_init.c A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c 25 files changed, 797 insertions(+), 320 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 14 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 14: (2 comments) https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 31: 0x0
0 Done
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 36: device pci 01.0 off end # PCIe Bridge for discrete graphics
Well, you would want to set the correct subsystemid. […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 14 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 02 Feb 2020 18:41:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#15). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro8_1.md A Documentation/mainboard/apple/mbp81_chip.jpg A Documentation/mainboard/apple/mbp81_clip.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/early_init.c A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c 21 files changed, 797 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 15 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Attention is currently required from: Patrick Georgi, Angel Pons, Evgeny Zinoviev. xin hua wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 16: (1 comment) File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/comment/b56f809e_25dcf135 PS8, Line 105: device pci 1a.7 on
Doesn't it show up in lspci? It looks like some USB controller device, but it's weird that it appear […] this is the find_debugport for ft232h logging but the port is not the ones on the side. does anyone have the schematics to see if there is test points that one can tap into to access this? thanks
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 16 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Patrick Georgi <patrick@coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Mon, 20 Dec 2021 14:28:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Gerrit-MessageType: comment
Attention is currently required from: Patrick Georgi, Angel Pons, Evgeny Zinoviev. xin hua wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 16: (1 comment) File src/mainboard/apple/macbookpro8_1/Kconfig: https://review.coreboot.org/c/coreboot/+/33151/comment/7fd65314_8aa3d9bc PS11, Line 28: config VGA_BIOS_FILE : string : default "pci8086,0126.rom" : : config VGA_BIOS_ID : string : default "8086,0126"
Did you test the VBIOS? where is the file?
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 16 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Patrick Georgi <patrick@coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Wed, 22 Dec 2021 08:34:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Attention is currently required from: Patrick Georgi, xin hua wang, Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 16: (1 comment) File src/mainboard/apple/macbookpro8_1/Kconfig: https://review.coreboot.org/c/coreboot/+/33151/comment/7a32e29b_9e416349 PS11, Line 28: config VGA_BIOS_FILE : string : default "pci8086,0126.rom" : : config VGA_BIOS_ID : string : default "8086,0126"
where is the file? Needs to be extracted from vendor firmware
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 16 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Patrick Georgi <patrick@coreboot.org> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Wed, 22 Dec 2021 09:42:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: xin hua wang <xinhuawang0101@gmail.com> Gerrit-MessageType: comment
Attention is currently required from: Patrick Georgi, xin hua wang, Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 16: Code-Review+1 (45 comments) File Documentation/mainboard/apple/macbookpro8_1.md: https://review.coreboot.org/c/coreboot/+/33151/comment/5b07654c_8f297c5f PS16, Line 16: 8MB nit: 8 MiB https://review.coreboot.org/c/coreboot/+/33151/comment/93e1fe5c_cb9ed17e PS16, Line 55: ## Untested I imagine macOS is untested? https://review.coreboot.org/c/coreboot/+/33151/comment/9881afd0_74553a57 PS16, Line 57: Thunderbolt Probably has issues because the thunderbolt controller needs some initialisation File src/mainboard/apple/macbookpro8_1/Kconfig: https://review.coreboot.org/c/coreboot/+/33151/comment/e688d9ec_ff58649f PS16, Line 16: select GFX_GMA_INTERNAL_IS_LVDS Please drop https://review.coreboot.org/c/coreboot/+/33151/comment/e473d954_b4df4400 PS16, Line 21: string Remove the type as per CB:56553 https://review.coreboot.org/c/coreboot/+/33151/comment/c99d8b0a_2669b5aa PS16, Line 22: apple/macbookpro8_1 This now needs to be surrounded in double quotes https://review.coreboot.org/c/coreboot/+/33151/comment/ee6fd475_8198b612 PS16, Line 25: string Remove the type as per CB:56554 https://review.coreboot.org/c/coreboot/+/33151/comment/556de4d9_46020b36 PS16, Line 38: default 28 Um, gpio.c configures this as an input. https://review.coreboot.org/c/coreboot/+/33151/comment/76421bfd_bac7c85b PS16, Line 40: config MAX_CPUS : int : default 8 Remove as per CB:41839 File src/mainboard/apple/macbookpro8_1/acpi/ec.asl: https://review.coreboot.org/c/coreboot/+/33151/comment/e036c12c_608632ae PS16, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (c) 2019-2020 Evgeny Zinoviev <me@ch1p.io> : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Please use SPDX license headers File src/mainboard/apple/macbookpro8_1/acpi/platform.asl: https://review.coreboot.org/c/coreboot/+/33151/comment/ebccee3c_34d376b8 PS16, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Please use SPDX license headers File src/mainboard/apple/macbookpro8_1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/33151/comment/dc625150_b96a5c18 PS8, Line 31: //
Make this comment a C-style comment, so that it is consistent with the other comments Done
File src/mainboard/apple/macbookpro8_1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/33151/comment/75f28bcf_547ec264 PS16, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2014 Vladimir Serbinenko : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Please use SPDX license headers https://review.coreboot.org/c/coreboot/+/33151/comment/aa8ef648_15047b1b PS16, Line 18: #include <southbridge/intel/bd82x6x/nvs.h> Needs update https://review.coreboot.org/c/coreboot/+/33151/comment/7aba4edc_30ecf804 PS16, Line 20: global_nvs_t Needs update https://review.coreboot.org/c/coreboot/+/33151/comment/3089f177_5e597011 PS16, Line 25: gnvs->tcrt = 100; : gnvs->tpsv = 90; I don't think these are needed. File src/mainboard/apple/macbookpro8_1/cmos.default: https://review.coreboot.org/c/coreboot/+/33151/comment/e8e11389_9c8b92cc PS16, Line 3: Enable `Disable` would make more sense File src/mainboard/apple/macbookpro8_1/cmos.layout: PS16: Please indent with tabs. https://review.coreboot.org/c/coreboot/+/33151/comment/0a332e65_fbb438cc PS16, Line 1: ## : ## This file is part of the coreboot project. : ## : ## This program is free software; you can redistribute it and/or modify : ## it under the terms of the GNU General Public License as published by : ## the Free Software Foundation; version 2 of the License. : ## : ## This program is distributed in the hope that it will be useful, : ## but WITHOUT ANY WARRANTY; without even the implied warranty of : ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : ## GNU General Public License for more details. : ## Please use SPDX license headers https://review.coreboot.org/c/coreboot/+/33151/comment/ee37bb44_c5b09498 PS16, Line 17: # ----------------------------------------------------------------- : # Status Register A : # ----------------------------------------------------------------- : # Status Register B : # ----------------------------------------------------------------- : # Status Register C : #96 4 r 0 status_c_rsvd : #100 1 r 0 uf_flag : #101 1 r 0 af_flag : #102 1 r 0 pf_flag : #103 1 r 0 irqf_flag : # ----------------------------------------------------------------- : # Status Register D : #104 7 r 0 status_d_rsvd : #111 1 r 0 valid_cmos_ram : # ----------------------------------------------------------------- : # Diagnostic Status Register : #112 8 r 0 diag_rsvd1 Please remove https://review.coreboot.org/c/coreboot/+/33151/comment/572d5be9_f0bf280b PS16, Line 38: #120 264 r 0 unused Please remove https://review.coreboot.org/c/coreboot/+/33151/comment/1228646e_1ee0e7ef PS16, Line 44: #390 2 r 0 unused? Please remove https://review.coreboot.org/c/coreboot/+/33151/comment/5899c08f_c5e00fff PS16, Line 46: # ----------------------------------------------------------------- Where are the CMOS options for `gfx_uma_size`, among other things? https://review.coreboot.org/c/coreboot/+/33151/comment/6eadc33f_4e370443 PS16, Line 48: #392 3 r 0 unused Please remove https://review.coreboot.org/c/coreboot/+/33151/comment/4decbf24_a3c5acf9 PS16, Line 50: #399 1 r 0 unused Please remove https://review.coreboot.org/c/coreboot/+/33151/comment/289da6af_93777109 PS16, Line 58: # SandyBridge MRC Scrambler Seed values : 896 32 r 0 mrc_scrambler_seed : 928 32 r 0 mrc_scrambler_seed_s3 : 960 16 r 0 mrc_scrambler_seed_chk Only used with MRC.bin File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/comment/e568732d_f01c3ba1 PS8, Line 105: device pci 1a.7 on Device gone.
this is the find_debugport for ft232h logging but the port is not the ones on the side. does anyone have the schematics to see if there is test points that one can tap into to access this? thanks
Please don't derail comment threads. You could've asked your question in a new comment thread. File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/comment/58dea001_b9a64099 PS16, Line 8: 0 PANEL_PORT_LVDS https://review.coreboot.org/c/coreboot/+/33151/comment/02dec7c9_9a41b200 PS16, Line 18: register "c1_acpower" = "1" : register "c1_battery" = "1" : register "c2_acpower" = "3" : register "c2_battery" = "3" : register "c3_acpower" = "5" : register "c3_battery" = "5" Needs to be updated: register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" https://review.coreboot.org/c/coreboot/+/33151/comment/3defb3c2_d47deda5 PS16, Line 32: subsystemid 0x8086 0x7270 inherit I think you can move this inside the southbridge chip, put `subsystemid 0x106b 0x00db inherit` here and drop all `subsystemid 0x106b 0x00db` lines. https://review.coreboot.org/c/coreboot/+/33151/comment/c4f0836e_c378449e PS16, Line 36: device pci 01.0 on : subsystemid 0x106b 0x00db : end Is there anything connected here? Or is this only on so that the thunderbolt root port function is discoverable? (multifunction PCI devices must implement function 0). https://review.coreboot.org/c/coreboot/+/33151/comment/597acf1b_f3b9b591 PS16, Line 46: register "c2_latency" = "0x0065" Remove as per CB:55212 https://review.coreboot.org/c/coreboot/+/33151/comment/a150e0f0_38ac36eb PS16, Line 52: register "pcie_port_coalesce" = "1" Doesn't seem to be needed https://review.coreboot.org/c/coreboot/+/33151/comment/146a4844_538f254f PS16, Line 74: device pci 1f.0 on end # LPC bridge No EC chip? File src/mainboard/apple/macbookpro8_1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/33151/comment/966417d4_0248d253 PS16, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Please use SPDX license headers https://review.coreboot.org/c/coreboot/+/33151/comment/14d7b006_fe3f8060 PS16, Line 18: 0x02, // DSDT revision: ACPI 2.0 and up ACPI_DSDT_REV_2, https://review.coreboot.org/c/coreboot/+/33151/comment/40e4ea15_3915fa16 PS16, Line 21: // OEM revision autoport nonsense, please remove File src/mainboard/apple/macbookpro8_1/early_init.c: https://review.coreboot.org/c/coreboot/+/33151/comment/115244dc_ce0f2a48 PS16, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2014 Vladimir Serbinenko : * Copyright (C) 2019-2020 Evgeny Zinoviev <me@ch1p.io> : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Please use SPDX license headers https://review.coreboot.org/c/coreboot/+/33151/comment/9568893d_56e1d5c1 PS16, Line 39: void mainboard_early_init(int s3resume) : { : } Can be removed File src/mainboard/apple/macbookpro8_1/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/33151/comment/65769f1b_de98e115 PS16, Line 1: -- : -- This file is part of the coreboot project. : -- : -- This program is free software; you can redistribute it and/or modify : -- it under the terms of the GNU General Public License as published by : -- the Free Software Foundation; either version 2 of the License, or : -- (at your option) any later version. : -- : -- This program is distributed in the hope that it will be useful, : -- but WITHOUT ANY WARRANTY; without even the implied warranty of : -- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : -- GNU General Public License for more details. : -- Please use SPDX license headers https://review.coreboot.org/c/coreboot/+/33151/comment/90feb8cf_3e3cb036 PS16, Line 31: Internal LVDS File src/mainboard/apple/macbookpro8_1/gpio.c: https://review.coreboot.org/c/coreboot/+/33151/comment/b2a30f61_4cdd3837 PS16, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2014 Vladimir Serbinenko : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Please use SPDX license headers File src/mainboard/apple/macbookpro8_1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/33151/comment/c7327606_76cc9ba5 PS8, Line 21: Cirrus
Yes. Please expand the comment, thanks
File src/mainboard/apple/macbookpro8_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/33151/comment/3dbf569f_73d9416f PS8, Line 24: RCBA32(0x38c8) = 0x00002005;
What does this do? Is gone
File src/mainboard/apple/macbookpro8_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/33151/comment/26012212_f5e7ce57 PS16, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2019 Evgeny Zinoviev <me@ch1p.io> : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Please use SPDX license headers -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 16 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Patrick Georgi <patrick@coreboot.org> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Wed, 22 Dec 2021 10:01:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: xin hua wang <xinhuawang0101@gmail.com> Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Gerrit-MessageType: comment
Attention is currently required from: xin hua wang, Evgeny Zinoviev. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 16: (1 comment) Patchset: PS16: I've emailed Evgeny about taking over this patch, and he says he doesn't have time to work on it and I'm welcome to work on it as well as the other unmerged MacBook ports. I don't have any of these systems so I'd be relying on other people for testing. After some changes, most of which were already caught by unresolved comments, it compiles and boots (tested by a user on IRC) after being rebased onto master. I'll upload an updated patchset shortly. -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 16 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Sun, 17 Apr 2022 16:54:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Attention is currently required from: xin hua wang, Evgeny Zinoviev. Nicholas Chin has uploaded a new patch set (#17) to the change originally created by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro8_1.md A Documentation/mainboard/apple/mbp81_chip.jpg A Documentation/mainboard/apple/mbp81_clip.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/early_init.c A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c 21 files changed, 622 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/17 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 17 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-MessageType: newpatchset
Attention is currently required from: xin hua wang, Nicholas Chin. Nicholas Chin has uploaded a new patch set (#18) to the change originally created by Evgeny Zinoviev. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro8_1.md A Documentation/mainboard/apple/mbp81_chip.jpg A Documentation/mainboard/apple/mbp81_clip.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/early_init.c A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c 21 files changed, 621 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/18 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 18 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, xin hua wang, Evgeny Zinoviev. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 18: (35 comments) Patchset: PS18: Rebased and fixed build issues and boot issues, and addressed some comments. File Documentation/mainboard/apple/macbookpro8_1.md: https://review.coreboot.org/c/coreboot/+/33151/comment/99f404d2_b0f73493 PS16, Line 16: 8MB
nit: 8 MiB Done
File src/mainboard/apple/macbookpro8_1/Kconfig: https://review.coreboot.org/c/coreboot/+/33151/comment/aeedb28c_626a9786 PS16, Line 16: select GFX_GMA_INTERNAL_IS_LVDS
Please drop Done
https://review.coreboot.org/c/coreboot/+/33151/comment/18826804_bec1f105 PS16, Line 21: string
Remove the type as per CB:56553 Done
https://review.coreboot.org/c/coreboot/+/33151/comment/2e188af6_ad84564e PS16, Line 22: apple/macbookpro8_1
This now needs to be surrounded in double quotes Done
https://review.coreboot.org/c/coreboot/+/33151/comment/08b8395a_332e76e8 PS16, Line 25: string
Remove the type as per CB:56554 Done
https://review.coreboot.org/c/coreboot/+/33151/comment/d05f799d_7354c630 PS16, Line 40: config MAX_CPUS : int : default 8
Remove as per CB:41839 Done
File src/mainboard/apple/macbookpro8_1/acpi/ec.asl: https://review.coreboot.org/c/coreboot/+/33151/comment/e1f71252_600f157a PS16, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (c) 2019-2020 Evgeny Zinoviev <me@ch1p.io> : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Please use SPDX license headers Done
File src/mainboard/apple/macbookpro8_1/acpi/platform.asl: https://review.coreboot.org/c/coreboot/+/33151/comment/2f25b6f2_f444b4ee PS16, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Please use SPDX license headers Done
File src/mainboard/apple/macbookpro8_1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/33151/comment/d0f058e0_4d21a5af PS16, Line 18: #include <southbridge/intel/bd82x6x/nvs.h>
Needs update Done
https://review.coreboot.org/c/coreboot/+/33151/comment/d4a125b3_35afdc24 PS16, Line 20: global_nvs_t
Needs update Done
File src/mainboard/apple/macbookpro8_1/cmos.default: https://review.coreboot.org/c/coreboot/+/33151/comment/af8ca20a_af65e819 PS16, Line 3: Enable
`Disable` would make more sense Done
File src/mainboard/apple/macbookpro8_1/cmos.layout: PS16:
Please indent with tabs. Done
https://review.coreboot.org/c/coreboot/+/33151/comment/836212ee_ffa0d443 PS16, Line 1: ## : ## This file is part of the coreboot project. : ## : ## This program is free software; you can redistribute it and/or modify : ## it under the terms of the GNU General Public License as published by : ## the Free Software Foundation; version 2 of the License. : ## : ## This program is distributed in the hope that it will be useful, : ## but WITHOUT ANY WARRANTY; without even the implied warranty of : ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : ## GNU General Public License for more details. : ##
Please use SPDX license headers Done
https://review.coreboot.org/c/coreboot/+/33151/comment/9f973963_52eaafa0 PS16, Line 17: # ----------------------------------------------------------------- : # Status Register A : # ----------------------------------------------------------------- : # Status Register B : # ----------------------------------------------------------------- : # Status Register C : #96 4 r 0 status_c_rsvd : #100 1 r 0 uf_flag : #101 1 r 0 af_flag : #102 1 r 0 pf_flag : #103 1 r 0 irqf_flag : # ----------------------------------------------------------------- : # Status Register D : #104 7 r 0 status_d_rsvd : #111 1 r 0 valid_cmos_ram : # ----------------------------------------------------------------- : # Diagnostic Status Register : #112 8 r 0 diag_rsvd1
Please remove Done
https://review.coreboot.org/c/coreboot/+/33151/comment/f348df98_781b985e PS16, Line 38: #120 264 r 0 unused
Please remove Done
https://review.coreboot.org/c/coreboot/+/33151/comment/8f43881d_19372fd2 PS16, Line 44: #390 2 r 0 unused?
Please remove Done
https://review.coreboot.org/c/coreboot/+/33151/comment/e6c75c67_16295a28 PS16, Line 48: #392 3 r 0 unused
Please remove Done
https://review.coreboot.org/c/coreboot/+/33151/comment/ceef2756_398124a7 PS16, Line 50: #399 1 r 0 unused
Please remove Done
https://review.coreboot.org/c/coreboot/+/33151/comment/bd5ccd1f_21427fd6 PS16, Line 58: # SandyBridge MRC Scrambler Seed values : 896 32 r 0 mrc_scrambler_seed : 928 32 r 0 mrc_scrambler_seed_s3 : 960 16 r 0 mrc_scrambler_seed_chk
Only used with MRC. […] Done
File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/comment/484bf661_7127886e PS16, Line 8: 0
PANEL_PORT_LVDS Done
https://review.coreboot.org/c/coreboot/+/33151/comment/62075d2d_2f9c3b14 PS16, Line 18: register "c1_acpower" = "1" : register "c1_battery" = "1" : register "c2_acpower" = "3" : register "c2_battery" = "3" : register "c3_acpower" = "5" : register "c3_battery" = "5"
Needs to be updated: […] Done
https://review.coreboot.org/c/coreboot/+/33151/comment/72e10e40_72b635e0 PS16, Line 32: subsystemid 0x8086 0x7270 inherit
I think you can move this inside the southbridge chip, put `subsystemid 0x106b 0x00db inherit` here […] I tried that, putting `subsystemid 0x8086 0x7270 inherit` inside the `chip southbrige` section, but the build system complains about that being a syntax error. If that line was moved right before the chip section, would it override the `subsystem 0x106b 0x00db inherit` line that you suggested and work as intended?
https://review.coreboot.org/c/coreboot/+/33151/comment/95731414_cca96691 PS16, Line 46: register "c2_latency" = "0x0065"
Remove as per CB:55212 Done
File src/mainboard/apple/macbookpro8_1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/33151/comment/e67c9113_daff46b1 PS16, Line 1: /* : * This file is part of the coreboot project. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Please use SPDX license headers Done
https://review.coreboot.org/c/coreboot/+/33151/comment/951704ff_da7e9255 PS16, Line 18: 0x02, // DSDT revision: ACPI 2.0 and up
ACPI_DSDT_REV_2, Done
https://review.coreboot.org/c/coreboot/+/33151/comment/c6f21652_1f2f68a9 PS16, Line 21: // OEM revision
autoport nonsense, please remove Done
File src/mainboard/apple/macbookpro8_1/early_init.c: https://review.coreboot.org/c/coreboot/+/33151/comment/150abe05_ba1fbafc PS16, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2014 Vladimir Serbinenko : * Copyright (C) 2019-2020 Evgeny Zinoviev <me@ch1p.io> : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Please use SPDX license headers Done
https://review.coreboot.org/c/coreboot/+/33151/comment/18eec6f0_9646d17c PS16, Line 39: void mainboard_early_init(int s3resume) : { : }
Can be removed Done
File src/mainboard/apple/macbookpro8_1/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/33151/comment/f35e4277_1889e628 PS11, Line 30: Analog
You only need to keep Internal and the DP/HDMI groups, as per schematics. Done
File src/mainboard/apple/macbookpro8_1/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/33151/comment/4f646aff_13ee9d22 PS16, Line 1: -- : -- This file is part of the coreboot project. : -- : -- This program is free software; you can redistribute it and/or modify : -- it under the terms of the GNU General Public License as published by : -- the Free Software Foundation; either version 2 of the License, or : -- (at your option) any later version. : -- : -- This program is distributed in the hope that it will be useful, : -- but WITHOUT ANY WARRANTY; without even the implied warranty of : -- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : -- GNU General Public License for more details. : --
Please use SPDX license headers Done
https://review.coreboot.org/c/coreboot/+/33151/comment/fd0df1a9_705ec149 PS16, Line 31: Internal
LVDS Done
File src/mainboard/apple/macbookpro8_1/gpio.c: https://review.coreboot.org/c/coreboot/+/33151/comment/e6f043bf_a6a9124e PS16, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2014 Vladimir Serbinenko : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Please use SPDX license headers Done
File src/mainboard/apple/macbookpro8_1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/33151/comment/e3e2805d_cc639973 PS8, Line 21: Cirrus
Please expand the comment, thanks Done
File src/mainboard/apple/macbookpro8_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/33151/comment/4d046827_c34bb0af PS16, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2019 Evgeny Zinoviev <me@ch1p.io> : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Please use SPDX license headers Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 18 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Sun, 17 Apr 2022 17:33:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, xin hua wang, Evgeny Zinoviev. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 18: (1 comment) File src/mainboard/apple/macbookpro8_1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/33151/comment/d331b76a_92746fb2 PS16, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2014 Vladimir Serbinenko : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Please use SPDX license headers Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 18 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Sun, 17 Apr 2022 17:35:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Attention is currently required from: xin hua wang, Nicholas Chin, Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 18: (2 comments) File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/comment/9bc7c615_8ea5705c PS16, Line 32: subsystemid 0x8086 0x7270 inherit
I tried that, putting `subsystemid 0x8086 0x7270 inherit` inside the `chip southbrige` section, but […] Ah, it only applies to devices. I don't think it's too much of an issue, then.
File src/mainboard/apple/macbookpro8_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/33151/comment/35abad4d_45e9fb1f PS11, Line 32: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, : GMA_INT15_PANEL_FIT_DEFAULT, : GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
Does this work? If this port hasn't been tested with an Intel VGA BIOS and without SeaBIOS, I'd drop the entire file.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 18 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Mon, 18 Apr 2022 00:04:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, xin hua wang, Nicholas Chin. Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 18: (2 comments) Patchset: PS16:
I've emailed Evgeny about taking over this patch, and he says he doesn't have time to work on it and […] I still have all of these systems and can do occasional testing, so don't hesitate to ping me if you need to test something. (But not at the moment, as they are ~2000 km away from me and we have a war situation that complicates everything).
File src/mainboard/apple/macbookpro8_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/33151/comment/b3e1a087_d312dd3d PS11, Line 32: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, : GMA_INT15_PANEL_FIT_DEFAULT, : GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
If this port hasn't been tested with an Intel VGA BIOS and without SeaBIOS, I'd drop the entire file […] This particular wasn't, but I tested VGA BIOS on MBP 10,1 and MBA 5,2.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 18 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-Comment-Date: Mon, 18 Apr 2022 21:48:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, xin hua wang, Nicholas Chin. Hello build bot (Jenkins), Martin L Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#19). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro8_1.md A Documentation/mainboard/apple/mbp81_chip.jpg A Documentation/mainboard/apple/mbp81_clip.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/early_init.c A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c 21 files changed, 645 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/19 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 19 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, xin hua wang, Evgeny Zinoviev, Nicholas Chin. Hello build bot (Jenkins), Martin L Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#20). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro8_1.md A Documentation/mainboard/apple/mbp81_chip.jpg A Documentation/mainboard/apple/mbp81_clip.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/early_init.c A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c M src/mainboard/lenovo/t520/acpi/superio.asl 22 files changed, 646 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/20 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 20 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, xin hua wang, Evgeny Zinoviev, Alexander Couzens, Nicholas Chin. Hello build bot (Jenkins), Martin L Roth, Angel Pons, Alexander Couzens, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#21). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro8_1.md A Documentation/mainboard/apple/mbp81_chip.jpg A Documentation/mainboard/apple/mbp81_clip.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/early_init.c A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c M src/mainboard/lenovo/t520/acpi/superio.asl 22 files changed, 647 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/21 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 21 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis@fe80.eu> Gerrit-Attention: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, xin hua wang, Evgeny Zinoviev, Alexander Couzens, Nicholas Chin. Hello build bot (Jenkins), Martin L Roth, Angel Pons, Alexander Couzens, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#22). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro8_1.md A Documentation/mainboard/apple/mbp81_chip.jpg A Documentation/mainboard/apple/mbp81_clip.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/early_init.c A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c A src/mainboard/apple/macbookpro8_1/mainboard.c 21 files changed, 646 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/22 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 22 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis@fe80.eu> Gerrit-Attention: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, xin hua wang, Evgeny Zinoviev, Alexander Couzens. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 22: (1 comment) File src/mainboard/apple/macbookpro8_1/acpi/superio.asl: https://review.coreboot.org/c/coreboot/+/33151/comment/69035e4c_516ccb94 PS22, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */ As per commit cf4722d317 (src/mb: Update unlicensable files with the CC-PDDC SPDX ID) empty files should be licensed under CC-PDDC -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 22 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis@fe80.eu> Gerrit-Comment-Date: Sun, 26 Feb 2023 23:59:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, xin hua wang, Evgeny Zinoviev, Alexander Couzens. Hello build bot (Jenkins), Martin L Roth, Angel Pons, Alexander Couzens, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#23). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15, Linux 5.10 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro8_1.md A Documentation/mainboard/apple/mbp81_chip.jpg A Documentation/mainboard/apple/mbp81_clip.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/early_init.c A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c 20 files changed, 621 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/23 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 23 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis@fe80.eu> Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, xin hua wang, Nicholas Chin, Alexander Couzens. Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 23: (6 comments) File src/mainboard/apple/macbookpro8_1/Kconfig: https://review.coreboot.org/c/coreboot/+/33151/comment/92827223_4e5c7922 PS11, Line 28: config VGA_BIOS_FILE : string : default "pci8086,0126.rom" : : config VGA_BIOS_ID : string : default "8086,0126"
Needs to be extracted from vendor firmware Let's just drop it.
File src/mainboard/apple/macbookpro8_1/Kconfig: https://review.coreboot.org/c/coreboot/+/33151/comment/f96e2c49_964dee87 PS16, Line 38: default 28
Um, gpio.c configures this as an input. Yes, I'm confused here, can you look at schematics please?
File src/mainboard/apple/macbookpro8_1/acpi/superio.asl: https://review.coreboot.org/c/coreboot/+/33151/comment/b6709658_53d4c479 PS22, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */
As per commit cf4722d317 (src/mb: Update unlicensable files with the CC-PDDC SPDX ID) empty files sh […] Thanks
File src/mainboard/apple/macbookpro8_1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/33151/comment/3167e805_a203b7d7 PS16, Line 25: gnvs->tcrt = 100; : gnvs->tpsv = 90;
I don't think these are needed. Done
File src/mainboard/apple/macbookpro8_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/33151/comment/a4280c2d_65188843 PS16, Line 52: register "pcie_port_coalesce" = "1"
Doesn't seem to be needed Done
File src/mainboard/apple/macbookpro8_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/33151/comment/6b64757a_e1590bf5 PS11, Line 32: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, : GMA_INT15_PANEL_FIT_DEFAULT, : GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
This particular wasn't, but I tested VGA BIOS on MBP 10,1 and MBA 5,2. Let's just drop it.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 23 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-Attention: Alexander Couzens <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 27 Feb 2023 00:57:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: xin hua wang <xinhuawang0101@gmail.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14@gmail.com> Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, xin hua wang, Nicholas Chin, Alexander Couzens. Hello build bot (Jenkins), Martin L Roth, Angel Pons, Alexander Couzens, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/33151 to look at the new patch set (#24). Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... mb/apple: Add MacBook Pro 8,1 support MacBook Pro 13'' Early 2011 A1278 (820-2936). Tested and works: - Both DIMMs - libgfxinit - SeaBIOS, GRUB - Linux 4.15, Linux 5.10 - Wi-Fi - Bluetooth - ACPI-related stuff (lid, battery, AC) - S3 suspend and resume - Keyboard and touchpad - USB 2.0 ports - SD card reader - Speakers and headphones - Mic - Camera - CD-ROM - Ethernet Not tested: - Thunderbolt - FireWire Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- A Documentation/mainboard/apple/macbookpro8_1.md A Documentation/mainboard/apple/mbp81_chip.jpg A Documentation/mainboard/apple/mbp81_clip.jpg M Documentation/mainboard/index.md A src/mainboard/apple/macbookpro8_1/Kconfig A src/mainboard/apple/macbookpro8_1/Kconfig.name A src/mainboard/apple/macbookpro8_1/Makefile.inc A src/mainboard/apple/macbookpro8_1/acpi/ec.asl A src/mainboard/apple/macbookpro8_1/acpi/platform.asl A src/mainboard/apple/macbookpro8_1/acpi/superio.asl A src/mainboard/apple/macbookpro8_1/acpi_tables.c A src/mainboard/apple/macbookpro8_1/board_info.txt A src/mainboard/apple/macbookpro8_1/cmos.default A src/mainboard/apple/macbookpro8_1/cmos.layout A src/mainboard/apple/macbookpro8_1/devicetree.cb A src/mainboard/apple/macbookpro8_1/dsdt.asl A src/mainboard/apple/macbookpro8_1/early_init.c A src/mainboard/apple/macbookpro8_1/gma-mainboard.ads A src/mainboard/apple/macbookpro8_1/gpio.c A src/mainboard/apple/macbookpro8_1/hda_verb.c 20 files changed, 621 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/33151/24 -- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 24 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-Attention: Alexander Couzens <lynxis@fe80.eu> Gerrit-MessageType: newpatchset
participants (5)
-
Angel Pons (Code Review) -
build bot (Jenkins) (Code Review)
-
Evgeny Zinoviev (Code Review)
-
Nicholas Chin (Code Review)
-
xin hua wang (Code Review)