Change in ...coreboot[master]: Documentation: Allow passing arguments into make livesphinx
Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31128 Change subject: Documentation: Allow passing arguments into make livesphinx ...................................................................... Documentation: Allow passing arguments into make livesphinx It's what the doc.coreboot.org docker container is running and when using its livehtml feature, it listens at localhost, which isn't always desirable. With `docker run -e SPHINXOPTS="-H $localip" ...` it now listens at localip, which is more flexible. Change-Id: Ia0614e57458c32169f6d614783366025e9c814b3 Signed-off-by: Patrick Georgi <pgeorgi@google.com> --- M Documentation/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/31128/1 diff --git a/Documentation/Makefile b/Documentation/Makefile index ed08936..b4fe8df 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -52,4 +52,4 @@ rm -f corebootPortingGuide.pdf livesphinx: - $(MAKE) -f Makefile.sphinx livehtml + $(MAKE) -f Makefile.sphinx livehtml SPHINXOPTS="$(SPHINXOPTS)" -- To view, visit https://review.coreboot.org/c/coreboot/+/31128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0614e57458c32169f6d614783366025e9c814b3 Gerrit-Change-Number: 31128 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> Gerrit-MessageType: newchange
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31128 ) Change subject: Documentation: Allow passing arguments into make livesphinx ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/31128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0614e57458c32169f6d614783366025e9c814b3 Gerrit-Change-Number: 31128 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 31 Jan 2019 13:45:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31128 ) Change subject: Documentation: Allow passing arguments into make livesphinx ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/31128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0614e57458c32169f6d614783366025e9c814b3 Gerrit-Change-Number: 31128 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 05 Feb 2019 21:14:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31128 ) Change subject: Documentation: Allow passing arguments into make livesphinx ...................................................................... Documentation: Allow passing arguments into make livesphinx It's what the doc.coreboot.org docker container is running and when using its livehtml feature, it listens at localhost, which isn't always desirable. With `docker run -e SPHINXOPTS="-H $localip" ...` it now listens at localip, which is more flexible. Change-Id: Ia0614e57458c32169f6d614783366025e9c814b3 Signed-off-by: Patrick Georgi <pgeorgi@google.com> Reviewed-on: https://review.coreboot.org/c/31128 Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> --- M Documentation/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved diff --git a/Documentation/Makefile b/Documentation/Makefile index ed08936..b4fe8df 100644 --- a/Documentation/Makefile +++ b/Documentation/Makefile @@ -52,4 +52,4 @@ rm -f corebootPortingGuide.pdf livesphinx: - $(MAKE) -f Makefile.sphinx livehtml + $(MAKE) -f Makefile.sphinx livehtml SPHINXOPTS="$(SPHINXOPTS)" -- To view, visit https://review.coreboot.org/c/coreboot/+/31128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0614e57458c32169f6d614783366025e9c814b3 Gerrit-Change-Number: 31128 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: merged
participants (3)
-
Arthur Heymans (Code Review) -
Patrick Georgi (Code Review) -
Paul Menzel (Code Review)