Attention is currently required from: Raul Rangel, Martin Roth, Eric Peers, Karthik Ramasubramanian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55148 ) Change subject: mb/google/guybrush/var/guybrush: Update GPIO configuration ...................................................................... Patch Set 3: (3 comments) File src/mainboard/google/guybrush/variants/baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/55148/comment/bd8781bb_09f7cc40 PS3, Line 84: GPIO_70

Should we do PAD_NC(GPIO_70)? +1

https://review.coreboot.org/c/coreboot/+/55148/comment/97565739_b1700288 PS3, Line 86: GPIO_74 PAD_NC(GPIO_74) File src/mainboard/google/guybrush/variants/guybrush/gpio.c: https://review.coreboot.org/c/coreboot/+/55148/comment/1a8c7032_a4572045 PS1, Line 14: HIGH

There is some history involved. Initially EN_SPKR was tied to a 3. […] Aah I see.. Thanks for the explanation Karthik. Since the default for board id 1 changed here, I was curious about the impact.

-- To view, visit https://review.coreboot.org/c/coreboot/+/55148 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I31523b3e03d2b59577f33eae548747834cfc98aa Gerrit-Change-Number: 55148 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Reviewer: Eric Peers <epeers@google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Raul Rangel <rrangel@chromium.org> Gerrit-Attention: Martin Roth <martinroth@google.com> Gerrit-Attention: Eric Peers <epeers@google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Comment-Date: Thu, 03 Jun 2021 21:48:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel@chromium.org> Comment-In-Reply-To: Furquan Shaikh <furquan@google.com> Comment-In-Reply-To: Eric Peers <epeers@google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub@google.com> Gerrit-MessageType: comment