Change in ...coreboot[master]: qcs405: Update bootblock size
Nitheesh Sekar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33159 Change subject: qcs405: Update bootblock size ...................................................................... qcs405: Update bootblock size Increase the size of bootblock from 96K to 128K. Change-Id: Ifc6e7239ed2978a8490fa229945ebd5ed9182298 Signed-off-by: Nitheesh Sekar <nsekar@codeaurora.org> --- M src/mainboard/google/mistral/chromeos.fmd 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/33159/1 diff --git a/src/mainboard/google/mistral/chromeos.fmd b/src/mainboard/google/mistral/chromeos.fmd index 76cdd50..4d5f666 100644 --- a/src/mainboard/google/mistral/chromeos.fmd +++ b/src/mainboard/google/mistral/chromeos.fmd @@ -16,7 +16,7 @@ FLASH@0x0 8M { WP_RO 4M { RO_SECTION 0x204000 { - BOOTBLOCK 96K + BOOTBLOCK 128K COREBOOT(CBFS) FMAP@0x200000 0x1000 GBB 0x2f00 -- To view, visit https://review.coreboot.org/c/coreboot/+/33159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc6e7239ed2978a8490fa229945ebd5ed9182298 Gerrit-Change-Number: 33159 Gerrit-PatchSet: 1 Gerrit-Owner: Nitheesh Sekar <nsekar@codeaurora.org> Gerrit-MessageType: newchange
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33159 ) Change subject: qcs405: Update bootblock size ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/33159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc6e7239ed2978a8490fa229945ebd5ed9182298 Gerrit-Change-Number: 33159 Gerrit-PatchSet: 2 Gerrit-Owner: Nitheesh Sekar <nsekar@codeaurora.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 06 Jun 2019 11:29:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33159 ) Change subject: qcs405: Update bootblock size ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/33159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc6e7239ed2978a8490fa229945ebd5ed9182298 Gerrit-Change-Number: 33159 Gerrit-PatchSet: 2 Gerrit-Owner: Nitheesh Sekar <nsekar@codeaurora.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 06 Jun 2019 17:42:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33159 ) Change subject: qcs405: Update bootblock size ...................................................................... Patch Set 3: -Code-Review The change on its own looks good, but I'm worried about the impact on updates since that changes the fmap layout. Do we really need this additional space? what for? -- To view, visit https://review.coreboot.org/c/coreboot/+/33159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc6e7239ed2978a8490fa229945ebd5ed9182298 Gerrit-Change-Number: 33159 Gerrit-PatchSet: 3 Gerrit-Owner: Nitheesh Sekar <nsekar@codeaurora.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 12 Jun 2019 14:42:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Nitheesh Sekar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33159 ) Change subject: qcs405: Update bootblock size ...................................................................... Patch Set 3:
Patch Set 3: -Code-Review
The change on its own looks good, but I'm worried about the impact on updates since that changes the fmap layout. Do we really need this additional space? what for?
The size of qc_sec.mbn has increased with recent changes. Since qc_sec is merged with bootblock, this additional space is needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/33159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc6e7239ed2978a8490fa229945ebd5ed9182298 Gerrit-Change-Number: 33159 Gerrit-PatchSet: 3 Gerrit-Owner: Nitheesh Sekar <nsekar@codeaurora.org> Gerrit-Reviewer: Nitheesh Sekar <nsekar@codeaurora.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 17 Jun 2019 07:09:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33159 ) Change subject: qcs405: Update bootblock size ...................................................................... Patch Set 3: Code-Review+2 Checking further, it's safe: The FMAP remains at the same position, which is important. All it does is shuffling space between bootblock and CBFS on devices whose RO is updated (and where the FMAP is updated as well). -- To view, visit https://review.coreboot.org/c/coreboot/+/33159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc6e7239ed2978a8490fa229945ebd5ed9182298 Gerrit-Change-Number: 33159 Gerrit-PatchSet: 3 Gerrit-Owner: Nitheesh Sekar <nsekar@codeaurora.org> Gerrit-Reviewer: Nitheesh Sekar <nsekar@codeaurora.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 21 Jun 2019 08:48:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33159 ) Change subject: qcs405: Update bootblock size ...................................................................... qcs405: Update bootblock size Increase the size of bootblock from 96K to 128K. Change-Id: Ifc6e7239ed2978a8490fa229945ebd5ed9182298 Signed-off-by: Nitheesh Sekar <nsekar@codeaurora.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/33159 Reviewed-by: Patrick Georgi <pgeorgi@google.com> Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> --- M src/mainboard/google/mistral/chromeos.fmd 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Stefan Reinauer: Looks good to me, approved diff --git a/src/mainboard/google/mistral/chromeos.fmd b/src/mainboard/google/mistral/chromeos.fmd index 76cdd50..4d5f666 100644 --- a/src/mainboard/google/mistral/chromeos.fmd +++ b/src/mainboard/google/mistral/chromeos.fmd @@ -16,7 +16,7 @@ FLASH@0x0 8M { WP_RO 4M { RO_SECTION 0x204000 { - BOOTBLOCK 96K + BOOTBLOCK 128K COREBOOT(CBFS) FMAP@0x200000 0x1000 GBB 0x2f00 -- To view, visit https://review.coreboot.org/c/coreboot/+/33159 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc6e7239ed2978a8490fa229945ebd5ed9182298 Gerrit-Change-Number: 33159 Gerrit-PatchSet: 4 Gerrit-Owner: Nitheesh Sekar <nsekar@codeaurora.org> Gerrit-Reviewer: Nitheesh Sekar <nsekar@codeaurora.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: merged
participants (3)
-
Nitheesh Sekar (Code Review) -
Patrick Georgi (Code Review)
-
Stefan Reinauer (Code Review)