Attention is currently required from: Arthur Heymans, Nico Huber, Maulik V Vaghela, Tim Wawrzynczak, Sugnan Prabhu S, Subrata Banik, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59124 ) Change subject: soc/intel/common: Add CPU related APIs ...................................................................... Patch Set 8: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59124/comment/cafc87a7_2d81962b PS7, Line 13: cpu_get_cpu_typ

`cpu_get_cpu_type` Ack

File src/soc/intel/common/block/cpu/cpulib.c: https://review.coreboot.org/c/coreboot/+/59124/comment/b7cc56f8_6c23566e PS7, Line 34: #define CPUID_PROCESSOR_FREQUENCY 0x16 : : #define CPUID_HYBRID_INFORMATION 0x1a : : /* Structured Extended Feature Flags */ : #define CPUID_STRUCT_EXTENDED_FEATURE_FLAGS 0x7 : #define HYBRID_FEATURE BIT(15)

please use tabs for indentation, and also align the right sides Ack

https://review.coreboot.org/c/coreboot/+/59124/comment/5d8a7cf7_976303bf PS7, Line 199: cpu

CPU Ack

https://review.coreboot.org/c/coreboot/+/59124/comment/1e866eed_7141833e PS7, Line 199: cpu

CPU Ack

https://review.coreboot.org/c/coreboot/+/59124/comment/bdb021a5_ee99c2d7 PS7, Line 212:

nit: extra space Ack

https://review.coreboot.org/c/coreboot/+/59124/comment/8912bd27_5deb7b7a PS7, Line 220: core_type

What are the possible return values? 10h(Reserved), 20h(Atom), 30h(Reserved),40h(Core)

https://review.coreboot.org/c/coreboot/+/59124/comment/4b503e79_abfd864b PS7, Line 224: cpu_get_bus_frequency

What unit is this in? MHz? It is in MHz.

-- To view, visit https://review.coreboot.org/c/coreboot/+/59124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I680f43952ab4abce6e342206688ad32814970a91 Gerrit-Change-Number: 59124 Gerrit-PatchSet: 8 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla@intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s@intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans@9elements.com> Gerrit-CC: Michael Niewöhner <foss@mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla@intel.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur.heymans@9elements.com> Gerrit-Attention: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela@intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s@intel.com> Gerrit-Attention: Subrata Banik <subrata.banik@intel.com> Gerrit-Attention: Patrick Rudolph <siro@das-labor.org> Gerrit-Comment-Date: Fri, 03 Dec 2021 18:32:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-MessageType: comment