Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80237?usp=email ) Change subject: mb/google/guybrush: turn off SD ASPM L1.1/L1.2 ...................................................................... mb/google/guybrush: turn off SD ASPM L1.1/L1.2 Turn off SD ASPM L1.1/L1.2 as w/a for wlan DMA resume failure We completed 4 runs for each of the 2 tests - power_idle and power_VideoCall. Here are the averages for both the tests: L1ss disabled SD plugged power idle test: 735.3875 L1ss enabled SD plugged power idle test: 737.2335 L1ss disabled SD plugged power video test: 333.29325 L1ss enabled SD plugged power video test: 333.442 BUG=b:254382832 TEST=test pass over 10k cycles Signed-off-by: Jason Nien <finaljason@gmail.com> Change-Id: I4d903f0f6333ffa18069e42be3c932aeae8013d9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80237 Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> --- M src/mainboard/google/guybrush/port_descriptors.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Tim Van Patten: Looks good to me, approved Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/google/guybrush/port_descriptors.c b/src/mainboard/google/guybrush/port_descriptors.c index fc6ccb8..a056a19 100644 --- a/src/mainboard/google/guybrush/port_descriptors.c +++ b/src/mainboard/google/guybrush/port_descriptors.c @@ -33,8 +33,8 @@ .device_number = PCI_SLOT(SD_DEVFN), .function_number = PCI_FUNC(SD_DEVFN), .link_aspm = ASPM_L1, - .link_aspm_L1_1 = true, - .link_aspm_L1_2 = true, + .link_aspm_L1_1 = false, + .link_aspm_L1_2 = false, .turn_off_unused_lanes = true, .clk_req = CLK_REQ1, .gpio_group_id = GPIO_69, -- To view, visit https://review.coreboot.org/c/coreboot/+/80237?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4d903f0f6333ffa18069e42be3c932aeae8013d9 Gerrit-Change-Number: 80237 Gerrit-PatchSet: 8 Gerrit-Owner: Jason Nein <finaljason@gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Jason Nien <jason.nien@amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth@amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier@amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Reviewer: Tim Van Patten <timvp@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-MessageType: merged