Change in coreboot[master]: adding new mainboard (no official website as it is a noname board but...
Skoll RC has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: adding new mainboard (no official website as it is a noname board but easy to find) see https://github.com/skollrc/coreboot_noname_h61S1_port for more details ...................................................................... adding new mainboard (no official website as it is a noname board but easy to find) see https://github.com/skollrc/coreboot_noname_h61S1_port for more details Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 559 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/1 diff --git a/src/mainboard/ongy/Kconfig b/src/mainboard/ongy/Kconfig new file mode 100644 index 0000000..30ea9f3 --- /dev/null +++ b/src/mainboard/ongy/Kconfig @@ -0,0 +1,14 @@ +if VENDOR_ONGY +choice + prompt "Mainboard model" + +source "src/mainboard/ongy/*/Kconfig.name" + +endchoice + +source "src/mainboard/ongy/*/Kconfig" + +config MAINBOARD_VENDOR + default "H61M-S1" + +endif # VENDOR_ONGY diff --git a/src/mainboard/ongy/Kconfig.name b/src/mainboard/ongy/Kconfig.name new file mode 100644 index 0000000..d0e84b5 --- /dev/null +++ b/src/mainboard/ongy/Kconfig.name @@ -0,0 +1,2 @@ +config VENDOR_ONGY + bool "ongy" diff --git a/src/mainboard/ongy/h61m-s1/Kconfig b/src/mainboard/ongy/h61m-s1/Kconfig new file mode 100644 index 0000000..65bda16 --- /dev/null +++ b/src/mainboard/ongy/h61m-s1/Kconfig @@ -0,0 +1,56 @@ +## +## This file is part of the coreboot project. +## +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +if BOARD_H61M_S1 + +config BOARD_SPECIFIC_OPTIONS + def_bool y + select BOARD_ROMSIZE_KB_4096 + select HAVE_ACPI_RESUME + select HAVE_ACPI_TABLES + select INTEL_INT15 + select MAINBOARD_HAS_LIBGFXINIT + select NORTHBRIDGE_INTEL_SANDYBRIDGE + select SERIRQ_CONTINUOUS_MODE + select SOUTHBRIDGE_INTEL_BD82X6X + select USE_NATIVE_RAMINIT + +config MAINBOARD_DIR + string + default ongy/h61m-s1 + +config MAINBOARD_PART_NUMBER + string + default "h61m-s1" + +config VGA_BIOS_FILE + string + default "pci8086,0112.rom" + +config VGA_BIOS_ID + string + default "8086,0112" + +config DRAM_RESET_GATE_GPIO + int + default 60 + +config MAX_CPUS + int + default 8 + +config USBDEBUG_HCD_INDEX + int + default 2 +endif diff --git a/src/mainboard/ongy/h61m-s1/Kconfig.name b/src/mainboard/ongy/h61m-s1/Kconfig.name new file mode 100644 index 0000000..36eed8c --- /dev/null +++ b/src/mainboard/ongy/h61m-s1/Kconfig.name @@ -0,0 +1,2 @@ +config BOARD_H61M_S1 + bool "h61m-s1" diff --git a/src/mainboard/ongy/h61m-s1/Makefile.inc b/src/mainboard/ongy/h61m-s1/Makefile.inc new file mode 100644 index 0000000..18391d8 --- /dev/null +++ b/src/mainboard/ongy/h61m-s1/Makefile.inc @@ -0,0 +1,5 @@ +bootblock-y += early_init.c +bootblock-y += gpio.c +romstage-y += early_init.c +romstage-y += gpio.c +ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads diff --git a/src/mainboard/ongy/h61m-s1/acpi/ec.asl b/src/mainboard/ongy/h61m-s1/acpi/ec.asl new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/src/mainboard/ongy/h61m-s1/acpi/ec.asl diff --git a/src/mainboard/ongy/h61m-s1/acpi/platform.asl b/src/mainboard/ongy/h61m-s1/acpi/platform.asl new file mode 100644 index 0000000..ac9ff88 --- /dev/null +++ b/src/mainboard/ongy/h61m-s1/acpi/platform.asl @@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* This file is part of the coreboot project. */ +/* The _PTS method (Prepare To Sleep) is called before the OS is +* entering a sleep state. The sleep state number is passed in Arg0 +*/ + +Method(_PTS,1) +{ +} + +/*The _WAK method is called on system wakeup*/ + +Method(_WAK,1) +{ + Return(Package(){0,0}) +} diff --git a/src/mainboard/ongy/h61m-s1/acpi/superio.asl b/src/mainboard/ongy/h61m-s1/acpi/superio.asl new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/src/mainboard/ongy/h61m-s1/acpi/superio.asl diff --git a/src/mainboard/ongy/h61m-s1/acpi_tables.c b/src/mainboard/ongy/h61m-s1/acpi_tables.c new file mode 100644 index 0000000..3319c25 --- /dev/null +++ b/src/mainboard/ongy/h61m-s1/acpi_tables.c @@ -0,0 +1,22 @@ +/* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License as published by +* the Free Software Foundation; version 2 of the License. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +*/ + +#include <southbridge/intel/bd82x6x/nvs.h> + +void acpi_create_gnvs(global_nvs_t *gnvs) +{ + /* Disable USB ports in S3 by default */ + gnvs->s3u0 = 0; + gnvs->s3u1 = 0; + /* Disable USB ports in S5 by default */ + gnvs->s5u0 = 0; + gnvs->s5u1 = 0; +} diff --git a/src/mainboard/ongy/h61m-s1/board_info.txt b/src/mainboard/ongy/h61m-s1/board_info.txt new file mode 100644 index 0000000..0fc073c --- /dev/null +++ b/src/mainboard/ongy/h61m-s1/board_info.txt @@ -0,0 +1,6 @@ +Category: desktop +Board URL: none +ROM package: SOIC-8 +ROM protocol: SPI +ROM socketed: n +Flashrom support: y \ No newline at end of file diff --git a/src/mainboard/ongy/h61m-s1/devicetree.cb b/src/mainboard/ongy/h61m-s1/devicetree.cb new file mode 100644 index 0000000..38b740f --- /dev/null +++ b/src/mainboard/ongy/h61m-s1/devicetree.cb @@ -0,0 +1,95 @@ +## SPDX-License-Identifier: GPL-2.0-only +## This file is part of the coreboot project. + +chip northbridge/intel/sandybridge + register "gfx" = "GMA_STATIC_DISPLAYS(0)" + register "gpu_cpu_backlight" = "0x00000000" + register "gpu_dp_b_hotplug" = "4" + register "gpu_dp_c_hotplug" = "4" + register "gpu_dp_d_hotplug" = "4" + register "gpu_panel_port_select" = "0" + register "gpu_panel_power_backlight_off_delay" = "0" + register "gpu_panel_power_backlight_on_delay" = "0" + register "gpu_panel_power_cycle_delay" = "4" + register "gpu_panel_power_down_delay" = "0" + register "gpu_panel_power_up_delay" = "0" + register "gpu_pch_backlight" = "0x00000000" + device cpu_cluster 0x0 on + chip cpu/intel/model_206ax + register "c1_acpower" = "1" + register "c1_battery" = "1" + register "c2_acpower" = "3" + register "c2_battery" = "3" + register "c3_acpower" = "5" + register "c3_battery" = "5" + device lapic 0x0 on end + device lapic 0xacac off end + end + end + device domain 0x0 on + chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH + register "c2_latency" = "0x0065" + register "docking_supported" = "0" + register "gen1_dec" = "0x00fc0a01" + register "gen2_dec" = "0x00000000" + register "gen3_dec" = "0x00000000" + register "gen4_dec" = "0x00000000" + register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" + register "pcie_port_coalesce" = "1" + register "sata_interface_speed_support" = "0x3" + register "sata_port_map" = "0x33" + register "spi_lvscc" = "0x2005" + register "spi_uvscc" = "0x2005" + device pci 16.0 on # Management Engine Interface 1 + subsystemid 0x8086 0x1c3a + end + device pci 16.1 off end # Management Engine Interface 2 + device pci 16.2 off end # Management Engine IDE-R + device pci 16.3 off end # Management Engine KT + device pci 19.0 off end # Intel Gigabit Ethernet + device pci 1a.0 on # USB2 EHCI #2 + subsystemid 0x8086 0x1c2d + end + device pci 1b.0 on # High Definition Audio + subsystemid 0x8086 0x1c20 + end + device pci 1c.0 on # PCIe Port #1 + subsystemid 0x8086 0x1c10 + end + device pci 1c.1 off end # PCIe Port #2 + device pci 1c.2 off end # PCIe Port #3 + device pci 1c.3 off end # PCIe Port #4 + device pci 1c.4 off end # PCIe Port #5 + device pci 1c.5 on # PCIe Port #6 + subsystemid 0x8086 0x1c1a + end + device pci 1c.6 off end # PCIe Port #7 + device pci 1c.7 off end # PCIe Port #8 + device pci 1d.0 on # USB2 EHCI #1 + subsystemid 0x8086 0x1c26 + end + device pci 1e.0 off end # PCI bridge + device pci 1f.0 on # LPC bridge + subsystemid 0x8086 0x1c5c + end + device pci 1f.2 on # SATA Controller 1 + subsystemid 0x8086 0x1c02 + end + device pci 1f.3 on # SMBus + subsystemid 0x8086 0x1c22 + end + device pci 1f.5 off end # SATA Controller 2 + + device pci 1f.6 off end # Thermal + end + device pci 00.0 on # Host bridge Host bridge + subsystemid 0x8086 0x0100 + end + device pci 01.0 on # PEG + subsystemid 0x8086 0x0101 + end + device pci 02.0 on # iGPU + subsystemid 0x8086 0x2010 + end + end +end diff --git a/src/mainboard/ongy/h61m-s1/dsdt.asl b/src/mainboard/ongy/h61m-s1/dsdt.asl new file mode 100644 index 0000000..8c67659 --- /dev/null +++ b/src/mainboard/ongy/h61m-s1/dsdt.asl @@ -0,0 +1,43 @@ +/* +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License as published by +* the Free Software Foundation; version 2 of the License. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +*/ + +#define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 + +#include <arch/acpi.h> + +DefinitionBlock( + "dsdt.aml", + "DSDT", + 0x02, // DSDT revision: ACPI v2.0 and up + OEM_ID, + ACPI_TABLE_CREATOR, + 0x20141018 // OEM revision +) +{ + #include "acpi/mainboard.asl" + #include "acpi/platform.asl" + #include "acpi/superio.asl" + #include "acpi/thermal.asl" + #include <cpu/intel/common/acpi/cpu.asl> + #include <southbridge/intel/common/acpi/platform.asl> + + /* global NVS and variables. */ + #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> + #include <southbridge/intel/common/acpi/sleepstates.asl> + + Device (\_SB.PCI0) + { + #include <northbridge/intel/sandybridge/acpi/sandybridge.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> + #include <southbridge/intel/bd82x6x/acpi/pch.asl> + } +} diff --git a/src/mainboard/ongy/h61m-s1/early_init.c b/src/mainboard/ongy/h61m-s1/early_init.c new file mode 100644 index 0000000..6cb36f1 --- /dev/null +++ b/src/mainboard/ongy/h61m-s1/early_init.c @@ -0,0 +1,45 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* This file is part of the coreboot project. */ + +#include <stdint.h> +#include <string.h> +#include <timestamp.h> +#include <arch/byteorder.h> +#include <device/mmio.h> +#include <device/pci_ops.h> +#include <device/pnp_ops.h> +#include <console/console.h> +#include <bootblock_common.h> +#include <northbridge/intel/sandybridge/sandybridge.h> +#include <northbridge/intel/sandybridge/raminit_native.h> +#include <southbridge/intel/bd82x6x/pch.h> +#include <southbridge/intel/common/gpio.h> + +const struct southbridge_usb_port mainboard_usb_ports[] = { + { 1, 0, 0 }, + { 1, 0, 0 }, + { 1, 0, 1 }, + { 1, 0, 1 }, + { 1, 0, 2 }, + { 1, 0, 2 }, + { 1, 0, 3 }, + { 1, 0, 3 }, + { 1, 0, 4 }, + { 1, 0, 4 }, + { 1, 0, 6 }, + { 1, 0, 5 }, + { 1, 0, 5 }, + { 1, 0, 6 }, +}; + +void bootblock_mainboard_early_init(void) +{ + pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x1401); + pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0000); +} + +void mainboard_get_spd(spd_raw_data *spd, bool id_only) +{ + read_spd(&spd[0], 0x50, id_only); + read_spd(&spd[2], 0x52, id_only); +} diff --git a/src/mainboard/ongy/h61m-s1/gma-mainboard.ads b/src/mainboard/ongy/h61m-s1/gma-mainboard.ads new file mode 100644 index 0000000..e2c84c6 --- /dev/null +++ b/src/mainboard/ongy/h61m-s1/gma-mainboard.ads @@ -0,0 +1,15 @@ +-- SPDX-License-Identifier: GPL-2.0-only +-- This file is part of the coreboot project. + +with HW.GFX.GMA; +with HW.GFX.GMA.Display_Probing; + +use HW.GFX.GMA; +use HW.GFX.GMA.Display_Probing; + +private package GMA.Mainboard is + ports : constant Port_List := + (HDMI1, + Analog, + others => Disabled); +end GMA.Mainboard; diff --git a/src/mainboard/ongy/h61m-s1/gpio.c b/src/mainboard/ongy/h61m-s1/gpio.c new file mode 100644 index 0000000..22f4838 --- /dev/null +++ b/src/mainboard/ongy/h61m-s1/gpio.c @@ -0,0 +1,178 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* This file is part of the coreboot project. */ + +#include <southbridge/intel/common/gpio.h> + +static const struct pch_gpio_set1 pch_gpio_set1_mode = { + .gpio0 = GPIO_MODE_GPIO, + .gpio1 = GPIO_MODE_GPIO, + .gpio2 = GPIO_MODE_NATIVE, + .gpio3 = GPIO_MODE_NATIVE, + .gpio4 = GPIO_MODE_NATIVE, + .gpio5 = GPIO_MODE_NATIVE, + .gpio6 = GPIO_MODE_GPIO, + .gpio7 = GPIO_MODE_GPIO, + .gpio8 = GPIO_MODE_GPIO, + .gpio9 = GPIO_MODE_NATIVE, + .gpio10 = GPIO_MODE_NATIVE, + .gpio11 = GPIO_MODE_NATIVE, + .gpio12 = GPIO_MODE_GPIO, + .gpio13 = GPIO_MODE_GPIO, + .gpio14 = GPIO_MODE_NATIVE, + .gpio15 = GPIO_MODE_GPIO, + .gpio16 = GPIO_MODE_GPIO, + .gpio17 = GPIO_MODE_GPIO, + .gpio18 = GPIO_MODE_NATIVE, + .gpio19 = GPIO_MODE_NATIVE, + .gpio20 = GPIO_MODE_NATIVE, + .gpio21 = GPIO_MODE_NATIVE, + .gpio22 = GPIO_MODE_GPIO, + .gpio23 = GPIO_MODE_NATIVE, + .gpio24 = GPIO_MODE_GPIO, + .gpio25 = GPIO_MODE_NATIVE, + .gpio26 = GPIO_MODE_NATIVE, + .gpio27 = GPIO_MODE_GPIO, + .gpio28 = GPIO_MODE_GPIO, + .gpio29 = GPIO_MODE_GPIO, + .gpio30 = GPIO_MODE_NATIVE, + .gpio31 = GPIO_MODE_GPIO, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_direction = { + .gpio0 = GPIO_DIR_INPUT, + .gpio1 = GPIO_DIR_INPUT, + .gpio6 = GPIO_DIR_INPUT, + .gpio7 = GPIO_DIR_INPUT, + .gpio8 = GPIO_DIR_OUTPUT, + .gpio12 = GPIO_DIR_OUTPUT, + .gpio13 = GPIO_DIR_INPUT, + .gpio15 = GPIO_DIR_OUTPUT, + .gpio16 = GPIO_DIR_INPUT, + .gpio17 = GPIO_DIR_INPUT, + .gpio22 = GPIO_DIR_INPUT, + .gpio24 = GPIO_DIR_OUTPUT, + .gpio27 = GPIO_DIR_INPUT, + .gpio28 = GPIO_DIR_OUTPUT, + .gpio29 = GPIO_DIR_OUTPUT, + .gpio31 = GPIO_DIR_INPUT, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_level = { + .gpio8 = GPIO_LEVEL_HIGH, + .gpio12 = GPIO_LEVEL_HIGH, + .gpio15 = GPIO_LEVEL_LOW, + .gpio24 = GPIO_LEVEL_LOW, + .gpio28 = GPIO_LEVEL_LOW, + .gpio29 = GPIO_LEVEL_HIGH, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_reset = { +}; + +static const struct pch_gpio_set1 pch_gpio_set1_invert = { + .gpio13 = GPIO_INVERT, +}; + +static const struct pch_gpio_set1 pch_gpio_set1_blink = { +}; + +static const struct pch_gpio_set2 pch_gpio_set2_mode = { + .gpio32 = GPIO_MODE_GPIO, + .gpio33 = GPIO_MODE_GPIO, + .gpio34 = GPIO_MODE_GPIO, + .gpio35 = GPIO_MODE_NATIVE, + .gpio36 = GPIO_MODE_NATIVE, + .gpio37 = GPIO_MODE_NATIVE, + .gpio38 = GPIO_MODE_NATIVE, + .gpio39 = GPIO_MODE_NATIVE, + .gpio40 = GPIO_MODE_NATIVE, + .gpio41 = GPIO_MODE_NATIVE, + .gpio42 = GPIO_MODE_NATIVE, + .gpio43 = GPIO_MODE_NATIVE, + .gpio44 = GPIO_MODE_NATIVE, + .gpio45 = GPIO_MODE_NATIVE, + .gpio46 = GPIO_MODE_NATIVE, + .gpio47 = GPIO_MODE_NATIVE, + .gpio48 = GPIO_MODE_NATIVE, + .gpio49 = GPIO_MODE_GPIO, + .gpio50 = GPIO_MODE_NATIVE, + .gpio51 = GPIO_MODE_NATIVE, + .gpio52 = GPIO_MODE_NATIVE, + .gpio53 = GPIO_MODE_NATIVE, + .gpio54 = GPIO_MODE_NATIVE, + .gpio55 = GPIO_MODE_NATIVE, + .gpio56 = GPIO_MODE_NATIVE, + .gpio57 = GPIO_MODE_GPIO, + .gpio58 = GPIO_MODE_NATIVE, + .gpio59 = GPIO_MODE_NATIVE, + .gpio60 = GPIO_MODE_NATIVE, + .gpio61 = GPIO_MODE_NATIVE, + .gpio62 = GPIO_MODE_NATIVE, + .gpio63 = GPIO_MODE_NATIVE, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_direction = { + .gpio32 = GPIO_DIR_OUTPUT, + .gpio33 = GPIO_DIR_OUTPUT, + .gpio34 = GPIO_DIR_INPUT, + .gpio49 = GPIO_DIR_INPUT, + .gpio57 = GPIO_DIR_INPUT, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_level = { + .gpio32 = GPIO_LEVEL_HIGH, + .gpio33 = GPIO_LEVEL_HIGH, +}; + +static const struct pch_gpio_set2 pch_gpio_set2_reset = { +}; + +static const struct pch_gpio_set3 pch_gpio_set3_mode = { + .gpio64 = GPIO_MODE_NATIVE, + .gpio65 = GPIO_MODE_NATIVE, + .gpio66 = GPIO_MODE_NATIVE, + .gpio67 = GPIO_MODE_NATIVE, + .gpio68 = GPIO_MODE_GPIO, + .gpio69 = GPIO_MODE_GPIO, + .gpio70 = GPIO_MODE_NATIVE, + .gpio71 = GPIO_MODE_NATIVE, + .gpio72 = GPIO_MODE_GPIO, + .gpio73 = GPIO_MODE_NATIVE, + .gpio74 = GPIO_MODE_NATIVE, + .gpio75 = GPIO_MODE_NATIVE, +}; + +static const struct pch_gpio_set3 pch_gpio_set3_direction = { + .gpio68 = GPIO_DIR_INPUT, + .gpio69 = GPIO_DIR_INPUT, + .gpio72 = GPIO_DIR_INPUT, +}; + +static const struct pch_gpio_set3 pch_gpio_set3_level = { +}; + +static const struct pch_gpio_set3 pch_gpio_set3_reset = { +}; + +const struct pch_gpio_map mainboard_gpio_map = { + .set1 = { + .mode = &pch_gpio_set1_mode, + .direction = &pch_gpio_set1_direction, + .level = &pch_gpio_set1_level, + .blink = &pch_gpio_set1_blink, + .invert = &pch_gpio_set1_invert, + .reset = &pch_gpio_set1_reset, + }, + .set2 = { + .mode = &pch_gpio_set2_mode, + .direction = &pch_gpio_set2_direction, + .level = &pch_gpio_set2_level, + .reset = &pch_gpio_set2_reset, + }, + .set3 = { + .mode = &pch_gpio_set3_mode, + .direction = &pch_gpio_set3_direction, + .level = &pch_gpio_set3_level, + .reset = &pch_gpio_set3_reset, + }, +}; diff --git a/src/mainboard/ongy/h61m-s1/hda_verb.c b/src/mainboard/ongy/h61m-s1/hda_verb.c new file mode 100644 index 0000000..09748c0 --- /dev/null +++ b/src/mainboard/ongy/h61m-s1/hda_verb.c @@ -0,0 +1,43 @@ +/* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; version 2 of +* the License. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +*/ + +#include <device/azalia_device.h> + +const u32 cim_verb_data[] = { + 0x10ec0662, /* Codec Vendor / Device ID: Realtek*/ + 0x10ec0000, /* Subsystem ID*/ + 12, /* Number of 4 dword sets*/ + AZALIA_SUBVENDOR(2, 0x10ec0000), + AZALIA_PIN_CFG(2, 0x12, 0x40130000), + AZALIA_PIN_CFG(2, 0x14, 0x01014010), + AZALIA_PIN_CFG(2, 0x15, 0x411111f0), + AZALIA_PIN_CFG(2, 0x16, 0x411111f0), + AZALIA_PIN_CFG(2, 0x18, 0x01a19040), + AZALIA_PIN_CFG(2, 0x19, 0x02a19050), + AZALIA_PIN_CFG(2, 0x1a, 0x0181304f), + AZALIA_PIN_CFG(2, 0x1b, 0x02214020), + AZALIA_PIN_CFG(2, 0x1c, 0x411111f0), + AZALIA_PIN_CFG(2, 0x1d, 0x4044c601), + AZALIA_PIN_CFG(2, 0x1e, 0x01441130), + + 0x80862805, /* Codec Vendor / Device ID: Intel*/ + 0x80860101, /* Subsystem ID*/ + 4, /* Number of 4 dword sets*/ + AZALIA_SUBVENDOR(3, 0x80860101), + AZALIA_PIN_CFG(3, 0x05, 0x18560010), + AZALIA_PIN_CFG(3, 0x06, 0x18560020), + AZALIA_PIN_CFG(3, 0x07, 0x18560030), +}; + +const u32 pc_beep_verbs[0] = {}; + +AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/ongy/h61m-s1/mainboard.c b/src/mainboard/ongy/h61m-s1/mainboard.c new file mode 100644 index 0000000..3f9c24e --- /dev/null +++ b/src/mainboard/ongy/h61m-s1/mainboard.c @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* This file is part of the coreboot project. */ + +#include <device/device.h> +#include <drivers/intel/gma/int15.h> +#include <southbridge/intel/bd82x6x/pch.h> + +static void mainboard_enable(struct device *dev) +{ + install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, + GMA_INT15_PANEL_FIT_DEFAULT, + GMA_INT15_BOOT_DISPLAY_DEFAULT, 0); +} + +struct chip_operations mainboard_ops = { + .enable_dev = mainboard_enable, +}; -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 1 Gerrit-Owner: Skoll RC Gerrit-MessageType: newchange
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#2). Change subject: adding new mainboard (no official website as it is a noname board but easy to find) see https://github.com/skollrc/coreboot_noname_h61S1_port for more details ...................................................................... adding new mainboard (no official website as it is a noname board but easy to find) see https://github.com/skollrc/coreboot_noname_h61S1_port for more details Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 560 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 2 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#3). Change subject: adding new mainboard Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c ...................................................................... adding new mainboard Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 560 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 3 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#4). Change subject: adding new mainboard ...................................................................... adding new mainboard Tested: Restart, resume and shutdown (ubuntu 18.04 LTS) Network USB boot (USB 2.0 only) integrated sound integrated VGA and HDMI Seabios payload PCIe 16x card (HD5450 - VGA only) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 560 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 4 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#5). Change subject: adding new mainboard ...................................................................... adding new mainboard Tested: Restart, resume and shutdown (ubuntu 18.04 LTS) Network USB boot (USB 2.0 only) integrated sound integrated VGA and HDMI Seabios payload PCIe 16x card (HD5450 - VGA only) some more infos on my personal repo: https://github.com/skollrc/coreboot_ongy_h61m-s1_port Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 560 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 5 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#6). Change subject: adding new mainboard (no official website as it is a noname board but easy to find) see https://github.com/skollrc/coreboot_noname_h61S1_port for more details ...................................................................... adding new mainboard (no official website as it is a noname board but easy to find) see https://github.com/skollrc/coreboot_noname_h61S1_port for more details Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 559 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 6 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#7). Change subject: adding new mainboard ...................................................................... adding new mainboard ported with autoport tool Tested: Restart, resume and shutdown (ubuntu 18.04 LTS) Network USB boot (USB 2.0 only) integrated sound integrated VGA and HDMI Seabios payload PCIe 16x card (HD5450 - VGA only) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 559 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 7 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: adding new mainboard ...................................................................... Patch Set 6: (11 comments) Many vendors are just reselling mainboards from other companies. Is this yours? https://www.gigabyte.com/de/Motherboard/GA-H61M-S1-rev-21#ov If yes, then the vendor is Gigabyte. https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig File src/mainboard/ongy/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig@... PS6, Line 12: default "H61M-S1" Ongy https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig.... File src/mainboard/ongy/Kconfig.name: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig.... PS6, Line 2: bool "ongy" _O_ngy https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: ## : ## This file is part of the coreboot project. : ## : ## : ## This program is free software; you can redistribute it and/or modify : ## it under the terms of the GNU General Public License as published by : ## the Free Software Foundation; version 2 of the License. : ## : ## This program is distributed in the hope that it will be useful, : ## but WITHOUT ANY WARRANTY; without even the implied warranty of : ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : ## GNU General Public License for more details. : ## Replace by .. ## SPDX-License-Identifier: GPL-2.0-only ## This file is part of the coreboot project. https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 15: if BOARD_H61M_S1 BOARD_ONGY_H61M_S1 https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/Kconfig.name: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: config BOARD_H61M_S1 BOARD_ONGY_H61M_S1 https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 2: bool "h61m-s1" H61M-S1 https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/acpi/platform.asl: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 2: /* This file is part of the coreboot project. */ Add a new line this here. https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: /* : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Replace by .. /* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */ https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: /* : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Replace by .. /* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */ https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 13: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 Not sure if this is required here, but I would switch that define with that include two lines laters https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: /* : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ Replace by .. /* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */ -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 6 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-Comment-Date: Tue, 28 Apr 2020 21:52:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#8). Change subject: adding new mainboard (no official website as it is a noname board but easy to find) see https://github.com/skollrc/coreboot_noname_h61S1_port for more details ...................................................................... adding new mainboard (no official website as it is a noname board but easy to find) see https://github.com/skollrc/coreboot_noname_h61S1_port for more details Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 547 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 8 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#9). Change subject: adding new mainboard ported with autoport script ...................................................................... adding new mainboard ported with autoport script Tested: Restart, resume and shutdown works Network (not tested for PXE boot, just with loaded OS) USB boot (USB 2.0 only - USB 3.0 works sometimes but not always, don't why yet - Works when OS is loaded) SATA (all ports) integrated Sound Integrated VGA and HDMI works PCIe 16x port (with HD5450 - VGA only) Seabios payload works fine Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 547 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 9 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: adding new mainboard ported with autoport script ...................................................................... Patch Set 9:
Patch Set 6:
(11 comments)
Many vendors are just reselling mainboards from other companies. Is this yours? https://www.gigabyte.com/de/Motherboard/GA-H61M-S1-rev-21#ov
If yes, then the vendor is Gigabyte.
No, it is not GA-H61M-S1 but onlu H61m-S1. It's seems to be a chinese version of this board -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 9 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-Comment-Date: Tue, 28 Apr 2020 22:08:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#10). Change subject: adding new mainboard ported with autoport script ...................................................................... adding new mainboard ported with autoport script Tested: Restart, resume and shutdown works Network (not tested for PXE boot, just with loaded OS) USB boot (USB 2.0 only - USB 3.0 works sometimes but not always, don't why yet - Works when OS is loaded) SATA (all ports) integrated Sound Integrated VGA and HDMI works PCIe 16x port (with HD5450 - VGA only) Seabios payload works fine Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 520 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 10 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: adding new mainboard ported with autoport script ...................................................................... Patch Set 10: (11 comments)
Patch Set 9:
Patch Set 6:
(11 comments)
Many vendors are just reselling mainboards from other companies. Is this yours? https://www.gigabyte.com/de/Motherboard/GA-H61M-S1-rev-21#ov
If yes, then the vendor is Gigabyte.
No, it is not GA-H61M-S1 but onlu H61m-S1. It's seems to be a chinese version of this board
only* https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig File src/mainboard/ongy/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig@... PS6, Line 12: default "H61M-S1"
Ongy Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig.... File src/mainboard/ongy/Kconfig.name: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig.... PS6, Line 2: bool "ongy"
_O_ngy Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: ## : ## This file is part of the coreboot project. : ## : ## : ## This program is free software; you can redistribute it and/or modify : ## it under the terms of the GNU General Public License as published by : ## the Free Software Foundation; version 2 of the License. : ## : ## This program is distributed in the hope that it will be useful, : ## but WITHOUT ANY WARRANTY; without even the implied warranty of : ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : ## GNU General Public License for more details. : ##
Replace by .. […] Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 15: if BOARD_H61M_S1
BOARD_ONGY_H61M_S1 Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/Kconfig.name: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: config BOARD_H61M_S1
BOARD_ONGY_H61M_S1 Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 2: bool "h61m-s1"
H61M-S1 Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/acpi/platform.asl: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 2: /* This file is part of the coreboot project. */
Add a new line this here. Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: /* : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Replace by .. […] Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: /* : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Replace by .. […] Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 13: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Not sure if this is required here, but I would switch that define with that include two lines laters Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: /* : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Replace by .. […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 10 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-Comment-Date: Tue, 28 Apr 2020 22:19:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net> Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: adding new mainboard ported with autoport script ...................................................................... Patch Set 10: (6 comments) https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 6: register "gpu_cpu_backlight" = "0x00000000" I think you can remove https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 10: register "gpu_panel_port_select" = "0" : register "gpu_panel_power_backlight_off_delay" = "0" : register "gpu_panel_power_backlight_on_delay" = "0" default values. maybe remove https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 14: register "gpu_panel_power_down_delay" = "0" : register "gpu_panel_power_up_delay" = "0" : register "gpu_pch_backlight" = "0x00000000" this is default. so I think you can remove https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 34: register "gen2_dec" = "0x00000000" : register "gen3_dec" = "0x00000000" : register "gen4_dec" = "0x00000000" maybe you can remove https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 4: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 is it used? https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 4: #include <stdint.h> : #include <string.h> : #include <timestamp.h> : #include <arch/byteorder.h> : #include <device/mmio.h> : #include <device/pci_ops.h> : #include <device/pnp_ops.h> : #include <console/console.h> : #include <bootblock_common.h> : #include <northbridge/intel/sandybridge/sandybridge.h> : #include <northbridge/intel/sandybridge/raminit_native.h> : #include <southbridge/intel/bd82x6x/pch.h> : #include <southbridge/intel/common/gpio.h> Please remove unused includes -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 10 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Comment-Date: Wed, 29 Apr 2020 05:10:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: adding new mainboard ported with autoport script ...................................................................... Patch Set 10: (4 comments) https://review.coreboot.org/c/coreboot/+/40813/10//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/10//COMMIT_MSG@7 PS10, Line 7: adding new mainboard : ported with autoport script Use the imperative, e.g. mb/ongy/h61m-s1: Add new mainboard https://review.coreboot.org/c/coreboot/+/40813/10//COMMIT_MSG@13 PS10, Line 13: USB boot (USB 2.0 only - USB 3.0 works sometimes but not always, don't why yet - Works when OS is loaded) Description has a character limit 72 per line. https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/Kconfig File src/mainboard/ongy/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/Kconfig... PS10, Line 1: if VENDOR_ONGY Add a line break here https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 1: /* : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ /* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */ -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 10 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Comment-Date: Wed, 29 Apr 2020 07:30:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: adding new mainboard ported with autoport script ...................................................................... Patch Set 10:
Patch Set 10:
(4 comments)
When I want to commit changes, I have a message from lint: check Kconfig files for errors (lint-stable-008-kconfig): #!!!!! Error: Undefined Symbol 'BOARD_ONGY_H61M_S1' used at src/mainboard/ongy/h61m-s1/Kconfig:4. but it is not an error How can I handle this? -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 10 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Comment-Date: Wed, 29 Apr 2020 10:10:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#11). Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... mb/ongy/h61m-s1: Add new mainboard port done with autoport script Tested: Restart, resume and shutdown works Network (not tested for PXE boot, just with loaded OS) USB boot (USB 2.0 only) SATA (all ports) integrated Sound Integrated VGA and HDMI works PCIe 16x port (with HD5450 - VGA only) Seabios payload works fine Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 495 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 11 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 11: (10 comments)
Patch Set 10:
Patch Set 10:
(4 comments)
When I want to commit changes, I have a message from lint:
check Kconfig files for errors (lint-stable-008-kconfig): #!!!!! Error: Undefined Symbol 'BOARD_ONGY_H61M_S1' used at src/mainboard/ongy/h61m-s1/Kconfig:4. but it is not an error
How can I handle this? --> done with this
I now have a executable bite bit all my files are 644 and folders 755. What is the problem? I don't undersand where is the executable bit https://review.coreboot.org/c/coreboot/+/40813/10//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/10//COMMIT_MSG@7 PS10, Line 7: adding new mainboard : ported with autoport script
Use the imperative, e.g. […] Done
https://review.coreboot.org/c/coreboot/+/40813/10//COMMIT_MSG@13 PS10, Line 13: USB boot (USB 2.0 only - USB 3.0 works sometimes but not always, don't why yet - Works when OS is loaded)
Description has a character limit 72 per line. Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/Kconfig File src/mainboard/ongy/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/Kconfig... PS10, Line 1: if VENDOR_ONGY
Add a line break here Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 6: register "gpu_cpu_backlight" = "0x00000000"
I think you can remove Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 10: register "gpu_panel_port_select" = "0" : register "gpu_panel_power_backlight_off_delay" = "0" : register "gpu_panel_power_backlight_on_delay" = "0"
default values. […] Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 14: register "gpu_panel_power_down_delay" = "0" : register "gpu_panel_power_up_delay" = "0" : register "gpu_pch_backlight" = "0x00000000"
this is default. […] Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 34: register "gen2_dec" = "0x00000000" : register "gen3_dec" = "0x00000000" : register "gen4_dec" = "0x00000000"
maybe you can remove Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 4: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
is it used? yes, it seems to be used for integrated GPU
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 4: #include <stdint.h> : #include <string.h> : #include <timestamp.h> : #include <arch/byteorder.h> : #include <device/mmio.h> : #include <device/pci_ops.h> : #include <device/pnp_ops.h> : #include <console/console.h> : #include <bootblock_common.h> : #include <northbridge/intel/sandybridge/sandybridge.h> : #include <northbridge/intel/sandybridge/raminit_native.h> : #include <southbridge/intel/bd82x6x/pch.h> : #include <southbridge/intel/common/gpio.h>
Please remove unused includes Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 1: /* : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
/* SPDX-License-Identifier: GPL-2.0-only */ […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 11 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Comment-Date: Wed, 29 Apr 2020 11:01:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net> Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 11:
Patch Set 11:
(10 comments)
Patch Set 10:
Patch Set 10:
(4 comments)
When I want to commit changes, I have a message from lint:
check Kconfig files for errors (lint-stable-008-kconfig): #!!!!! Error: Undefined Symbol 'BOARD_ONGY_H61M_S1' used at src/mainboard/ongy/h61m-s1/Kconfig:4. but it is not an error
How can I handle this? --> done with this
I now have a executable bit bit all my files are 644 and folders 755. What is the problem? I don't undersand where is the executable bit
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 11 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Comment-Date: Wed, 29 Apr 2020 11:04:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#12). Change subject: adding new mainboard ported with autoport script ...................................................................... adding new mainboard ported with autoport script Tested: Restart, resume and shutdown works Network (not tested for PXE boot, just with loaded OS) USB boot (USB 2.0 only - USB 3.0 works sometimes but not always, don't why yet - Works when OS is loaded) SATA (all ports) integrated Sound Integrated VGA and HDMI works PCIe 16x port (with HD5450 - VGA only) Seabios payload works fine Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 493 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 12 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#13). Change subject: adding new mainboard ported with autoport script ...................................................................... adding new mainboard ported with autoport script Tested: Restart, resume and shutdown works Network (not tested for PXE boot, just with loaded OS) USB boot (USB 2.0 only - USB 3.0 works sometimes but not always, don't why yet - Works when OS is loaded) SATA (all ports) integrated Sound Integrated VGA and HDMI works PCIe 16x port (with HD5450 - VGA only) Seabios payload works fine Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 497 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 13 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#14). Change subject: mb/ongy/h61m-s1: Add new mainboard ported with autoport script ...................................................................... mb/ongy/h61m-s1: Add new mainboard ported with autoport script Tested: Restart, resume and shutdown works Network (not tested for PXE boot, just with loaded OS) USB boot (USB 2.0 only) integrated Sound Integrated VGA and HDMI works PCIe 16x port (with HD5450 - VGA only) Seabios payload works fine Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 497 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 14 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ported with autoport script ...................................................................... Patch Set 14:
Patch Set 11:
Patch Set 11:
(10 comments)
Patch Set 10:
Patch Set 10:
(4 comments)
When I want to commit changes, I have a message from lint:
check Kconfig files for errors (lint-stable-008-kconfig): #!!!!! Error: Undefined Symbol 'BOARD_ONGY_H61M_S1' used at src/mainboard/ongy/h61m-s1/Kconfig:4. but it is not an error
How can I handle this? --> done with this
I now have a executable bit bit all my files are 644 and folders 755. What is the problem? I don't undersand where is the executable bit I checkout again and old patch and redo all modifications but I still don't know what's happend and how to solve this issue.
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 14 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Comment-Date: Wed, 29 Apr 2020 17:33:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ported with autoport script ...................................................................... Patch Set 14: (19 comments) Hi Robin, welcome to coreboot! I left a bunch of comments around the files. Feel free to ask if you have any doubts 😄
Patch Set 10:
(11 comments)
Patch Set 9:
Patch Set 6:
(11 comments)
Many vendors are just reselling mainboards from other companies. Is this yours? https://www.gigabyte.com/de/Motherboard/GA-H61M-S1-rev-21#ov
If yes, then the vendor is Gigabyte.
No, it is not GA-H61M-S1 but onlu H61m-S1. It's seems to be a chinese version of this board
only*
Felix, the board is completely different. Here's a picture I found: https://i0.wp.com/ae01.alicdn.com/kf/H2ef1edff41744124861983142fb86314f/H61M... https://review.coreboot.org/c/coreboot/+/40813/14//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/14//COMMIT_MSG@7 PS14, Line 7: mb/ongy/h61m-s1: Add new mainboard Add an empty line between the commit summary and the commit message: mb/ongy/h61m-s1: Add new mainboard Port done using the autoport utility. https://review.coreboot.org/c/coreboot/+/40813/14//COMMIT_MSG@15 PS14, Line 15: Integrated VGA and HDMI works Was this with libgfxinit? (the default graphics init for most Intel iGPUs) https://review.coreboot.org/c/coreboot/+/40813/14//COMMIT_MSG@17 PS14, Line 17: Seabios SeaBIOS https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 26: config VGA_BIOS_FILE : string : default "pci8086,0112.rom" : : config VGA_BIOS_ID : string : default "8086,0112" Remove this, it depends on the installed CPU https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 34: onfig DRAM_RESET_GATE_GPIO : int : default 60 This is not correct. GPIO60 is configured as native mode on your board. If ACPI S3 suspend/resume work correctly, you can remove it. Otherwise, we will have to guess the correct GPIO. https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 8: /* Disable USB ports in S3 by default */ : gnvs->s3u0 = 0; : gnvs->s3u1 = 0; : /* Disable USB ports in S5 by default */ : gnvs->s5u0 = 0; : gnvs->s5u1 = 0; This does nothing. The gnvs struct is cleared before calling this function https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 5: register "gfx" = "GMA_STATIC_DISPLAYS(0)" : register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_c_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4" : register "gpu_panel_power_cycle_delay" = "4" These settings aren't needed for a desktop board https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 10: 0x0 0 https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 18: 0x0 0 https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 22: 0x0 0 https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 25: register "docking_supported" = "0" This defaults to zero already. You can remove it https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 27: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }" This defaults to zero already. You can remove it https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 64: : device pci 00.0 on # Host bridge Host bridge : subsystemid 0x8086 0x0100 : end : device pci 01.0 on # PEG : subsystemid 0x8086 0x0101 : end : device pci 02.0 on # iGPU : subsystemid 0x8086 0x2010 : end Please move these entries above the southbridge block. That is, before this line: chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 4: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
yes, it seems to be used for integrated GPU It's only used on Lenovo mainboards. Please remove
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 4: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 Unused, can remove https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 22: g Capitalize: "Global" https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 29: #include <drivers/intel/gma/acpi/default_brightness_levels.asl> Not needed for a desktop board without an integrated panel https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 10: private package GMA.Mainboard is Almost all the gma_mainboard.ads files in coreboot are indented with three spaces, instead of tabs. Please do the same here https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c: PS14: If you don't plan on using the VGA BIOS, I would remove this and the `select INTEL_INT15` line from Kconfig -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 14 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Comment-Date: Wed, 29 Apr 2020 20:40:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Robin CASSET <amisbievre@posteo.net> Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ported with autoport script ...................................................................... Patch Set 14:
Patch Set 14:
(19 comments)
Hi Robin, welcome to coreboot!
I left a bunch of comments around the files. Feel free to ask if you have any doubts 😄
Patch Set 10:
(11 comments)
Patch Set 9:
Patch Set 6:
(11 comments)
Many vendors are just reselling mainboards from other companies. Is this yours? https://www.gigabyte.com/de/Motherboard/GA-H61M-S1-rev-21#ov
If yes, then the vendor is Gigabyte.
No, it is not GA-H61M-S1 but onlu H61m-S1. It's seems to be a chinese version of this board
only*
Felix, the board is completely different. Here's a picture I found:
https://i0.wp.com/ae01.alicdn.com/kf/H2ef1edff41744124861983142fb86314f/H61M...
You can have more infos on my personal repo about this board: https://github.com/skollrc/coreboot_ongy_h61m-s1_port -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 14 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Comment-Date: Wed, 29 Apr 2020 20:48:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ported with autoport script ...................................................................... Patch Set 14:
Patch Set 14:
Patch Set 14:
(19 comments)
Hi Robin, welcome to coreboot!
I left a bunch of comments around the files. Feel free to ask if you have any doubts 😄
Patch Set 10:
(11 comments)
Patch Set 9:
Patch Set 6:
(11 comments)
Many vendors are just reselling mainboards from other companies. Is this yours? https://www.gigabyte.com/de/Motherboard/GA-H61M-S1-rev-21#ov
If yes, then the vendor is Gigabyte.
No, it is not GA-H61M-S1 but onlu H61m-S1. It's seems to be a chinese version of this board
only*
Felix, the board is completely different. Here's a picture I found:
https://i0.wp.com/ae01.alicdn.com/kf/H2ef1edff41744124861983142fb86314f/H61M...
You can have more infos on my personal repo about this board: https://github.com/skollrc/coreboot_ongy_h61m-s1_port
And thx for your help! I will need it. I'm not realy developper just a curious to try a mainboard port. -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 14 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Comment-Date: Wed, 29 Apr 2020 20:50:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#15). Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... mb/ongy/h61m-s1: Add new mainboard Port done with the autoport utility Tested: Restart, resume and shutdown works Network (not tested for PXE, just with loaded OS) USB boot (USB 2.0 only) integrated Sound Integrated VGA and HDMI works with libgfxinit PCIe 16x port (with HD5450 - VGA only) SeaBIOS payload works fine Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 476 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 15 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: newpatchset
Skoll RC has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 15: Code-Review+1 (19 comments) Done with most of comments, I just need some answers for some files and I think it starts to be good https://review.coreboot.org/c/coreboot/+/40813/14//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/14//COMMIT_MSG@7 PS14, Line 7: mb/ongy/h61m-s1: Add new mainboard
Add an empty line between the commit summary and the commit message: […] Done
https://review.coreboot.org/c/coreboot/+/40813/14//COMMIT_MSG@15 PS14, Line 15: Integrated VGA and HDMI works
Was this with libgfxinit? (the default graphics init for most Intel iGPUs) Yes, I mentioned it in a new version of this file
https://review.coreboot.org/c/coreboot/+/40813/14//COMMIT_MSG@17 PS14, Line 17: Seabios
SeaBIOS Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 26: config VGA_BIOS_FILE : string : default "pci8086,0112.rom" : : config VGA_BIOS_ID : string : default "8086,0112"
Remove this, it depends on the installed CPU Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 34: onfig DRAM_RESET_GATE_GPIO : int : default 60
This is not correct. GPIO60 is configured as native mode on your board. […] Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 8: /* Disable USB ports in S3 by default */ : gnvs->s3u0 = 0; : gnvs->s3u1 = 0; : /* Disable USB ports in S5 by default */ : gnvs->s5u0 = 0; : gnvs->s5u1 = 0;
This does nothing. […] So must I remove all line and let a blank function or revmove everthing an let an empty file?
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 5: register "gfx" = "GMA_STATIC_DISPLAYS(0)" : register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_c_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4" : register "gpu_panel_power_cycle_delay" = "4"
These settings aren't needed for a desktop board Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 10: 0x0
0 Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 18: 0x0
0 Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 22: 0x0
0 Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 25: register "docking_supported" = "0"
This defaults to zero already. […] Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 27: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }"
This defaults to zero already. […] Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 64: : device pci 00.0 on # Host bridge Host bridge : subsystemid 0x8086 0x0100 : end : device pci 01.0 on # PEG : subsystemid 0x8086 0x0101 : end : device pci 02.0 on # iGPU : subsystemid 0x8086 0x2010 : end
Please move these entries above the southbridge block. That is, before this line: […] Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 4: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
It's only used on Lenovo mainboards. […] Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 4: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Unused, can remove Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 22: g
Capitalize: "Global" Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 29: #include <drivers/intel/gma/acpi/default_brightness_levels.asl>
Not needed for a desktop board without an integrated panel Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 10: private package GMA.Mainboard is
Almost all the gma_mainboard.ads files in coreboot are indented with three spaces, instead of tabs. […] Done (I think :-) )
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c: PS14:
If you don't plan on using the VGA BIOS, I would remove this and the `select INTEL_INT15` line from […] You mean remove everything? My first build was with libgfxinit indeed
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 15 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Comment-Date: Thu, 30 Apr 2020 21:25:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Skoll RC <amisbievre@posteo.net> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
Skoll RC has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Removed Code-Review+1 by Skoll RC <amisbievre@posteo.net> -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 15 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: deleteVote
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 15: (7 comments) https://review.coreboot.org/c/coreboot/+/40813/15//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/15//COMMIT_MSG@11 PS15, Line 11: Tested: You can make this look more like a list: Tested: - Restart ... - Network ... https://review.coreboot.org/c/coreboot/+/40813/15//COMMIT_MSG@13 PS15, Line 13: resume S3 resume? https://review.coreboot.org/c/coreboot/+/40813/15//COMMIT_MSG@16 PS15, Line 16: i Capitalize https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 8: /* Disable USB ports in S3 by default */ : gnvs->s3u0 = 0; : gnvs->s3u1 = 0; : /* Disable USB ports in S5 by default */ : gnvs->s5u0 = 0; : gnvs->s5u1 = 0;
So must I remove all line and let a blank function or revmove everthing an let an empty file? You can check other mainboards, I think they just leave the function empty
https://review.coreboot.org/c/coreboot/+/40813/15/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/40813/15/src/mainboard/ongy/h61m-s1... PS15, Line 18: Host bridge Host bridge Oh, didn't notice that this comment is duplicated https://review.coreboot.org/c/coreboot/+/40813/15/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/40813/15/src/mainboard/ongy/h61m-s1... PS15, Line 13: Analog, Tiiiny detail: the port values are aligned with an extra space: ports : constant Port_List := (HDMI1, Analog, others => Disabled); https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c: PS14:
You mean remove everything? My first build was with libgfxinit indeed Yes, I never needed it with libgfxinit
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 15 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Comment-Date: Thu, 30 Apr 2020 22:07:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Skoll RC <amisbievre@posteo.net> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#16). Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... mb/ongy/h61m-s1: Add new mainboard Port done with the autoport utility Tested: Restart, S3 resume and shutdown Network (not tested for PXE, just with loaded OS) USB boot (USB 2.0 only) Integrated Sound Integrated VGA and HDMI with libgfxinit PCIe 16x port (with HD5450 - VGA only) SeaBIOS payload Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 470 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/16 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 16 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#17). Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... mb/ongy/h61m-s1: Add new mainboard Port done with the autoport utility Tested: - Restart, S3 resume and shutdown - Network (not tested for PXE, just with loaded OS) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 470 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/17 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 17 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: newpatchset
Skoll RC has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 17: (44 comments) done, Jenkins Build faild but I can't access to the result. Maybe it is just in pending state? In order to let users to choose if they want to use or not VGA BIOS, I will leave mainboard.c unchange (like in other H61 mainboards) https://review.coreboot.org/c/coreboot/+/40813/10//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/10//COMMIT_MSG@7 PS10, Line 7: adding new mainboard : ported with autoport script
Done Done
https://review.coreboot.org/c/coreboot/+/40813/10//COMMIT_MSG@13 PS10, Line 13: USB boot (USB 2.0 only - USB 3.0 works sometimes but not always, don't why yet - Works when OS is loaded)
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/14//COMMIT_MSG@7 PS14, Line 7: mb/ongy/h61m-s1: Add new mainboard
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14//COMMIT_MSG@15 PS14, Line 15: Integrated VGA and HDMI works
Yes, I mentioned it in a new version of this file Done
https://review.coreboot.org/c/coreboot/+/40813/14//COMMIT_MSG@17 PS14, Line 17: Seabios
Done Done
https://review.coreboot.org/c/coreboot/+/40813/15//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/15//COMMIT_MSG@11 PS15, Line 11: Tested:
You can make this look more like a list: […] Done
https://review.coreboot.org/c/coreboot/+/40813/15//COMMIT_MSG@13 PS15, Line 13: resume
S3 resume? Done
https://review.coreboot.org/c/coreboot/+/40813/15//COMMIT_MSG@16 PS15, Line 16: i
Capitalize Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig File src/mainboard/ongy/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig@... PS6, Line 12: default "H61M-S1"
Done Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/Kconfig File src/mainboard/ongy/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/Kconfig... PS10, Line 1: if VENDOR_ONGY
Done Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig.... File src/mainboard/ongy/Kconfig.name: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/Kconfig.... PS6, Line 2: bool "ongy"
Done Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: ## : ## This file is part of the coreboot project. : ## : ## : ## This program is free software; you can redistribute it and/or modify : ## it under the terms of the GNU General Public License as published by : ## the Free Software Foundation; version 2 of the License. : ## : ## This program is distributed in the hope that it will be useful, : ## but WITHOUT ANY WARRANTY; without even the implied warranty of : ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : ## GNU General Public License for more details. : ##
Done Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 15: if BOARD_H61M_S1
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 26: config VGA_BIOS_FILE : string : default "pci8086,0112.rom" : : config VGA_BIOS_ID : string : default "8086,0112"
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 34: onfig DRAM_RESET_GATE_GPIO : int : default 60
Done Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/Kconfig.name: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: config BOARD_H61M_S1
Done Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 2: bool "h61m-s1"
Done Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/acpi/platform.asl: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 2: /* This file is part of the coreboot project. */
Done Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: /* : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 8: /* Disable USB ports in S3 by default */ : gnvs->s3u0 = 0; : gnvs->s3u1 = 0; : /* Disable USB ports in S5 by default */ : gnvs->s5u0 = 0; : gnvs->s5u1 = 0;
You can check other mainboards, I think they just leave the function empty Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 6: register "gpu_cpu_backlight" = "0x00000000"
Done Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 10: register "gpu_panel_port_select" = "0" : register "gpu_panel_power_backlight_off_delay" = "0" : register "gpu_panel_power_backlight_on_delay" = "0"
Done Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 14: register "gpu_panel_power_down_delay" = "0" : register "gpu_panel_power_up_delay" = "0" : register "gpu_pch_backlight" = "0x00000000"
Done Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 34: register "gen2_dec" = "0x00000000" : register "gen3_dec" = "0x00000000" : register "gen4_dec" = "0x00000000"
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 5: register "gfx" = "GMA_STATIC_DISPLAYS(0)" : register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_c_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4" : register "gpu_panel_power_cycle_delay" = "4"
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 10: 0x0
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 18: 0x0
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 22: 0x0
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 25: register "docking_supported" = "0"
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 27: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }"
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 64: : device pci 00.0 on # Host bridge Host bridge : subsystemid 0x8086 0x0100 : end : device pci 01.0 on # PEG : subsystemid 0x8086 0x0101 : end : device pci 02.0 on # iGPU : subsystemid 0x8086 0x2010 : end
Done Done
https://review.coreboot.org/c/coreboot/+/40813/15/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/40813/15/src/mainboard/ongy/h61m-s1... PS15, Line 18: Host bridge Host bridge
Oh, didn't notice that this comment is duplicated Done
https://review.coreboot.org/c/coreboot/+/40813/15/src/mainboard/ongy/h61m-s1... PS15, Line 18: Host bridge Host bridge
Oh, didn't notice that this comment is duplicated Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: /* : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Done Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 13: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Done Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 4: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 4: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 22: g
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 29: #include <drivers/intel/gma/acpi/default_brightness_levels.asl>
Done Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 4: #include <stdint.h> : #include <string.h> : #include <timestamp.h> : #include <arch/byteorder.h> : #include <device/mmio.h> : #include <device/pci_ops.h> : #include <device/pnp_ops.h> : #include <console/console.h> : #include <bootblock_common.h> : #include <northbridge/intel/sandybridge/sandybridge.h> : #include <northbridge/intel/sandybridge/raminit_native.h> : #include <southbridge/intel/bd82x6x/pch.h> : #include <southbridge/intel/common/gpio.h>
Done Done
https://review.coreboot.org/c/coreboot/+/40813/15/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/40813/15/src/mainboard/ongy/h61m-s1... PS15, Line 13: Analog,
Tiiiny detail: the port values are aligned with an extra space: […] Done
https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... File src/mainboard/ongy/h61m-s1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/40813/6/src/mainboard/ongy/h61m-s1/... PS6, Line 1: /* : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Done Done
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 1: /* : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
Done Done
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c: PS14:
Yes, I never needed it with libgfxinit https://github.com/coreboot/coreboot/blob/master/src/mainboard/gigabyte/ga-h... it is used in other similar mainboards. Maybe to let users choose if they want to use VGA BIOS or not. So I think it's better to leave this unchanged.
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 17 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Comment-Date: Thu, 30 Apr 2020 22:40:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net> Comment-In-Reply-To: Skoll RC <amisbievre@posteo.net> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 17: (3 comments) https://review.coreboot.org/c/coreboot/+/40813/17//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/17//COMMIT_MSG@4 PS17, Line 4: Skoll RC Use your name? https://review.coreboot.org/c/coreboot/+/40813/17//COMMIT_MSG@13 PS17, Line 13: - Restart, S3 resume and shutdown In what OS? What version (of Linux)? https://review.coreboot.org/c/coreboot/+/40813/17//COMMIT_MSG@19 PS17, Line 19: - SeaBIOS payload What version? -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 17 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 01 May 2020 10:57:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#18). Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... mb/ongy/h61m-s1: Add new mainboard Port done with the autoport utility Tested: - Restart, S3 resume and shutdown - Network (not PXE, works with Ubuntu 18.04 LTS, Kernel 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 470 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/18 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 18 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 18: (3 comments) Seems done with commit message update. Sorry, it's my first time using git as "developper" so I don't the knowledge on how to do things properly :-) https://review.coreboot.org/c/coreboot/+/40813/17//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/17//COMMIT_MSG@4 PS17, Line 4: Skoll RC
Use your name? Done
https://review.coreboot.org/c/coreboot/+/40813/17//COMMIT_MSG@13 PS17, Line 13: - Restart, S3 resume and shutdown
In what OS? What version (of Linux)? Done
https://review.coreboot.org/c/coreboot/+/40813/17//COMMIT_MSG@19 PS17, Line 19: - SeaBIOS payload
What version? Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 18 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 01 May 2020 11:23:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#19). Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... mb/ongy/h61m-s1: Add new mainboard Port done with the autoport utility Tested: - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 470 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/19 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 19 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#20). Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... mb/ongy/h61m-s1: Add new mainboard Port done with the autoport utility Tested: - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 470 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/20 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 20 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Skoll RC has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 20: Code-Review+1 looks good to me now :-) -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 20 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 02 May 2020 16:52:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 20: (1 comment) https://review.coreboot.org/c/coreboot/+/40813/20/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/20/src/mainboard/ongy/h61m-s1... PS20, Line 4: include <device/mmio.h> : #include <device/pci_ops.h> : #include <device/pnp_ops.h> : #include <bootblock_common.h> : #include <northbridge/intel/sandybridge/sandybridge.h> : #include <northbridge/intel/sandybridge/raminit_native.h> : #include <southbridge/intel/bd82x6x/pch.h> : #include <southbridge/intel/common/gpio.h> Please include only what you use -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 20 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 02 May 2020 19:22:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Skoll RC has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 20:
Patch Set 20:
(1 comment)
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 20 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 02 May 2020 19:38:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#21). Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... mb/ongy/h61m-s1: Add new mainboard Port done with the autoport utility Tested: - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 467 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/21 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 21 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 21: (1 comment)
Patch Set 20:
Patch Set 20:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40813/20/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/20/src/mainboard/ongy/h61m-s1... PS20, Line 4: include <device/mmio.h> : #include <device/pci_ops.h> : #include <device/pnp_ops.h> : #include <bootblock_common.h> : #include <northbridge/intel/sandybridge/sandybridge.h> : #include <northbridge/intel/sandybridge/raminit_native.h> : #include <southbridge/intel/bd82x6x/pch.h> : #include <southbridge/intel/common/gpio.h>
Please include only what you use Thx (Merci)
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 21 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 02 May 2020 19:47:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 21: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 21 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 02 May 2020 21:17:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 21: Code-Review+1 (4 comments) https://review.coreboot.org/c/coreboot/+/40813/17//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/17//COMMIT_MSG@4 PS17, Line 4: Skoll RC
Done Done
https://review.coreboot.org/c/coreboot/+/40813/17//COMMIT_MSG@13 PS17, Line 13: - Restart, S3 resume and shutdown
Done Done
https://review.coreboot.org/c/coreboot/+/40813/17//COMMIT_MSG@19 PS17, Line 19: - SeaBIOS payload
Done Done
https://review.coreboot.org/c/coreboot/+/40813/20/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/20/src/mainboard/ongy/h61m-s1... PS20, Line 4: include <device/mmio.h> : #include <device/pci_ops.h> : #include <device/pnp_ops.h> : #include <bootblock_common.h> : #include <northbridge/intel/sandybridge/sandybridge.h> : #include <northbridge/intel/sandybridge/raminit_native.h> : #include <southbridge/intel/bd82x6x/pch.h> : #include <southbridge/intel/common/gpio.h>
Thx […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 21 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 02 May 2020 23:00:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Robin CASSET <amisbievre@posteo.net> Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
Skoll RC has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Removed Code-Review+1 by Skoll RC <amisbievre@posteo.net> -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 21 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: deleteVote
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#22). Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... mb/ongy/h61m-s1: Add new mainboard Port done with the autoport utility Tested: - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable - Memtest86 v5.01 pass when loaded from ubuntu 18.04 live ISO Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) not works (black screen) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 466 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/22 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 22 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 22: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 22 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 04 May 2020 10:04:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 22: (2 comments) https://review.coreboot.org/c/coreboot/+/40813/22//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/22//COMMIT_MSG@25 PS22, Line 25: not works *does not work* (or remove, as it’s clear from the section “title”) https://review.coreboot.org/c/coreboot/+/40813/22//COMMIT_MSG@25 PS22, Line 25: - Tianocore payload (CorebootPayload) not works (black screen) Sometimes you need to wait five minutes due to some corner case, TianoCore does not handle. -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 22 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 04 May 2020 12:40:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#23). Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... mb/ongy/h61m-s1: Add new mainboard Port done with the autoport utility Tested: - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable - Memtest86 v5.01 pass when loaded from ubuntu 18.04 live ISO Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 466 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/23 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 23 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 23: (1 comment) https://review.coreboot.org/c/coreboot/+/40813/22//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/22//COMMIT_MSG@25 PS22, Line 25: - Tianocore payload (CorebootPayload) not works (black screen)
Sometimes you need to wait five minutes due to some corner case, TianoCore does not handle. I wait 20 minutes and nothing happend. I don't know why it is so buggy.
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 23 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 04 May 2020 13:39:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 23: (1 comment) https://review.coreboot.org/c/coreboot/+/40813/22//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/22//COMMIT_MSG@25 PS22, Line 25: not works
*does not work* (or remove, as it’s clear from the section “title”) Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 23 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 12 May 2020 17:43:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 23: (11 comments) Thx https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: ## This file is part of the coreboot project. remove https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi/platform.asl: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */ this also https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */ please remove this line https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: ## This file is part of the coreboot project. please remove https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */ remove https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */ remove please https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: -- This file is part of the coreboot project. please remove https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/gpio.c: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */ remove https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */ this one also https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: * This file is part of the coreboot project. * dito https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: * This file is part of the coreboot project. */ remove -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 23 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 14 May 2020 06:49:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#24). Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... mb/ongy/h61m-s1: Add new mainboard Port done with the autoport utility Tested: - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable - Memtest86 v5.01 pass when loaded from ubuntu 18.04 live ISO Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 456 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/24 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 24 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 24: (12 comments) Done with licence headers https://review.coreboot.org/c/coreboot/+/40813/22//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/22//COMMIT_MSG@25 PS22, Line 25: - Tianocore payload (CorebootPayload) not works (black screen)
I wait 20 minutes and nothing happend. I don't know why it is so buggy. Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: ## This file is part of the coreboot project.
remove Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi/platform.asl: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */
this also Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */
please remove this line Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: ## This file is part of the coreboot project.
please remove Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */
remove Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */
remove please Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: -- This file is part of the coreboot project.
please remove Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/gpio.c: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */
this one also Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: /* This file is part of the coreboot project. */
remove Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/hda_verb.c: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: * This file is part of the coreboot project. *
dito Done
https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c: https://review.coreboot.org/c/coreboot/+/40813/23/src/mainboard/ongy/h61m-s1... PS23, Line 2: * This file is part of the coreboot project. */
remove Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 24 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 14 May 2020 07:12:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Robin CASSET <amisbievre@posteo.net> Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 24: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c: https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... PS24, Line 9: install_intel_vga_int15_handler I'm not sure if you need this as your maindoard is a disktop. -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 24 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 14 May 2020 08:12:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard ...................................................................... Patch Set 24: (10 comments) https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@7 PS24, Line 7: mb/ongy/h61m-s1: Add new mainboard Mention the socket/chipset in the summary, so people can better classify the device at first look. https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@7 PS24, Line 7: ongy I have never heard of them. https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@9 PS24, Line 9: Port done with the autoport utility Please add a dot/period at the end. https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@10 PS24, Line 10: As there is no documentation added, please mention how to flash the image. Can the BIOS region be flashed with flashrom’s internal programmer when running the vendor firmware? https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@14 PS24, Line 14: 4.15.0-99-generic I thought that is the Linux kernel for 16.04. https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@25 PS24, Line 25: - Tianocore payload (CorebootPayload) What is the error? https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/Kconfig File src/mainboard/ongy/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/Kconfig... PS24, Line 1: Please remove the blank line. https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi/platform.asl: https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... PS24, Line 5: */ Please format the comment correctly. Is that still generated this way by current autoport? https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... PS24, Line 11: /*The _WAK method is called on system wakeup*/ Please add spaces. https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... PS24, Line 15: Return(Package(){0,0}) Please add spaces. Current autoport should have fixed this. -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 24 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 14 May 2020 10:57:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#25). Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} Port done with the autoport utility. Tested: - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable - Memtest86 v5.01 pass when loaded from ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 457 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/25 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 25 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 25: I mentioned the socket/chipset in the summary but as autoport utility is only for Sandy/Ivybirdge platformes, and H61 is in the name of the motherboard, I don't thinks it's realy usefull. When the code will be reviewed and merdged, I will write a documentation for this board. The commented part of platforme.asl is generated like this by autoport utility. -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 25 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 14 May 2020 14:12:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 25: (11 comments)
Patch Set 24:
(10 comments)
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@7 PS24, Line 7: mb/ongy/h61m-s1: Add new mainboard
Mention the socket/chipset in the summary, so people can better classify the device at first look. Done
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@7 PS24, Line 7: ongy
I have never heard of them. Done
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@9 PS24, Line 9: Port done with the autoport utility
Please add a dot/period at the end. Done
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@10 PS24, Line 10:
As there is no documentation added, please mention how to flash the image. […] Done
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@14 PS24, Line 14: 4.15.0-99-generic
I thought that is the Linux kernel for 16.04. Done
https://review.coreboot.org/c/coreboot/+/40813/24//COMMIT_MSG@25 PS24, Line 25: - Tianocore payload (CorebootPayload)
What is the error? Done
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/Kconfig File src/mainboard/ongy/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/Kconfig... PS24, Line 1:
Please remove the blank line. Done
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi/platform.asl: https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... PS24, Line 5: */
Please format the comment correctly. […] Done
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... PS24, Line 11: /*The _WAK method is called on system wakeup*/
Please add spaces. Done
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... PS24, Line 15: Return(Package(){0,0})
Please add spaces. Current autoport should have fixed this. Done
https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c: https://review.coreboot.org/c/coreboot/+/40813/24/src/mainboard/ongy/h61m-s1... PS24, Line 9: install_intel_vga_int15_handler
I'm not sure if you need this as your maindoard is a disktop. it is used in other H61 mainboards: https://github.com/coreboot/coreboot/blob/master/src/mainboard/gigabyte/ga-h...
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 25 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 14 May 2020 14:25:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 25: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/40813/25/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c: https://review.coreboot.org/c/coreboot/+/40813/25/src/mainboard/ongy/h61m-s1... PS25, Line 9: GMA_INT15_ACTIVE_LFP_INT_LVDS There's no LVDS on this board -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 25 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 19 May 2020 18:08:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#26). Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} Port done with the autoport utility. Tested: - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable - Memtest86 v5.01 pass when loaded from ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c A src/mainboard/ongy/h61m-s1/mainboard.c 17 files changed, 456 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/26 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 26 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Skoll RC has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 26: (1 comment) Done for the LVSD line :-) https://review.coreboot.org/c/coreboot/+/40813/25/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c: https://review.coreboot.org/c/coreboot/+/40813/25/src/mainboard/ongy/h61m-s1... PS25, Line 9: GMA_INT15_ACTIVE_LFP_INT_LVDS
There's no LVDS on this board Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 26 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 23 May 2020 21:24:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 26: (1 comment) https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c: https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... PS26, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */ you can delete this file. -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 26 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 24 May 2020 19:25:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 26: (2 comments)
Patch Set 26:
(1 comment)
You mean all the content or remove the mainboard.c file? https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... PS26, Line 27: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x1401); I need to chek if this is not an error, it should de default to (0x0000) there is no comX or LPT and no superIO (need to check this too) https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... PS26, Line 28: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0000); Default, need to remove -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 26 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 24 May 2020 19:33:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 26:
Patch Set 26:
(2 comments)
Patch Set 26:
(1 comment)
You mean all the content or remove the mainboard.c file?
yes, rm src/mainboard/ongy/h61m-s1/mainboard.c -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 26 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 24 May 2020 19:35:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#27). Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} Port done with the autoport utility. Tested: - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable - Memtest86 v5.01 pass when loaded from ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 16 files changed, 441 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/27 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 27 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 27: (1 comment) https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... PS26, Line 28: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0000);
Default, need to remove I think you can remove both
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 27 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 24 May 2020 19:43:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Robin CASSET <amisbievre@posteo.net> Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#28). Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} Port done with the autoport utility. Tested: - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable - Memtest86 v5.01 pass when loaded from ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 16 files changed, 440 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/28 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 28 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#29). Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} Port done with the autoport utility. Tested: - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable - Memtest86 v5.01 pass when loaded from ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 16 files changed, 435 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/29 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 29 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 29: (3 comments) Done for the last things. I need to do a new test in the motherboard to confirme everything works but I'can do it yet. https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... PS26, Line 27: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x1401);
I need to chek if this is not an error, it should de default to (0x0000) […] Done
https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... PS26, Line 28: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0000);
I think you can remove both Done
https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c: https://review.coreboot.org/c/coreboot/+/40813/26/src/mainboard/ongy/h61m-s1... PS26, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
you can delete this file. Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 29 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 24 May 2020 19:48:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Robin CASSET <amisbievre@posteo.net> Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 29: Code-Review+1 (3 comments) https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... PS29, Line 13: SERIRQ_CONTINUOUS_MODE If there is no SuperIO on LPC, I think you can drop this option https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... PS29, Line 28: register "docking_supported" = "0" You can remove this, it defaults to zero already https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... PS29, Line 15: #include "acpi/superio.asl" The superio.asl file is included elsewhere already, so this is unnecessary -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 29 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 24 May 2020 19:49:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#30). Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} Port done with the autoport utility. Tested: - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable - Memtest86 v5.01 pass when loaded from ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 16 files changed, 432 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/30 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 30 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 29: (4 comments) Done too :-) https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... PS29, Line 13: SERIRQ_CONTINUOUS_MODE
If there is no SuperIO on LPC, I think you can drop this option Done
https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... PS29, Line 13: SERIRQ_CONTINUOUS_MODE
If there is no SuperIO on LPC, I think you can drop this option Done
https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... PS29, Line 28: register "docking_supported" = "0"
You can remove this, it defaults to zero already Done
https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... PS29, Line 15: #include "acpi/superio.asl"
The superio. […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 29 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 24 May 2020 19:54:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 30: (1 comment) https://review.coreboot.org/c/coreboot/+/40813/30/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi/superio.asl: PS30: so you can delete superio.asl file 😜 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 30 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 24 May 2020 20:02:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#31). Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} Port done with the autoport utility. Tested: - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable - Memtest86 v5.01 pass when loaded from ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 15 files changed, 432 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/31 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 31 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 31: (1 comment)
Patch Set 30:
(1 comment)
Done with this too :-) https://review.coreboot.org/c/coreboot/+/40813/30/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi/superio.asl: PS30:
so you can delete superio. […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 31 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 24 May 2020 20:11:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 31: (1 comment) https://review.coreboot.org/c/coreboot/+/40813/30/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi/superio.asl: PS30:
Done sorry this file is needed by src/southbridge/intel/bd82x6x/acpi/lpc.asl I think.
let see if it compile ... , I think it will fail -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 31 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 24 May 2020 20:12:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Robin CASSET <amisbievre@posteo.net> Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 31: (1 comment) https://review.coreboot.org/c/coreboot/+/40813/31/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/31/src/mainboard/ongy/h61m-s1... PS31, Line 10: INTEL_INT15 wondering if this is needed -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 31 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 24 May 2020 20:24:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#32). Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} Port done with the autoport utility. Tested: - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable - Memtest86 v5.01 pass when loaded from ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 16 files changed, 432 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/32 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 32 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 32: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 32 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 24 May 2020 20:45:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#33). Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} Port done with the autoport utility. Tested: - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - SeaBIOS payload v1.13 stable - Memtest86 v5.01 pass when loaded from ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 16 files changed, 431 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/33 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 33 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 33: (2 comments) Done :-) https://review.coreboot.org/c/coreboot/+/40813/31/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/31/src/mainboard/ongy/h61m-s1... PS31, Line 10: INTEL_INT15
wondering if this is needed Done
https://review.coreboot.org/c/coreboot/+/40813/30/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi/superio.asl: PS30:
sorry […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 33 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 24 May 2020 22:25:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Robin CASSET <amisbievre@posteo.net> Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ...................................................................... Patch Set 33: Code-Review+1 (4 comments) https://review.coreboot.org/c/coreboot/+/40813/33//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/33//COMMIT_MSG@7 PS33, Line 7: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} Please add a space after the ,. https://review.coreboot.org/c/coreboot/+/40813/33//COMMIT_MSG@15 PS33, Line 15: - USB boot (USB 2.0 only) With what payload? (Further down you mention SeaBIOS, maybe move that up.) https://review.coreboot.org/c/coreboot/+/40813/33//COMMIT_MSG@20 PS33, Line 20: ubuntu Ubuntu https://review.coreboot.org/c/coreboot/+/40813/33//COMMIT_MSG@26 PS33, Line 26: - Tianocore payload (CorebootPayload) Just a black screen? -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 33 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-Comment-Date: Mon, 25 May 2020 10:00:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel, Angel Pons, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#34). Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} Port done with the autoport utility. Tested: - SeaBIOS payload v1.13 stable - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - Memtest86 v5.01 pass when loaded from Ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 16 files changed, 431 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/34 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 34 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} ...................................................................... Patch Set 34: (4 comments) Done with the commit message. https://review.coreboot.org/c/coreboot/+/40813/33//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/33//COMMIT_MSG@7 PS33, Line 7: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61}
Please add a space after the ,. Done
https://review.coreboot.org/c/coreboot/+/40813/33//COMMIT_MSG@15 PS33, Line 15: - USB boot (USB 2.0 only)
With what payload? (Further down you mention SeaBIOS, maybe move that up. […] Done
https://review.coreboot.org/c/coreboot/+/40813/33//COMMIT_MSG@20 PS33, Line 20: ubuntu
Ubuntu Done
https://review.coreboot.org/c/coreboot/+/40813/33//COMMIT_MSG@26 PS33, Line 26: - Tianocore payload (CorebootPayload)
Just a black screen? Just a black screen without any outputs (no videos, no USB console). I think I just missed sth but I don't know what yet. I will investigate on it when I will have time to
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 34 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-Comment-Date: Mon, 25 May 2020 13:45:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel, Angel Pons, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#35). Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation Port done with the autoport utility. Tested: - SeaBIOS payload v1.13 stable - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - Memtest86 v5.01 pass when loaded from Ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A Documentation/mainboard/ongy/h61m-s1.png A Documentation/mainboard/ongy/p8h61-m_pro.md A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 18 files changed, 527 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/35 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 35 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 35: (1 comment) I added a documentation page for the motherboard based on the ASUS P8H61-M PRO. I need to check the correct flash chip model as soon as I can. https://review.coreboot.org/c/coreboot/+/40813/35/Documentation/mainboard/on... File Documentation/mainboard/ongy/p8h61-m_pro.md: https://review.coreboot.org/c/coreboot/+/40813/35/Documentation/mainboard/on... PS35, Line 13: W25Q32BV I need to replace with the correct flash chip model -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 35 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-Comment-Date: Mon, 25 May 2020 14:41:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 35: (1 comment) https://review.coreboot.org/c/coreboot/+/40813/35/Documentation/mainboard/on... File Documentation/mainboard/ongy/p8h61-m_pro.md: https://review.coreboot.org/c/coreboot/+/40813/35/Documentation/mainboard/on... PS35, Line 51: me_cleaner breaks LPC bus and attached components! Need to test this as quick as I can. I tried one's to use me_cleaner without success. The reduced ME does not work but I seems a disabled (but uncut) ME works. -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 35 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-Comment-Date: Mon, 25 May 2020 14:44:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 35: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/40813/35/Documentation/mainboard/on... File Documentation/mainboard/ongy/p8h61-m_pro.md: https://review.coreboot.org/c/coreboot/+/40813/35/Documentation/mainboard/on... PS35, Line 1: ASUS P8H61-M Pro ? -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 35 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-Comment-Date: Mon, 25 May 2020 14:56:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel, Angel Pons, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#36). Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation Port done with the autoport utility. Tested: - SeaBIOS payload v1.13 stable - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - Memtest86 v5.01 pass when loaded from Ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A Documentation/mainboard/ongy/h61m-s1.md A Documentation/mainboard/ongy/h61m-s1.png A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 18 files changed, 527 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/36 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 36 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 36: (1 comment) Sorry, I forgot to replace some P8H61 links/names... https://review.coreboot.org/c/coreboot/+/40813/35/Documentation/mainboard/on... File Documentation/mainboard/ongy/p8h61-m_pro.md: https://review.coreboot.org/c/coreboot/+/40813/35/Documentation/mainboard/on... PS35, Line 1: ASUS P8H61-M Pro
? oups...
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 36 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-Comment-Date: Mon, 25 May 2020 14:59:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 36: (7 comments) https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... File Documentation/mainboard/ongy/h61m-s1.md: https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 48: - There is no automatic, OS-independent fan control. : The `coretemp` driver can still be used for : accurate CPU temperature readings. Your board doesn't have a SuperIO, so it doesn't really have this https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 51: - me_cleaner breaks LPC bus and attached components! I don't think your board has anything on the LPC bus https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 52: - Tianocore payload. The reason is yet undiscovered. Did you select a linear high-resolution framebuffer under menuconfig --> Devices --> Display ? tianocore needs that https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 57: 1x x1 https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 66: - Your board doesn't have a SuperIO, so it doesn't really have this https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 94: https://github.com/skollrc/coreboot_ongy_h61m-s1_port/blob/master/ROM_AND_DO... Is this manual available elsewhere? https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... File Documentation/mainboard/ongy/h61m-s1.png: PS36: This picture is really blurry and very large. It should be about 50 KiB at most -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 36 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-Comment-Date: Mon, 25 May 2020 15:50:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel, Angel Pons, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#37). Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation Port done with the autoport utility. Tested: - SeaBIOS payload v1.13 stable - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - Memtest86 v5.01 pass when loaded from Ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A Documentation/mainboard/ongy/h61m-s1.md A Documentation/mainboard/ongy/h61m-s1.png A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 18 files changed, 522 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/37 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 37 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-MessageType: newpatchset
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 37: (4 comments) The motherboard is easy to find but there absolutly no official website or documentation. That is one of the big problem. https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... File Documentation/mainboard/ongy/h61m-s1.md: https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 51: - me_cleaner breaks LPC bus and attached components!
I don't think your board has anything on the LPC bus There is nothing on the LPC, I didn't remove this because there is in fact a problem with reduced ME region but I don't know why yet.
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 52: - Tianocore payload. The reason is yet undiscovered.
Did you select a linear high-resolution framebuffer under menuconfig --> Devices --> Display ? tiano […] no! Maybe this is the problem.
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 57: 1x
x1 Done
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 94: https://github.com/skollrc/coreboot_ongy_h61m-s1_port/blob/master/ROM_AND_DO...
Is this manual available elsewhere? In the CD supplied with the motherboard. But as there is no "official" website for this motherboard, there is no official documentation.
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 37 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-Comment-Date: Mon, 25 May 2020 16:05:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel, Angel Pons, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#38). Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation Port done with the autoport utility. Tested: - SeaBIOS payload v1.13 stable - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - Memtest86 v5.01 pass when loaded from Ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A Documentation/mainboard/ongy/h61m-s1.md A Documentation/mainboard/ongy/h61m-s1.png A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 18 files changed, 522 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/38 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 38 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Felix Singer <felixsinger@posteo.net> Gerrit-MessageType: newpatchset
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 38: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 38 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Sun, 09 Aug 2020 15:41:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Robin CASSET has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 38: Hi, Sorry for the delay in response. I tested the lastest patch and now it is fully working even with Tianocore who is however very long to start (about 5 minutes). -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 38 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 12 Aug 2020 07:18:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 38:
Patch Set 38:
Hi,
Sorry for the delay in response. I tested the lastest patch and now it is fully working even with Tianocore who is however very long to start (about 5 minutes).
This might happen if you use a debug build. If there's no debug UART available, tianocore slows down a lot. -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 38 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 12 Aug 2020 10:34:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 38: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... PS38, Line 17: default ongy/h61m-s1 default "ongy/h61m-s1" -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 38 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 12 Aug 2020 10:41:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 38: (1 comment) https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... PS38, Line 2: : #include <device/pci_ops.h> not used. Please remove. -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 38 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 12 Aug 2020 13:09:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
HAOUAS Elyes has uploaded a new patch set (#39) to the change originally created by Robin CASSET. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation Port done with the autoport utility. Tested: - SeaBIOS payload v1.13 stable - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - Memtest86 v5.01 pass when loaded from Ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A Documentation/mainboard/ongy/h61m-s1.md A Documentation/mainboard/ongy/h61m-s1.png A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 18 files changed, 521 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/39 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 39 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 39: (2 comments) https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... PS38, Line 17: default ongy/h61m-s1
default "ongy/h61m-s1" Done
https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... PS38, Line 2: : #include <device/pci_ops.h>
not used. Please remove. Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 39 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 18 Aug 2020 16:35:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
HAOUAS Elyes has uploaded a new patch set (#40) to the change originally created by Robin CASSET. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation Port done with the autoport utility. Tested: - SeaBIOS payload v1.13 stable - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - Memtest86 v5.01 pass when loaded from Ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A Documentation/mainboard/ongy/h61m-s1.md A Documentation/mainboard/ongy/h61m-s1.png A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 18 files changed, 522 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/40 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 40 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
HAOUAS Elyes has uploaded a new patch set (#41) to the change originally created by Robin CASSET. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation Port done with the autoport utility. Tested: - SeaBIOS payload v1.13 stable - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - Memtest86 v5.01 pass when loaded from Ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A Documentation/mainboard/ongy/h61m-s1.md A Documentation/mainboard/ongy/h61m-s1.png A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 18 files changed, 522 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/41 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 41 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 41: Code-Review+2 Sorry, I've changed a couple of things to make Jenkins happy :) -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 41 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 18 Aug 2020 17:07:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 41: https://doc.coreboot.org/getting_started/gerrit_guidelines.html Don’t modify other people’s patches unless you have coordinated this with the owner of that patch. Not only is this considered rude, but your changes could be unintentionally lost. An exception to this would be for patches that have not been updated for more than 90 days. In that case, the patch can be taken over if the original author does not respond to requests for updates. Alternatively, a new patch can be pushed with the original content, and both patches should be updated to reference the other. Elyes, I didn't see any coordination happening with the owner of this patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 41 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 20 Aug 2020 08:21:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 41: (1 comment) https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... PS38, Line 2: : #include <device/pci_ops.h>
Done This change isn't to make Jenkins happy.
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 41 Gerrit-Owner: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Robin CASSET <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 20 Aug 2020 08:22:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
Skoll RC has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 41: (10 comments) Hi, Elyes can upload it is not a problem to me. As we are both french speakers, we discuss a lot in private. He helped me a lot to finish this port. If I have something in particular to let him upload, just let me know. I do not have a lot time to work on coreboot port so it's better if someone else can help. https://review.coreboot.org/c/coreboot/+/40813/33//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/40813/33//COMMIT_MSG@26 PS33, Line 26: - Tianocore payload (CorebootPayload)
Just a black screen without any outputs (no videos, no USB console). […] Done
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... File Documentation/mainboard/ongy/h61m-s1.md: https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 48: - There is no automatic, OS-independent fan control. : The `coretemp` driver can still be used for : accurate CPU temperature readings.
Your board doesn't have a SuperIO, so it doesn't really have this Done
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 51: - me_cleaner breaks LPC bus and attached components!
There is nothing on the LPC, I didn't remove this because there is in fact a problem with reduced ME […] Done
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 52: - Tianocore payload. The reason is yet undiscovered.
no! Maybe this is the problem. Done
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 66: -
Your board doesn't have a SuperIO, so it doesn't really have this Done
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... File Documentation/mainboard/ongy/h61m-s1.png: PS36:
This picture is really blurry and very large. […] Done
https://review.coreboot.org/c/coreboot/+/40813/35/Documentation/mainboard/on... File Documentation/mainboard/ongy/p8h61-m_pro.md: https://review.coreboot.org/c/coreboot/+/40813/35/Documentation/mainboard/on... PS35, Line 13: W25Q32BV
I need to replace with the correct flash chip model Done
https://review.coreboot.org/c/coreboot/+/40813/35/Documentation/mainboard/on... PS35, Line 51: me_cleaner breaks LPC bus and attached components!
Need to test this as quick as I can. I tried one's to use me_cleaner without success. […] Done
https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... PS38, Line 17: default ongy/h61m-s1
default "ongy/h61m-s1" Done
https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... PS38, Line 2: : #include <device/pci_ops.h>
not used. Please remove. Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 41 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 20 Aug 2020 15:52:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Skoll RC <amisbievre@posteo.net> Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
Skoll RC has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 41: (2 comments) https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig: https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... PS38, Line 17: default ongy/h61m-s1
Done Done
https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... PS38, Line 2: : #include <device/pci_ops.h>
Done Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 41 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 20 Aug 2020 15:52:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Skoll RC <amisbievre@posteo.net> Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 41:
Patch Set 41:
(10 comments)
Hi,
Elyes can upload it is not a problem to me. As we are both french speakers, we discuss a lot in private. He helped me a lot to finish this port. If I have something in particular to let him upload, just let me know. I do not have a lot time to work on coreboot port so it's better if someone else can help.
Oh, alright. Didn't know that you had been talking directly. -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 41 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 20 Aug 2020 16:25:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 41: (1 comment) https://review.coreboot.org/c/coreboot/+/40813/41/Documentation/mainboard/on... File Documentation/mainboard/ongy/h61m-s1.png: PS41: convert to jpg to reduce file size? Maybe rotate so that the print is readable? -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 41 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 25 Aug 2020 06:23:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel, Angel Pons, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40813 to look at the new patch set (#42). Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation Port done with the autoport utility. Tested: - SeaBIOS payload v1.13 stable - Restart, S3 resume and shutdown - Network (not PXE, Ubuntu 18.04 LTS, linux 4.15.0-99-generic) - USB boot (USB 2.0 only) - Integrated Sound - Integrated VGA and HDMI with libgfxinit - PCIe 16x port (with HD5450 - VGA only) - Memtest86 v5.01 pass when loaded from Ubuntu 18.04 live ISO - Internal flash using flashrom Not Working: - Memtest86 v5.01 payload freeze before starting - Tianocore payload (CorebootPayload) Signed-off-by: Robin CASSET <amisbievre@posteo.net> Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c --- A Documentation/mainboard/ongy/h61m-s1.jpg A Documentation/mainboard/ongy/h61m-s1.md A src/mainboard/ongy/Kconfig A src/mainboard/ongy/Kconfig.name A src/mainboard/ongy/h61m-s1/Kconfig A src/mainboard/ongy/h61m-s1/Kconfig.name A src/mainboard/ongy/h61m-s1/Makefile.inc A src/mainboard/ongy/h61m-s1/acpi/ec.asl A src/mainboard/ongy/h61m-s1/acpi/platform.asl A src/mainboard/ongy/h61m-s1/acpi/superio.asl A src/mainboard/ongy/h61m-s1/acpi_tables.c A src/mainboard/ongy/h61m-s1/board_info.txt A src/mainboard/ongy/h61m-s1/devicetree.cb A src/mainboard/ongy/h61m-s1/dsdt.asl A src/mainboard/ongy/h61m-s1/early_init.c A src/mainboard/ongy/h61m-s1/gma-mainboard.ads A src/mainboard/ongy/h61m-s1/gpio.c A src/mainboard/ongy/h61m-s1/hda_verb.c 18 files changed, 522 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40813/42 -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 42 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Skoll RC has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 42: (1 comment) Hi everyone! Done with image! sorry I wasn't very involved last months. I have time now to finish this port. https://review.coreboot.org/c/coreboot/+/40813/41/Documentation/mainboard/on... File Documentation/mainboard/ongy/h61m-s1.png: PS41:
convert to jpg to reduce file size? Maybe rotate so that the print is readable? Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 42 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 01 Oct 2020 13:03:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi@google.com> Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Patch Set 42: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/40813/42/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c: https://review.coreboot.org/c/coreboot/+/40813/42/src/mainboard/ongy/h61m-s1... PS42, Line 3: #include <device/pci_ops.h> not used? -- To view, visit https://review.coreboot.org/c/coreboot/+/40813 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 42 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Fri, 02 Oct 2020 10:13:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40813?usp=email ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Abandoned This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author. -- To view, visit https://review.coreboot.org/c/coreboot/+/40813?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 42 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: abandon
Felix Singer has restored this change. ( https://review.coreboot.org/c/coreboot/+/40813?usp=email ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/40813?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: restore Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 42 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40813?usp=email ) Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/40813?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c Gerrit-Change-Number: 40813 Gerrit-PatchSet: 42 Gerrit-Owner: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: Skoll RC <amisbievre@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
participants (8)
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
HAOUAS Elyes (Code Review)
-
Martin L Roth (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Robin CASSET (Code Review)
-
Skoll RC (Code Review)