Attention is currently required from: Julius Werner, Kapil Porwal. Swathi Tamilselvan has posted comments on this change by Swathi Tamilselvan. ( https://review.coreboot.org/c/coreboot/+/88175?usp=email ) Change subject: soc/qualcomm/x1p42100: Add Clock support for x1p42100 ...................................................................... Patch Set 6: (2 comments) File src/soc/qualcomm/x1p42100/clock.c: https://review.coreboot.org/c/coreboot/+/88175/comment/40ad5de2_9ec9c4c8?usp... : PS5, Line 11: KHz

MHz? Done

File src/soc/qualcomm/x1p42100/include/soc/clock.h: https://review.coreboot.org/c/coreboot/+/88175/comment/9746046d_88c29133?usp... : PS5, Line 10: #define SRC_XO_HZ (19200 * KHz)

Is the source oscillator on this platform actually 19. […] Yes the XO from PMIC is 38.4MHz, while there are some Internal drivers and final software use 19.2MHz.

-- To view, visit https://review.coreboot.org/c/coreboot/+/88175?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6252bc1fda3c53a683c65d2ab4a3b9f27ea64618 Gerrit-Change-Number: 88175 Gerrit-PatchSet: 6 Gerrit-Owner: Swathi Tamilselvan <tswathi@qualcomm.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com> Gerrit-Reviewer: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Julius Werner <jwerner@chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal@google.com> Gerrit-Attention: Julius Werner <jwerner@chromium.org> Gerrit-Comment-Date: Mon, 30 Jun 2025 23:22:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>