Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44240 ) Change subject: cpu/intel/model_6xx: Align cosmetics ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/coreboot/+/44240/5/src/cpu/intel/model_6xx/mod... File src/cpu/intel/model_6xx/model_6xx_init.c: https://review.coreboot.org/c/coreboot/+/44240/5/src/cpu/intel/model_6xx/mod... PS5, Line 18: /* Setup MTRRs */
I'd remove this form the other files. I'd say this is a matter of personal preference, and I wouldn't want to re-do the patch train again just to change this. Plus, Keith (or someone else with this hardware) still needs to test a few things.
Maybe we can handle this once the bottom half of this patch train (yes, these commits without any reviews) is merged? -- To view, visit https://review.coreboot.org/c/coreboot/+/44240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I825766a638581b247281df9d16bcfb9c02a43dad Gerrit-Change-Number: 44240 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 09 Aug 2020 07:33:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment