Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 ) Change subject: mb/asus: Add ASUS H110M-E/M.2 mainboard ...................................................................... Patch Set 97: (3 comments) https://review.coreboot.org/c/coreboot/+/34603/97//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/34603/97//COMMIT_MSG@31 PS97, Line 31: - External Graphics Cards works only with GOP, libgfxinit just wakes the main display with a blinking cursor even if I log into the system (when nomodeset kernel parameter enabled) through serial port (For MS Windows 8.1, the GUI works but installing the graphics driver trips the machine and for GNU/Linux (Linux 4.18, 5.4, Linux-libre 5.4, 5.5) , display only works with "nomodeset" kernel parameter). 3 out of 4 times the machine trips during the coreboot boot process at FspSiliconInit and if not then in the Graphics initialization process, once out of 100 times it somehow booted into GUI only on Ubuntu (Linux 4.18).
Please wrap the lines after 75 characters. The libgfxinit things are not about external graphics cards
https://review.coreboot.org/c/coreboot/+/34603/97//COMMIT_MSG@35 PS97, Line 35: S3 suspend/resume It would be good to describe what happens instead of the expected outcome. https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/ramstage.c: https://review.coreboot.org/c/coreboot/+/34603/97/src/mainboard/asus/h110m-e... PS97, Line 13: CdClock
How to test it or should I set it to Auto from 3? AFAIK, remove the line then check if video outputs still work
-- To view, visit https://review.coreboot.org/c/coreboot/+/34603 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8fa41ecccaa8dba8dc2158ce62d328c7928e05c Gerrit-Change-Number: 34603 Gerrit-PatchSet: 97 Gerrit-Owner: Pavlushka Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Maxim Polyakov <m.poliakov@yahoo.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Pavlushka Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-Comment-Date: Fri, 12 Jun 2020 19:42:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Pavlushka Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment