Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33867 ) Change subject: mb/lenovo: Add Lenovo Thinkpad Helix ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/33867/1/src/mainboard/lenovo/helix/Kconfig File src/mainboard/lenovo/helix/Kconfig: PS1: Configure the following options: - MAINBOARD_VENDOR - SUBSYSTEM_VENDOR_ID - SUBSYSTEM_DEVICE_ID - PXE_ROM_ID - CBFS_SIZE https://review.coreboot.org/#/c/33867/1/src/mainboard/lenovo/helix/Kconfig@1... PS1, Line 11: select MAINBOARD_HAS_LIBGFXINIT # FIXME: check this Extract VBT from vendor bios and add INTEL_GMA_HAVE_VBT here. Make sure to name it 'data.vbt'. -- To view, visit https://review.coreboot.org/c/coreboot/+/33867 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7dbf10bc85edb161fce077568d4ef3db91e10db7 Gerrit-Change-Number: 33867 Gerrit-PatchSet: 1 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 01 Jul 2019 12:09:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment