Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34632 ) Change subject: Documentation: Add guidelines for new mainboard ports ...................................................................... Patch Set 6: Code-Review+1 (4 comments) https://review.coreboot.org/c/coreboot/+/34632/6/Documentation/getting_start... File Documentation/getting_started/mainboard_template.md: https://review.coreboot.org/c/coreboot/+/34632/6/Documentation/getting_start... PS6, Line 72: * Does it support RS232 serial? Maybe add something to describe the voltage level if a TTL UART is available? https://review.coreboot.org/c/coreboot/+/34632/6/Documentation/getting_start... File Documentation/getting_started/new_mainboard_ports.md: https://review.coreboot.org/c/coreboot/+/34632/6/Documentation/getting_start... PS6, Line 30: Maybe add "if available" here avoid confusion? https://review.coreboot.org/c/coreboot/+/34632/6/Documentation/getting_start... PS6, Line 35: Some boards have two SPI flashes for ME and BIOS. Maybe more clear: "Some boards have two SPI flashes, one for ME and a second for BIOS." https://review.coreboot.org/c/coreboot/+/34632/6/Documentation/getting_start... PS6, Line 37: It It is -- To view, visit https://review.coreboot.org/c/coreboot/+/34632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I134dbf2341696ba0dd33c3d52bf787b8eaabbdab Gerrit-Change-Number: 34632 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 12 Mar 2020 06:39:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment