Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30942 ) Change subject: mainboard/samsung/350v5c: add initial board files ...................................................................... Patch Set 2: (3 comments)
Patch Set 2:
Here are the errors that are causing the build to fail verification:
src/mainboard/samsung/350v5c/acpi/ec.asl has no recognized license header. src/mainboard/samsung/350v5c/acpi/platform.asl has no recognized license header. src/mainboard/samsung/350v5c/dsdt.asl has no recognized license header. src/mainboard/samsung/350v5c/mainboard.c has no recognized license header. Error: Undefined Symbol 'BOARD_ROMSIZE_KB_6144' used at src/mainboard/samsung/350v5c/Kconfig:5
The license header errors are trivial to address. The latter should be addressed in a separate patch. https://review.coreboot.org/#/c/30942/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/30942/2//COMMIT_MSG@7 PS2, Line 7: update board_info.txt with correct info add new mainboard https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/board_i... File src/mainboard/samsung/350v5c/board_info.txt: https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/board_i... PS2, Line 4: SOP Usually referred to as SOIC, even if it's less precise. https://review.coreboot.org/#/c/30942/2/src/mainboard/samsung/350v5c/board_i... PS2, Line 6: no n -- To view, visit https://review.coreboot.org/c/coreboot/+/30942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64fcf931938fb3b158b9576b787f452bf6077843 Gerrit-Change-Number: 30942 Gerrit-PatchSet: 2 Gerrit-Owner: Kacper Słomiński <kacper.slominski72@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Kacper Słomiński <kacper.slominski72@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 16 Jan 2019 17:00:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment