Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35884 ) Change subject: soc/intel/Kconfig: Move MMCONF_BASE_ADDRESS out of a common place ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/c/coreboot/+/35884/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/35884/1//COMMIT_MSG@10 PS1, Line 10: This requires soc/intel target to : explicitly set this in the SOC dir
It's a bit like the overuse of __weak in soc/intel to make stuff build without being correct. […] To be clear, I'm just bikeshedding the relation to the previous sentence: if the fact that you added the compile time error would really require this change, Jenkins wouldn't have agreed on the original change :-p
What I read between the lines is roughly that "[To be really useful] this requires [...]". https://review.coreboot.org/c/coreboot/+/35884/1//COMMIT_MSG@12 PS1, Line 12: wrong
How can it be wrong? does the FSP binary depend on a specific […] I agree but still wonder: With a change like this, that has no technical requirement, how can we prevent that it's not turned back. e.g. somebody sees there are 8 out of 9 platforms that use the same value and puts it back into common/...
I don't like comments, but in this case it could help to add something like Needs to be what individual FSP versions expect. Keep this in the individual soc/ directory. -- To view, visit https://review.coreboot.org/c/coreboot/+/35884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcfea1718cc36ae16b491604786c26c6ed320f06 Gerrit-Change-Number: 35884 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Guckian <david.guckian@intel.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Vanny E <vanessa.f.eusebio@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-Comment-Date: Tue, 08 Oct 2019 13:44:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz> Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: comment