Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38012 ) Change subject: nb/intel/sandybridge: add and use ME stolen memory and lock bit defines ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/38012/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c: https://review.coreboot.org/c/coreboot/+/38012/1/src/northbridge/intel/sandy... PS1, Line 612: reg = reg | MELCK; // set lockbit on ME mem
Just curious of the line swap. […] The datasheet I have doesn't mention anything about this, so I don't know for sure. Since it is currently done in one write and seems to work, I'm not going to change this for now. Swapping the two lines here doesn't change the actual write in line 614, but makes more sense to me when reading the code. So this is just a cosmetic change.
-- To view, visit https://review.coreboot.org/c/coreboot/+/38012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4663498b10a5eedcc1aa51088b984ecc49ef23e Gerrit-Change-Number: 38012 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 31 Dec 2019 12:46:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-MessageType: comment