Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 ) Change subject: mainboard/asus: Add h110m-e_m2 mainboard support ...................................................................... Patch Set 24: (9 comments) https://review.coreboot.org/c/coreboot/+/34603/24//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/34603/24//COMMIT_MSG@7 PS24, Line 7: h110m-e_m2 very minor nit: this can be the pretty name: Add ASUS H110M-E M/2 mainboard (note that "support" has been omitted, as it's clear enough) https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/Makefile.inc: https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... PS24, Line 17: s You can remove this https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/acpi/superio.asl: PS24: Maybe this needs an update. https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... PS24, Line 98: .psi2threshold = 0x10, \ : .psi3threshold = 0x4, \ These can use VR_CFG_AMP too, see table above, column "SA" https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... PS24, Line 110: .psi1threshold = 0x50, \ : .psi2threshold = 0x14, \ : .psi3threshold = 0x4, \ same VR_CFG_AMP thing, row is "IA" https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... PS24, Line 123: .psi1threshold = 0x50, \ : .psi2threshold = 0x14, \ : .psi3threshold = 0x4, \ same, "GT unsliced" https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... PS24, Line 136: .psi1threshold = 0x50, \ : .psi2threshold = 0x14, \ : .psi3threshold = 0x4, \ same, "GT" https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... PS24, Line 253: subsystemid 0x1043 0x8694 inherit move to the previous line, before "device pci 00.0 on" https://review.coreboot.org/c/coreboot/+/34603/24/src/mainboard/asus/h110m-e... PS24, Line 275: end these stale "end" could be moved on the previous line -- To view, visit https://review.coreboot.org/c/coreboot/+/34603 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8fa41ecccaa8dba8dc2158ce62d328c7928e05c Gerrit-Change-Number: 34603 Gerrit-PatchSet: 24 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Maxim Polyakov <m.poliakov@yahoo.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 20 Aug 2019 10:59:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment