Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34686 ) Change subject: baytrail/rangeley: Update paths for FSP_FILE and VGA_BIOS_FILE ...................................................................... Patch Set 6: (2 comments) It's done https://review.coreboot.org/c/coreboot/+/34686/5//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/34686/5//COMMIT_MSG@7 PS5, Line 7: Update paths for FSP_FILE and VGA_BIOS_BIN
I don't see VGA_BIOS_BIN being changed, but rather VGA_BIOS_FILE. […] Ack
https://review.coreboot.org/c/coreboot/+/34686/5/src/mainboard/adi/rcc-dff/K... File src/mainboard/adi/rcc-dff/Kconfig: https://review.coreboot.org/c/coreboot/+/34686/5/src/mainboard/adi/rcc-dff/K... PS5, Line 39: config FSP_FILE
I would say the mainboard-specific Kconfig is now redundant, since it defines the same filepath as t […] Acknowledged SoC-specific Kconfig: Removing default FSP_FILE might affect other mainboards. Mainboard-specific Kconfig: preferred the default parameter(FSP_FILE) from mainboard over the soc. Also, anyone can take up initiative to clean up things with the different commit, I am just keeping the change as it is for now.
-- To view, visit https://review.coreboot.org/c/coreboot/+/34686 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35b0b08a13ad2deeb3e2efa146ab1916d5d23a14 Gerrit-Change-Number: 34686 Gerrit-PatchSet: 6 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: David Guckian <david.guckian@intel.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Huang Jin <huang.jin@intel.com> Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 07 Aug 2019 07:12:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment