Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Maximilian Brune.

View Change

1 comment:

• Patchset:

  • Patch Set #2:

    misc1 and misc2 are hpet_l and hpet_h. […]

    see register descriptions at the beginning of the FCH registers chapter for those two
    IOx00C01_x0A [Intr_Misc1Map] (FCH::IO::IntrMisc1Map)
    IOx00C01_x0B [Intr_Misc2Map] (FCH::IO::IntrMisc2Map)

    i'd say that having them named with what they do makes things a bit clearer.
    to ge the best of both, maybe do this like in the smi.h file:

    #define PIRQ_MISC1 0x0a /* Miscellaneous1 IRQ Settings */
    #define PIRQ_HPET_L PIRQ_MISC1
    #define PIRQ_MISC2 0x0b /* Miscellaneous2 IRQ Settings */
    #define PIRQ_HPET_H PIRQ_MISC2

To view, visit change 84574. To unsubscribe, or for help writing mail filters, visit settings.