Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39036 ) Change subject: mainboard/google/dedede: Migrate onto SKU ID/fw_config helpers ...................................................................... Patch Set 14: (1 comment) https://review.coreboot.org/c/coreboot/+/39036/12/src/mainboard/google/deded... File src/mainboard/google/dedede/Kconfig: https://review.coreboot.org/c/coreboot/+/39036/12/src/mainboard/google/deded... PS12, Line 8: select EC_GOOGLE_CHROMEEC_SKUID
Nit: Move it after EC_GOOGLE_CHROMEEC_ESPI. Just organized in alphabetical order. Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/39036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c21a748fddef0985022cb4e77a8db95d6692f4b Gerrit-Change-Number: 39036 Gerrit-PatchSet: 14 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Jett Rink <jettrink@chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 04 Mar 2020 03:46:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub@google.com> Gerrit-MessageType: comment