Attention is currently required from: Arthur Heymans, Arthur Heymans, Maximilian Brune, Philipp Hug, ron minnich. ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36486?usp=email ) Change subject: riscv/mb/qemu: fix DRAM probing ...................................................................... Patch Set 15: (1 comment) Patchset: PS15: I'm sure it's me, but if I Download this via a pull, it won't even build. I am using the same toolchain I use to build a working unmatched coreboot. /home/rminnich/coreboot/util/crossgcc/xgcc/bin/riscv64-elf-ld.bfd: build/bootblock/arch/riscv/romstage.o: in function `.L0 ': /home/rminnich/coreboot/src/arch/riscv/romstage.S:13: multiple definition of `_start'; build/bootblock/arch/riscv/bootblock.o:/home/rminnich/coreboot/src/arch/riscv/bootblock.S:23: first defined here /home/rminnich/coreboot/util/crossgcc/xgcc/bin/riscv64-elf-ld.bfd: build/bootblock/mainboard/emulation/qemu-riscv/romstage.o: in function `main': /home/rminnich/coreboot/src/mainboard/emulation/qemu-riscv/romstage.c:8: multiple definition of `main'; build/bootblock/lib/bootblock.o:/home/rminnich/coreboot/src/lib/bootblock.c:77: first defined here /home/rminnich/coreboot/util/crossgcc/xgcc/bin/riscv64-elf-ld.bfd: warning: build/cbfs/fallback/bootblock.debug has a LOAD segment with RWX permissions /home/rminnich/coreboot/util/crossgcc/xgcc/bin/riscv64-elf-ld.bfd: build/bootblock/lib/prog_loaders.o: in function `run_romstage': /home/rminnich/coreboot/src/lib/prog_loaders.c:23:(.text.run_romstage+0x8): undefined reference to `romstage_main' make: *** [src/arch/riscv/Makefile.mk:81: build/cbfs/fallback/bootblock.debug] Error 1 I'm a bit lost here. -- To view, visit https://review.coreboot.org/c/coreboot/+/36486?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I25860f688c7546714f6fdbce8c8f96da6400813c Gerrit-Change-Number: 36486 Gerrit-PatchSet: 15 Gerrit-Owner: Philipp Hug <philipp@hug.cx> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Marc Karasek <marckarasek@gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune@9elements.com> Gerrit-Reviewer: Philipp Hug <philipp@hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-CC: Arthur Heymans <arthur.heymans@9elements.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-CC: ron minnich Gerrit-Attention: Arthur Heymans <arthur.heymans@9elements.com> Gerrit-Attention: Philipp Hug <philipp@hug.cx> Gerrit-Attention: ron minnich Gerrit-Attention: Maximilian Brune <maximilian.brune@9elements.com> Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Comment-Date: Thu, 15 Feb 2024 18:58:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment