Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33884 ) Change subject: util/lint: check for Change-Id line presence and duplicates ...................................................................... Patch Set 3:
Patch Set 3: -Code-Review
I double checked, and our lint scripts are executed in the pre-commit hook (but only the "stable" ones), which is run before the commit-msg hook that adds Change-Id.
So what's the intended behavior for this?
Meaning the file should be renamed (to lint-stable-024-change-id), in order to be run from jenkins? -- To view, visit https://review.coreboot.org/c/coreboot/+/33884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67b9f134500bb596ae5790b68fe9f27e2fa2cfb4 Gerrit-Change-Number: 33884 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering <vidwer@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 12 Dec 2019 15:57:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment