Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48769 ) Change subject: mb/yanling: Add Yanling YL-KBR6L mainboard + doc ...................................................................... Patch Set 1:
I'm not sure if I have credited 3mdeb/Protectli enough and if not what should be added?
Cheers Thomas
To me it is enough to be mentioned in board documentation. Anyway 3mdeb and Protectli is in the AUTHORS file, so there isn't any distinction about single files now. First and foremost: does it boot well? -- To view, visit https://review.coreboot.org/c/coreboot/+/48769 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbc18914670f87f0943b371400c509ff0eeacf6a Gerrit-Change-Number: 48769 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 21 Dec 2020 16:38:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment