Attention is currently required from: Arthur Heymans, Arthur Heymans, Philipp Hug, ron minnich. ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36486?usp=email ) Change subject: riscv/mb/qemu: fix DRAM probing ...................................................................... Patch Set 9: (3 comments) File src/arch/riscv/ramdetect.c: https://review.coreboot.org/c/coreboot/+/36486/comment/d9997f14_5282dd10 : PS9, Line 21: #define insn_size 4
we can't. to be really sure we'd have to read the instruction from memory. […] Acknowledged
https://review.coreboot.org/c/coreboot/+/36486/comment/1ee489bb_9c0ad95e : PS9, Line 29: */
see above. Acknowledged
https://review.coreboot.org/c/coreboot/+/36486/comment/9d0ceb5e_573ddc61 : PS9, Line 35: uintptr_t addr = dram_start + (size * MiB) - sizeof(uint32_t);
dram_start is coming from the linker file and we assume that memory is usually aligned, if not I'd r […] Acknowledged
-- To view, visit https://review.coreboot.org/c/coreboot/+/36486?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I25860f688c7546714f6fdbce8c8f96da6400813c Gerrit-Change-Number: 36486 Gerrit-PatchSet: 9 Gerrit-Owner: Philipp Hug <philipp@hug.cx> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Marc Karasek <marckarasek@gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Philipp Hug <philipp@hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-CC: Arthur Heymans <arthur.heymans@9elements.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-CC: ron minnich Gerrit-Attention: Arthur Heymans <arthur.heymans@9elements.com> Gerrit-Attention: Philipp Hug <philipp@hug.cx> Gerrit-Attention: ron minnich Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Comment-Date: Mon, 05 Feb 2024 18:15:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Philipp Hug <philipp@hug.cx> Comment-In-Reply-To: ron minnich Gerrit-MessageType: comment