Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44241 ) Change subject: cpu/intel/model_6xx: Unify all Slot 1 CPUs ...................................................................... Patch Set 5:
Patch Set 5:
Patch Set 4:
(1 comment)
It might also be worth stating in the commit message that it assumes the only users of the CPU's will be slot_1 (which supports all of these?) and that further distinction should not be needed.
Done. Several of these CPUs aren't Slot 1: Pentium Pro is Socket 8, and later Pentium 3 are Socket 370. However... Slotkets! https://en.wikipedia.org/wiki/Slotket
Also, there's Socket 370 mainboards with the i440BX northbridge: https://en.wikipedia.org/wiki/ABIT_BP6 -- To view, visit https://review.coreboot.org/c/coreboot/+/44241 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22092d97c244263eec7e65abbfe2bbeb58680fc8 Gerrit-Change-Number: 44241 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 06 Aug 2020 16:11:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment