Attention is currently required from: Arthur Heymans, Arthur Heymans, Philipp Hug. ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36486?usp=email ) Change subject: riscv/mb/qemu: fix DRAM probing ...................................................................... Patch Set 9: (4 comments) Patchset: PS9: I had a few questions. File src/arch/riscv/ramdetect.c: https://review.coreboot.org/c/coreboot/+/36486/comment/31d456c6_f61d5590 : PS9, Line 21: #define insn_size 4 Is this true in an era of compact instruction extension? I no longer know. Should insn_size be define somewhere in <arch/...>? https://review.coreboot.org/c/coreboot/+/36486/comment/19ace76c_4b7b7f97 : PS9, Line 29: */ Can we ensure we never build with compact instrutions enabled? I'd be fine with that. https://review.coreboot.org/c/coreboot/+/36486/comment/f2207e23_717c9969 : PS9, Line 35: uintptr_t addr = dram_start + (size * MiB) - sizeof(uint32_t); Should we make sure dram_start is 32-bit aligned, in case of someone doing something silly? it would be a pain to take an alignment trap here. Or should the probe be for read8, just to be sure? -- To view, visit https://review.coreboot.org/c/coreboot/+/36486?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I25860f688c7546714f6fdbce8c8f96da6400813c Gerrit-Change-Number: 36486 Gerrit-PatchSet: 9 Gerrit-Owner: Philipp Hug <philipp@hug.cx> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Marc Karasek <marckarasek@gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Philipp Hug <philipp@hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-CC: Arthur Heymans <arthur.heymans@9elements.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-CC: ron minnich Gerrit-Attention: Arthur Heymans <arthur.heymans@9elements.com> Gerrit-Attention: Philipp Hug <philipp@hug.cx> Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Comment-Date: Sat, 03 Feb 2024 19:00:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment