Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34946 ) Change subject: WIP: add src/mainboard/hp/spectre_x360_13t_ae000 port ...................................................................... Patch Set 24: (4 comments) Some suggestions so that you can understand what romstage looks like better https://review.coreboot.org/c/coreboot/+/34946/24/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/memory.h: PS24: This isn't needed as you don't use variants https://review.coreboot.org/c/coreboot/+/34946/24/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/memory.c: PS24: This can be inside romstage.c https://review.coreboot.org/c/coreboot/+/34946/24/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/romstage.c: https://review.coreboot.org/c/coreboot/+/34946/24/src/mainboard/hp/spectre_x... PS24, Line 53: memory_params once you move the memory data into this file, this struct can be removed. Uninitialized fields are memset'd to zero on line 58, btw. https://review.coreboot.org/c/coreboot/+/34946/24/src/mainboard/hp/spectre_x... PS24, Line 75: mem_cfg->MemorySpdPtr10 = 0; Always run this for now, as bringing up one channel at a time is easier. -- To view, visit https://review.coreboot.org/c/coreboot/+/34946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie744cdccd3d110b4137e0b017b3f8497d23c0497 Gerrit-Change-Number: 34946 Gerrit-PatchSet: 24 Gerrit-Owner: Matt Parnell <mparnell@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Matt Parnell <mparnell@gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 21 Aug 2019 15:44:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment