Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30614 ) Change subject: soc/intel/cannonlake: Adding Kconfig option to disable the eMMC controller ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/30614/2/src/soc/intel/cannonlake/acpi/scs.as... File src/soc/intel/cannonlake/acpi/scs.asl: https://review.coreboot.org/#/c/30614/2/src/soc/intel/cannonlake/acpi/scs.as... PS2, Line 30: #
yes, those bits represents […] Well it should get evaluated for _ADR devices in general, not sure about absent _ADR devices. Though, if there is no rule to ignore _STA, that sounds like a bug in the OS.
Without _STA, OSPM has to assume the device is present. I trust you that you tested this in the past, but I'd still want to see the code to avoid misunderstandings. -- To view, visit https://review.coreboot.org/c/coreboot/+/30614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90c0230e845c8d02386b50b1100faf7064ecf8f6 Gerrit-Change-Number: 30614 Gerrit-PatchSet: 2 Gerrit-Owner: V Sowmya <v.sowmya@intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-Comment-Date: Sun, 13 Jan 2019 14:14:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subrata.banik@intel.com> Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz> Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: comment