Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33620 ) Change subject: soc/amd: Update ACPI code ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/33620/1/src/soc/amd/stoneyridge/acpi/sb_pci0... File src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl: https://review.coreboot.org/#/c/33620/1/src/soc/amd/stoneyridge/acpi/sb_pci0... PS1, Line 178: Method(OSFL, 0, NotSerialized) : { : If(LNotEqual(OSVR, Ones)) : { : Return(OSVR) : } : Store(0x03, OSVR) : If(CondRefOf(\_OSI, Local0)) : { : If(_OSI("Windows 2001")) : { : Store(0x04, OSVR) : } : If(_OSI("Windows 2001.1")) : { : Store(0x05, OSVR) : } : If(_OSI("FreeBSD")) : { : Store(0x06, OSVR) : } : If(_OSI("HP-UX")) : { : Store(0x07, OSVR) : } : If(_OSI("OpenVMS")) : { : Store(0x08, OSVR) : } : If(_OSI("Windows 2001 SP1")) : { : Store(0x09, OSVR) : } : If(_OSI("Windows 2001 SP2")) : { : Store(0x0A, OSVR) : } : If(_OSI("Windows 2001 SP3")) : { : Store(0x0B, OSVR) : } : If(_OSI("Windows 2006")) : { : Store(0x0C, OSVR) : } : If(_OSI("Windows 2006 SP1")) : { : Store(0x0D, OSVR) : } : If(_OSI("Windows 2009")) : { : Store(0x0E, OSVR) : } : If(_OSI("Windows 2012")) : { : Store(0x0F, OSVR) : } : If(_OSI("Windows 2013")) : { : Store(0x10, OSVR) : } : } : Else : { : Store (\_OS, local0) : If(MCTH(local0, "Microsoft Windows NT")) : { : Store(Zero, OSVR) : } : If(MCTH(local0, "Microsoft Windows")) : { : Store(One, OSVR) : } : If(MCTH(local0, "Microsoft WindowsME: Millennium Edition")) : { : Store(0x02, OSVR) : } : If(MCTH(local0, "Linux")) : { : Store(0x03, OSVR) : } : If(MCTH(local0, "FreeBSD")) : { : Store(0x06, OSVR) : } : If(MCTH(local0, "HP-UX")) : { : Store(0x07, OSVR) : } : If(MCTH(local0, "OpenVMS")) : { : Store(0x08, OSVR) : } : } : Return(OSVR) : }
Can this be factored out into a common location? You mean, something that can be used by all boards from now on as an include? Sure.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id3615a4460dd4e0c95e890a38210263dd8ea6887 Gerrit-Change-Number: 33620 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> Gerrit-Reviewer: Charles Marslett <charles.marslett@silverbackltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Lance Zhao <lance.zhao@gmail.com> Gerrit-Comment-Date: Thu, 20 Jun 2019 17:15:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment