Attention is currently required from: Arthur Heymans, Felix Singer, Maximilian Brune, ron minnich, ron minnich. Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36486?usp=email ) Change subject: riscv/mb/qemu: fix DRAM probing ...................................................................... Patch Set 17: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/36486/comment/7784be6e_741f5e79 : PS15, Line 8:
`Possible unwrapped commit description (prefer a maximum 72 chars per line)` […] Done
File src/arch/riscv/ramdetect.c: https://review.coreboot.org/c/coreboot/+/36486/comment/a6a8087d_c12be64f : PS15, Line 1: /* : * This file is part of the coreboot project. : * : * SPDX-License-Identifier: GPL-2.0-or-later : */
``` […]
Done https://review.coreboot.org/c/coreboot/+/36486/comment/7962c0cc_a7ef5fe1 : PS15, Line 24: uint16_t ins = mprv_read_mxr_u16((uint16_t *)vaddr);
Why use `mprv`? This should always be executed in machine mode. dropped
-- To view, visit https://review.coreboot.org/c/coreboot/+/36486?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I25860f688c7546714f6fdbce8c8f96da6400813c Gerrit-Change-Number: 36486 Gerrit-PatchSet: 17 Gerrit-Owner: Philipp Hug <philipp@hug.cx> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Marc Karasek <marckarasek@gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune@9elements.com> Gerrit-Reviewer: Philipp Hug <philipp@hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-CC: Arthur Heymans <arthur.heymans@9elements.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-CC: ron minnich Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de> Gerrit-Attention: Arthur Heymans <arthur.heymans@9elements.com> Gerrit-Attention: ron minnich Gerrit-Attention: Maximilian Brune <maximilian.brune@9elements.com> Gerrit-Attention: ron minnich <rminnich@gmail.com> Gerrit-Comment-Date: Fri, 01 Mar 2024 11:25:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit@felixsinger.de> Comment-In-Reply-To: Maximilian Brune <maximilian.brune@9elements.com> Gerrit-MessageType: comment