build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30942 ) Change subject: mainboard/samsung/350v5c: add initial board files ...................................................................... Patch Set 3: (48 comments) https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... File src/mainboard/samsung/350v5c/mainboard.c: https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 16: /* 00 */ 0x00, 0x00, 0x01, 0x00, 0x03, 0x00, 0x00, 0x00, trailing whitespace https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 16: /* 00 */ 0x00, 0x00, 0x01, 0x00, 0x03, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 17: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 19: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 20: /* 20 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, trailing whitespace https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 20: /* 20 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 21: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 22: /* 30 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, trailing whitespace https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 22: /* 30 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 23: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 24: /* 40 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, trailing whitespace https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 24: /* 40 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 25: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 27: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 27: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, code indent should use tabs where possible https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 27: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, please, no space before tabs https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 29: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 29: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, code indent should use tabs where possible https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 29: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, please, no space before tabs https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 31: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 31: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, code indent should use tabs where possible https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 31: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, please, no space before tabs https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 33: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 33: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, code indent should use tabs where possible https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 33: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, please, no space before tabs https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 35: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 35: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, code indent should use tabs where possible https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 35: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, please, no space before tabs https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 37: 0x64, 0x00, 0x00, 0x08, 0x64, 0x19, 0x00, 0xd8, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 37: 0x64, 0x00, 0x00, 0x08, 0x64, 0x19, 0x00, 0xd8, code indent should use tabs where possible https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 37: 0x64, 0x00, 0x00, 0x08, 0x64, 0x19, 0x00, 0xd8, please, no space before tabs https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 39: 0x00, 0x07, 0x00, 0x0f, 0x00, 0x4b, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 39: 0x00, 0x07, 0x00, 0x0f, 0x00, 0x4b, 0x00, 0x00, code indent should use tabs where possible https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 39: 0x00, 0x07, 0x00, 0x0f, 0x00, 0x4b, 0x00, 0x00, please, no space before tabs https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 41: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 41: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, code indent should use tabs where possible https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 41: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, please, no space before tabs https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 43: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 43: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, code indent should use tabs where possible https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 43: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, please, no space before tabs https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 45: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 45: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, code indent should use tabs where possible https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 45: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, please, no space before tabs https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 47: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 80 characters https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 47: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, code indent should use tabs where possible https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 47: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, please, no space before tabs https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 52: ec_write (i, dmp[i]); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/30942/3/src/mainboard/samsung/350v5c/mainboa... PS3, Line 63: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0); line over 80 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/30942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64fcf931938fb3b158b9576b787f452bf6077843 Gerrit-Change-Number: 30942 Gerrit-PatchSet: 3 Gerrit-Owner: Kacper Słomiński <kacper.slominski72@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Kacper Słomiński <kacper.slominski72@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 16 Jan 2019 16:59:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment