Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39036 ) Change subject: mainboard/google/dedede: Migrate onto SKU ID helpers ...................................................................... Patch Set 12: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/39036/12/src/mainboard/google/deded... File src/mainboard/google/dedede/board_info.c: https://review.coreboot.org/c/coreboot/+/39036/12/src/mainboard/google/deded... PS12, Line 52: sku_id == SKU_UNKNOWN || nit: sku_id > SKU_MAX is a superset of sku_id == SKU_UNKNOWN, so we could just write sku_id > SKU_MAX I know you didn't write the code though. -- To view, visit https://review.coreboot.org/c/coreboot/+/39036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c21a748fddef0985022cb4e77a8db95d6692f4b Gerrit-Change-Number: 39036 Gerrit-PatchSet: 12 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Jett Rink <jettrink@chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 28 Feb 2020 16:54:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment