Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39035 ) Change subject: mainboard/google/octopus: Migrate onto SKU ID helpers ...................................................................... Patch Set 11: Code-Review+2 (1 comment) https://review.coreboot.org/c/coreboot/+/39035/11/src/mainboard/google/octop... File src/mainboard/google/octopus/Makefile.inc: https://review.coreboot.org/c/coreboot/+/39035/11/src/mainboard/google/octop... PS11, Line 13: smm-y += mainboard_misc.c
this is the only thing that looks out of place, but this is because of the radio? Can you explain th […] Yes, for the lte thing. variant_smi_sleep() is ran in smm where it's switch()ing on sku id.
-- To view, visit https://review.coreboot.org/c/coreboot/+/39035 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60a37a5f9659b8df4018872956f95e07a3506440 Gerrit-Change-Number: 39035 Gerrit-PatchSet: 11 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Jett Rink <jettrink@chromium.org> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub@chromium.org> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 28 Feb 2020 21:11:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Jett Rink <jettrink@chromium.org> Gerrit-MessageType: comment