Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39035 ) Change subject: mainboard/google/octopus: Migrate onto SKU ID helpers ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/39035/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/Kconfig: https://review.coreboot.org/c/coreboot/+/39035/1/src/mainboard/google/octopu... PS1, Line 121: default 0xff # LEGACY SKU_ID space. Why not put this behind a Kconfig under the ec part that the mainboard just selects the "small id"? -- To view, visit https://review.coreboot.org/c/coreboot/+/39035 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60a37a5f9659b8df4018872956f95e07a3506440 Gerrit-Change-Number: 39035 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Jett Rink <jettrink@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Aaron Durbin <adurbin@chromium.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 21 Feb 2020 15:29:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment