Pavlushka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 ) Change subject: mb/asus: Add ASUS H110M-E/M.2 mainboard ...................................................................... Patch Set 88: (16 comments) ?? https://review.coreboot.org/c/coreboot/+/34603/87//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/34603/87//COMMIT_MSG@7 PS87, Line 7: .
No period here Done
https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/Kconfig: https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... PS87, Line 49: MAINBOARD_POWER_ON_AFTER_POWER_FAIL
This isn't necessary Done
https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/acpi/dptf.asl: PS87:
I still want to see if this is working at all. ??
https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... PS87, Line 9: B0D4
This device is not enabled in your devicetree.cb, I doubt this will work... So, what to do? remove the whole DTRT portion?
https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/cmos.layout: https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... PS87, Line 8: #0 8 r 0 seconds : #8 8 r 0 alarm_seconds : #16 8 r 0 minutes : #24 8 r 0 alarm_minutes : #32 8 r 0 hours : #40 8 r 0 alarm_hours : #48 8 r 0 day_of_week : #56 8 r 0 day_of_month : #64 8 r 0 month : #72 8 r 0 year : # ----------------------------------------------------------------- : # Status Register A : #80 4 r 0 rate_select : #84 3 r 0 REF_Clock : #87 1 r 0 UIP : # ----------------------------------------------------------------- : # Status Register B : #88 1 r 0 auto_switch_DST : #89 1 r 0 24_hour_mode : #90 1 r 0 binary_values_enable : #91 1 r 0 square-wave_out_enable : #92 1 r 0 update_finished_enable : #93 1 r 0 alarm_interrupt_enable : #94 1 r 0 periodic_interrupt_enable : #95 1 r 0 disable_clock_updates : # ----------------------------------------------------------------- : # Status Register C : #96 4 r 0 status_c_rsvd : #100 1 r 0 uf_flag : #101 1 r 0 af_flag : #102 1 r 0 pf_flag : #103 1 r 0 irqf_flag : # ----------------------------------------------------------------- : # Status Register D : #104 7 r 0 status_d_rsvd : #111 1 r 0 valid_cmos_ram : # ----------------------------------------------------------------- : # Diagnostic Status Register : #112 8 r 0 diag_rsvd1 : : # -----------------------------------------------------------------
Remove these Done
https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... PS87, Line 49: reserved_memory
KEEP this line! Done
https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... PS87, Line 50: #120 264 r 0 unused
Remove this one Done
https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... PS87, Line 56: #390 2 r 0 unused?
Remove Done
https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... PS87, Line 60: #392 3 r 0 unused
Remove Done
https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... PS87, Line 62: #399 1 r 0 unused
Remove Done
https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... PS87, Line 66: #401 7 r 0 unused
Remove Done
https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... PS87, Line 69: 408 1 e 1 nmi
Remove ("nmi" is unused in skylake) Done
https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... PS87, Line 71: #411 5 r 0 unused
Remove Done
https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... PS87, Line 73: # coreboot config options: bootloader : #Used by ChromeOS: : 416 128 r 0 vbnv : #544 440 r 0 unused : : # SandyBridge MRC Scrambler Seed values : 896 32 r 0 mrc_scrambler_seed : 928 32 r 0 mrc_scrambler_seed_s3
Remove Done
https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... PS87, Line 84: #1000 24 r 0 amd_reserved
Remove Done
https://review.coreboot.org/c/coreboot/+/34603/87/src/mainboard/asus/h110m-e... PS87, Line 91: 1 0 Disable : 1 1 Enable
Remove Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/34603 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8fa41ecccaa8dba8dc2158ce62d328c7928e05c Gerrit-Change-Number: 34603 Gerrit-PatchSet: 88 Gerrit-Owner: Pavlushka Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Maxim Polyakov <m.poliakov@yahoo.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Pavlushka Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 30 Mar 2020 14:44:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment