Jan. 28, 2019
4:27 a.m.
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30614 ) Change subject: soc/intel/cannonlake: Adding Kconfig option to disable the eMMC controller ...................................................................... Patch Set 3: (1 comment) > Patch Set 2: > > > Patch Set 2: > > > > @Arthur/Patrick R: Do you care to take -1 back? > > So you somehow need to manually sync this Kconfig option with the devicetree in which the eMMC controller gets disabled too? If so my -1 stays here. If you somehow really don't want this ACPI code to be included when the device is disabled, generate it on runtime like told before or put it in a different file and don't include DSDT but yet another Kconfig option does not seem like a good solution. @Arthur, Aligning with the approach that you suggested here i will be making the following changes, > SOC: Split the scs.asl into two different files (Sdcard and eMMC). > Mainboard: * Create a storage.asl for every variant and include the ASL files for storage they support. * Include the storage.asl in the mainboard dsdt.asl file. Any thoughts on the above mentioned changes or i will push this changes? https://review.coreboot.org/#/c/30614/2/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig: https://review.coreboot.org/#/c/30614/2/src/soc/intel/cannonlake/Kconfig@216 PS2, Line 216: > a newline to much. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/30614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90c0230e845c8d02386b50b1100faf7064ecf8f6 Gerrit-Change-Number: 30614 Gerrit-PatchSet: 3 Gerrit-Owner: V Sowmya <v.sowmya@intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-Comment-Date: Mon, 28 Jan 2019 04:27:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz> Gerrit-MessageType: comment