Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30942 ) Change subject: mainboard/samsung/350v5c: add initial board files ...................................................................... Patch Set 7: (3 comments) https://review.coreboot.org/#/c/30942/7/src/mainboard/Kconfig File src/mainboard/Kconfig: https://review.coreboot.org/#/c/30942/7/src/mainboard/Kconfig@27 PS7, Line 27: config BOARD_ROMSIZE_KB_6144 : bool I would mention this in the commit message. https://review.coreboot.org/#/c/30942/7/src/mainboard/samsung/350v5c/Makefil... File src/mainboard/samsung/350v5c/Makefile.inc: https://review.coreboot.org/#/c/30942/7/src/mainboard/samsung/350v5c/Makefil... PS7, Line 2: ramstage-y += um? https://review.coreboot.org/#/c/30942/7/src/mainboard/samsung/350v5c/devicet... File src/mainboard/samsung/350v5c/devicetree.cb: https://review.coreboot.org/#/c/30942/7/src/mainboard/samsung/350v5c/devicet... PS7, Line 2: , 0x80000410, 0x00000005 These can be dropped. -- To view, visit https://review.coreboot.org/c/coreboot/+/30942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64fcf931938fb3b158b9576b787f452bf6077843 Gerrit-Change-Number: 30942 Gerrit-PatchSet: 7 Gerrit-Owner: Kacper Słomiński <kacper.slominski72@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Kacper Słomiński <kacper.slominski72@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 17 Jan 2019 11:06:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment