Thomas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48769 ) Change subject: mb/yanling: Add Yanling YL-KBR6L mainboard + doc ...................................................................... Patch Set 1: (1 comment)
Patch Set 1:
I have got some new information. Protectli is going to ship these platforms as their product. I got the hardware with 8550U CPU and will help to fix remaining things. We will have to change the platform name and vendor accordingly.
Hey Michal, That is good news. How are we going to proceed? Are you taking over? Should I change the platform name and vendor? The new models as variants in vault_kbl or create a new one, e.g. vault_kbr? Or abandon this patch and you provide your fixed one? https://review.coreboot.org/c/coreboot/+/48769/1/Documentation/mainboard/yan... File Documentation/mainboard/yanling/yl-kbr6l.md: https://review.coreboot.org/c/coreboot/+/48769/1/Documentation/mainboard/yan... PS1, Line 3: Protectli FW6
Your right, I'll do that. Maybe to clarify: link to the coreboot doc page or to their homepage? And if to their coreboot doc page: I don't know if relative links work so I would have to add an absolute link... which will break if the directory structure changes.
-- To view, visit https://review.coreboot.org/c/coreboot/+/48769 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbc18914670f87f0943b371400c509ff0eeacf6a Gerrit-Change-Number: 48769 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 06 Jan 2021 07:40:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Comment-In-Reply-To: Thomas Gerrit-MessageType: comment