Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30942 ) Change subject: mainboard/samsung/350v5c: add initial board files and Kconfig option for 6 MB flash ...................................................................... Patch Set 8: (2 comments) https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/devicet... File src/mainboard/samsung/350v5c/devicetree.cb: https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/devicet... PS1, Line 33: :
Remove all "subsystemid" entries after this point, and add this here: […] Stupid me, it should be next to: device domain 0x0 on
https://review.coreboot.org/#/c/30942/8/src/mainboard/samsung/350v5c/devicet... File src/mainboard/samsung/350v5c/devicetree.cb: https://review.coreboot.org/#/c/30942/8/src/mainboard/samsung/350v5c/devicet... PS8, Line 67: end This can go in the previous line: device pci 16.1 off end # Management Engine Interface 2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64fcf931938fb3b158b9576b787f452bf6077843 Gerrit-Change-Number: 30942 Gerrit-PatchSet: 8 Gerrit-Owner: Kacper Słomiński <kacper.slominski72@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Kacper Słomiński <kacper.slominski72@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 17 Jan 2019 20:08:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment