Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34632 ) Change subject: Documentation: Add guidelines for new mainboard ports ...................................................................... Patch Set 4: (9 comments) https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... File Documentation/getting_started/mainboard_template.md: https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 24: * 'EVT early prototype' (Unit is for 'Engineering validation test') : * 'DVT prototype' (Unit is for 'Design verification test') This is generally confidential information, and is generally only a few months apart. https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 30: * What's the expected release date? This is also confidential information https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... File Documentation/getting_started/new_mainboard_ports.md: https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 7: It provides "It generally provides"? For example the AMD Picasso code won't be getting SPDs since memory is already up. https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 16: Try to find out as much as possible about the current hardware. : Dump information with existing tools: : * lspci : * lsusb : * superiotool : * inteltool : * ectool : * dmidecode : * acpidump This is only valid for a port from an IBV BIOS. https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 53: scheme instead. When it makes sense. https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 56: Provide good documentation, see point 4 This was discussed in the coreboot leadership meeting, and while desirable, documentation is NOT a requirement to submit a board, and should not be presented as such. https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 63: What you should **not** document: Why? https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 68: Recommended a flashing method as described in [Flashing tutorial] Doesn't this directly contradict point 5? https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... File Documentation/getting_started/writing_documentation.md: https://review.coreboot.org/c/coreboot/+/34632/4/Documentation/getting_start... PS4, Line 52: New mainboard ports should also add documentation "It's requested, although not required that new mainboards add documentation." -- To view, visit https://review.coreboot.org/c/coreboot/+/34632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I134dbf2341696ba0dd33c3d52bf787b8eaabbdab Gerrit-Change-Number: 34632 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 26 Aug 2019 21:44:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment