View Change

2 comments:

• File src/mainboard/google/dedede/Kconfig:

  • Patch Set #12, Line 8: select EC_GOOGLE_CHROMEEC_SKUID

    Nit: Move it after EC_GOOGLE_CHROMEEC_ESPI. Just organized in alphabetical order.

• File src/mainboard/google/dedede/board_info.c:

  • Patch Set #12, Line 52: sku_id == SKU_UNKNOWN ||

    nit: sku_id > SKU_MAX is a superset of sku_id == SKU_UNKNOWN, so we could just write sku_id > SKU_MA […]

    It is removed altogether here - https://review.coreboot.org/c/coreboot/+/39039/11 and is a follow-up CL in this CL stack.

To view, visit change 39036. To unsubscribe, or for help writing mail filters, visit settings.