Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 ) Change subject: mainboard/asus: Add ASUS H110M-E/M.2 mainboard ...................................................................... Patch Set 34: (1 comment) https://review.coreboot.org/c/coreboot/+/34603/34/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34603/34/src/mainboard/asus/h110m-e... PS34, Line 92: #| IccMax | 7A | 34A | 34A | 35A | 35A | : #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V | 1.52V | According to commits Change-Id: I303c5dc8ed03e9a98a834a2acfb400022dfc2fde and Change-Id: I849845ced094697e8700470b4af95ad0afb98e3e these values are set automatically in src/soc/intel/skylake/vr_config.c Please add information about this in the comments. For example #| IccMax* | 0 | 0 | 0 | 0 | 0 | #| VrVoltageLimit* | 0 | 0 | 0 | 0 | 0 | #+-----------------+---+----+----+---+---+ [*] Installed automatically for KBL-S and KBL-DT CPUs in the vr_config.c Something like that -- To view, visit https://review.coreboot.org/c/coreboot/+/34603 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8fa41ecccaa8dba8dc2158ce62d328c7928e05c Gerrit-Change-Number: 34603 Gerrit-PatchSet: 34 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Maxim Polyakov <m.poliakov@yahoo.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 21 Aug 2019 08:47:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment