Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30614 ) Change subject: soc/intel/cannonlake: Adding Kconfig option to disable the eMMC controller ...................................................................... Patch Set 3: (4 comments) https://review.coreboot.org/#/c/30614/3//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/30614/3//COMMIT_MSG@7 PS3, Line 7: Adding Please use imperative mood: Add https://review.coreboot.org/#/c/30614/3//COMMIT_MSG@9 PS3, Line 9: an Kconfig a Kconfig https://review.coreboot.org/#/c/30614/3//COMMIT_MSG@11 PS3, Line 11: … as there are platforms – like … – that do not have an eMMC slot(?). https://review.coreboot.org/#/c/30614/3/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig: https://review.coreboot.org/#/c/30614/3/src/soc/intel/cannonlake/Kconfig@194 PS3, Line 194: config EXCLUDE_EMMC_INTERFACE This should be name-spaced by prepending SOC_INTEL_. -- To view, visit https://review.coreboot.org/c/coreboot/+/30614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90c0230e845c8d02386b50b1100faf7064ecf8f6 Gerrit-Change-Number: 30614 Gerrit-PatchSet: 3 Gerrit-Owner: V Sowmya <v.sowmya@intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 28 Jan 2019 12:03:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment