Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34946 ) Change subject: WIP: add src/mainboard/hp/spectre_x360_13t_ae000 port ...................................................................... Patch Set 10: (3 comments) https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/Kconfig: https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 32: default "hp/hp_spectre_x360_13_convertible" Has to match the path in the filesystem https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 34: config DEVICETREE : string : default "devicetree.cb" Not needed https://review.coreboot.org/c/coreboot/+/34946/10/src/mainboard/hp/spectre_x... PS10, Line 38: config FMDFILE : string : default "" Same -- To view, visit https://review.coreboot.org/c/coreboot/+/34946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie744cdccd3d110b4137e0b017b3f8497d23c0497 Gerrit-Change-Number: 34946 Gerrit-PatchSet: 10 Gerrit-Owner: Matt Parnell <mparnell@gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Matt Parnell <mparnell@gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 19 Aug 2019 00:20:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment