[coreboot-gerrit] Change in coreboot[master]: Documentation: Add guidelines for new mainboard ports

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34632 ) Change subject: Documentation: Add guidelines for new mainboard ports ...................................................................... Patch Set 4: (17 comments) https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... File Documentation/getting_started/mainboard_template.md: https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 24: * 'EVT' : * 'DVT'

I find using abbreviations without explanation is a bad style. […] Done

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 28: 'EOL'

same here Done

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 40: * How can the blobs be retrieved?

these Done

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 55: Can you flash in-circuit using a SOIC-8 clip?

Please add here something to cover the board power supply. Something like: […] Done

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 124:

Remove the blank lines. Done

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... File Documentation/getting_started/new_mainboard_ports.md: https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 9: DRAM

Put on line above? Done

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 13: 1. Identify your platform

0. […] Done

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 22: * acpidump

Maybe we should write a little bit more here for people who are not familiar with the tools - what c […] Done

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 23:

Add a hint here to take care about the ME/TXE on Intel plattforms? Things like 'Has the mainboard on […] Mentioned SPI flash count here.

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 28: then provide a proper GPIO configuration and devicetree.cb.

Where do I get those from? Done

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 29: 3. Find a similar SuperIo or BMC

SuperIO Done

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 32: Some boards have UART hardware on the SoC, makeing external components

making Done

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 61: Recommand

Recommend Done

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 61: descibed

described Done

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 63: schematics as well.

if these are available. Done

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 65: pc

px Done

https://review.coreboot.org/c/coreboot/+/34632/3/Documentation/getting_start... PS3, Line 68: of

off Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/34632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I134dbf2341696ba0dd33c3d52bf787b8eaabbdab Gerrit-Change-Number: 34632 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 25 Aug 2019 13:01:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh@siemens.com> Comment-In-Reply-To: Christian Walter <christian.walter@9elements.com> Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment